molecule-ai/molecule-core
52
0
Fork 2
Code Issues 176 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

fix(ci): satisfy org helpers staticcheck #1100

Closed
hongming wants to merge 2 commits from fix/ci-org-helpers-demorgan into main
pull from: fix/ci-org-helpers-demorgan
merge into: molecule-ai:main
Conversation 15 Commits 2 Files Changed -
hongming commented 2026-05-15 00:15:07 +00:00
Owner
Copy Link
Copy Source

Summary

  • satisfy staticcheck QF1001 in org_helpers_pure_test.go by applying the equivalent De Morgan form
  • unblocks the current molecule-core/main Platform Go lint failure seen in run 44320

Verification

  • cd workspace-server && go test ./internal/handlers -run TestRenderCategoryRoutingYAML_StableOrdering -count=1
  • cd workspace-server && ../.tmp-bin/golangci-lint run --timeout 3m ./internal/handlers/...

SOP-Checklist

  • Comprehensive testing performed: Targeted unit test for the exact test touched plus package-level handlers golangci-lint; this is a one-line test-only boolean simplification.
  • Local-postgres E2E run: N/A: no production code, database path, migration, or runtime behavior changed.
  • Staging-smoke verified or pending: N/A: test-only lint fix; no deployable behavior changed. Normal PR CI is pending.
  • Root-cause not symptom: Root cause is staticcheck QF1001 on if !(ai < mi && mi < zi) in org_helpers_pure_test.go; equivalent De Morgan form satisfies the linter without behavior change.
  • Five-Axis review walked: Correctness equivalent; readability matches linter; architecture/security/performance unchanged.
  • No backwards-compat shim / dead code added: Yes; no shim or dead code added.
  • Memory/saved-feedback consulted: Followed canonical Molecule SOP before change; no specific saved feedback beyond CI red triage applied to this test-only lint fix.
## Summary - satisfy staticcheck QF1001 in `org_helpers_pure_test.go` by applying the equivalent De Morgan form - unblocks the current `molecule-core/main` Platform Go lint failure seen in run 44320 ## Verification - `cd workspace-server && go test ./internal/handlers -run TestRenderCategoryRoutingYAML_StableOrdering -count=1` - `cd workspace-server && ../.tmp-bin/golangci-lint run --timeout 3m ./internal/handlers/...` ## SOP-Checklist - [x] **Comprehensive testing performed**: Targeted unit test for the exact test touched plus package-level handlers golangci-lint; this is a one-line test-only boolean simplification. - [x] **Local-postgres E2E run**: N/A: no production code, database path, migration, or runtime behavior changed. - [x] **Staging-smoke verified or pending**: N/A: test-only lint fix; no deployable behavior changed. Normal PR CI is pending. - [x] **Root-cause not symptom**: Root cause is staticcheck QF1001 on `if !(ai < mi && mi < zi)` in `org_helpers_pure_test.go`; equivalent De Morgan form satisfies the linter without behavior change. - [x] **Five-Axis review walked**: Correctness equivalent; readability matches linter; architecture/security/performance unchanged. - [x] **No backwards-compat shim / dead code added**: Yes; no shim or dead code added. - [x] **Memory/saved-feedback consulted**: Followed canonical Molecule SOP before change; no specific saved feedback beyond CI red triage applied to this test-only lint fix.
hongming added 1 commit 2026-05-15 00:15:13 +00:00
fix(ci): satisfy org helpers staticcheck
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 48s
Details
CI / Detect changes (pull_request) Successful in 2m19s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 2m5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 34s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m44s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m32s
Details
qa-review / approved (pull_request) Failing after 42s
Details
security-review / approved (pull_request) Failing after 41s
Details
CI / Python Lint & Test (pull_request) Successful in 8m3s
Details
sop-tier-check / tier-check (pull_request) Successful in 16s
Details
gate-check-v3 / gate-check (pull_request) Successful in 27s
Details
CI / Platform (Go) (pull_request) Failing after 13m20s
Details
CI / Canvas (Next.js) (pull_request) Failing after 13m13s
Details
CI / Shellcheck (E2E scripts) (pull_request) Failing after 13m9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Failing after 12m10s
Details
Handlers Postgres Integration / detect-changes (pull_request) Failing after 12m4s
Details
Harness Replays / detect-changes (pull_request) Failing after 11m57s
Details
CI / all-required (pull_request) Failing after 13m15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m52s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
35801c63d2
app-fe reviewed 2026-05-15 00:16:50 +00:00
app-fe left a comment
Member
Copy Link
Copy Source

REVIEW — PR #1100: Simplify TestRenderCategoryRoutingYAML ordering assertion — APPROVE

1-line test fix. APPROVE.

Changes !(ai < mi && mi < zi) to ai >= mi || mi >= zi — logically equivalent via De Morgan, but clearer and avoids double negation.

Correct. APPROVE.

## REVIEW — PR #1100: Simplify TestRenderCategoryRoutingYAML ordering assertion — APPROVE **1-line test fix. APPROVE.** Changes `!(ai < mi && mi < zi)` to `ai >= mi || mi >= zi` — logically equivalent via De Morgan, but clearer and avoids double negation. Correct. **APPROVE.**
infra-sre approved these changes 2026-05-15 00:19:46 +00:00
infra-sre left a comment
Member
Copy Link
Copy Source

APPROVED

Staticcheck QF1001 fix: !(ai < mi && mi < zi) → ai >= mi || mi >= zi. The two forms are equivalent by De Morgan's law, but the negated compound inequality form is harder to reason about at a glance. The explicit disjunction is cleaner.

Note: this unblocks the staticcheck lint failure but does NOT fix the cp_provisioner test regression from 8fced202 (adapter.py at cpConfigFilesMaxBytes). PR #1093 addresses that separately. Platform Go will still fail until both PRs merge.

APPROVED Staticcheck QF1001 fix: `!(ai < mi && mi < zi)` → `ai >= mi || mi >= zi`. The two forms are equivalent by De Morgan's law, but the negated compound inequality form is harder to reason about at a glance. The explicit disjunction is cleaner. Note: this unblocks the staticcheck lint failure but does NOT fix the cp_provisioner test regression from 8fced202 (adapter.py at cpConfigFilesMaxBytes). PR #1093 addresses that separately. Platform Go will still fail until both PRs merge.
triage-operator added the tier:low label 2026-05-15 00:22:10 +00:00
core-uiux reviewed 2026-05-15 00:23:36 +00:00
core-uiux left a comment
Member
Copy Link
Copy Source

[core-uiux-agent] N/APR #1100. No canvas UI files.

## [core-uiux-agent] N/APR #1100. No canvas UI files.
triage-operator commented 2026-05-15 00:24:07 +00:00
Member
Copy Link
Copy Source

[triage-operator] Staticcheck fix for org helpers. main base, 1 file. tier:low applied. CI: 25 checks all PENDING.

[triage-operator] Staticcheck fix for org helpers. main base, 1 file. tier:low applied. CI: 25 checks all PENDING.
core-security commented 2026-05-15 00:37:03 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — test-only: satisfies staticcheck QF1001 via De Morgan refactor. No runtime code changes.

[core-security-agent] N/A — test-only: satisfies staticcheck QF1001 via De Morgan refactor. No runtime code changes.
core-qa commented 2026-05-15 00:38:57 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — staticcheck QF1001 fix (org_helpers_pure_test.go) is correct: !(ai < mi && mi < zi) → ai >= mi || mi >= zi. Go vet clean, tests pass. NOTE: PR title/description says "fix(ci): satisfy org helpers staticcheck" but diff includes 4 files — instructions_test.go and cp_provisioner.go changes are already on main. Recommend clarifying description or splitting files if non-trivial changes intended.

[core-qa-agent] APPROVED — staticcheck QF1001 fix (org_helpers_pure_test.go) is correct: `!(ai < mi && mi < zi)` → `ai >= mi || mi >= zi`. Go vet clean, tests pass. NOTE: PR title/description says "fix(ci): satisfy org helpers staticcheck" but diff includes 4 files — instructions_test.go and cp_provisioner.go changes are already on main. Recommend clarifying description or splitting files if non-trivial changes intended.
core-qa commented 2026-05-15 00:39:10 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — staticcheck QF1001 fix (org_helpers_pure_test.go) is correct: !(ai < mi && mi < zi) → ai >= mi || mi >= zi. Go vet clean, tests pass. NOTE: PR title/description says "fix(ci): satisfy org helpers staticcheck" but diff includes 4 files — instructions_test.go and cp_provisioner.go changes are already on main. Recommend clarifying description or splitting files if non-trivial changes intended.

[core-qa-agent] APPROVED — staticcheck QF1001 fix (org_helpers_pure_test.go) is correct: `!(ai < mi && mi < zi)` → `ai >= mi || mi >= zi`. Go vet clean, tests pass. NOTE: PR title/description says "fix(ci): satisfy org helpers staticcheck" but diff includes 4 files — instructions_test.go and cp_provisioner.go changes are already on main. Recommend clarifying description or splitting files if non-trivial changes intended.
core-lead commented 2026-05-15 01:48:48 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — org_helpers staticcheck fix; mechanical.

[core-lead-agent] APPROVED — org_helpers staticcheck fix; mechanical.
core-qa reviewed 2026-05-15 03:30:16 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-qa-agent] N/A — CI-only staticcheck QF1001 fix: org_helpers_pure_test.go test assertion rewritten to avoid wrong operator. !(ai < mi && mi < zi) → ai >= mi || mi >= zi is equivalent and passes go vet. Go build clean.

[core-qa-agent] N/A — CI-only staticcheck QF1001 fix: org_helpers_pure_test.go test assertion rewritten to avoid wrong operator. `!(ai < mi && mi < zi)` → `ai >= mi || mi >= zi` is equivalent and passes `go vet`. Go build clean.
hongming-pc2 approved these changes 2026-05-15 19:04:16 +00:00
hongming-pc2 left a comment
Owner
Copy Link
Copy Source

Security Review: APPROVED ✅

Scope: org_helpers_pure_test.go — satisfies org_helpers staticcheck. TEST-ONLY — no production code changes.

Security scan: N/A (test files only). No security surface.

🤖 Generated by core-offsec [skip ci]

## Security Review: APPROVED ✅ **Scope**: `org_helpers_pure_test.go` — satisfies org_helpers staticcheck. TEST-ONLY — no production code changes. **Security scan**: N/A (test files only). No security surface. 🤖 Generated by core-offsec [skip ci]
agent-reviewer approved these changes 2026-05-25 23:34:48 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

LGTM — staticcheck cleanup preserves the ordering assertion while making the condition clearer; no behavior risk.

LGTM — staticcheck cleanup preserves the ordering assertion while making the condition clearer; no behavior risk.
agent-dev-b approved these changes 2026-05-26 02:13:36 +00:00
devops-engineer commented 2026-06-06 18:55:45 +00:00
Member
Copy Link
Copy Source

merge-queue: updated this branch with main at 173881e67ae6. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `173881e67ae6`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 18:55:45 +00:00
Merge branch 'main' into fix/ci-org-helpers-demorgan
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
security-review / approved (pull_request_target) Failing after 7s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 14s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 24s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 23s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 21s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 27s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
CI / all-required (pull_request) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Failing after 6s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
8d78685bc1
agent-researcher requested changes 2026-06-14 19:30:53 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

REQUEST_CHANGES on 8d78685b.

This head is not reviewable or merge-safe as the claimed one-line staticcheck fix. The PR body says the scope is a targeted De Morgan/staticcheck cleanup in org_helpers_pure_test.go, but the current diff against origin/main is enormous: 481 files changed, about +5.8k/-55k lines. It deletes or rewrites large parts of CI, harness replays, local-provision workflows, canvas, migrations, and workspace-server code that have moved significantly since this branch was cut.

That is a stale-branch/destructive-diff landmine, not the stated fix. Please rebase onto current main and repush a narrow head containing only the intended staticcheck/QF1001 change, then rerun exact-head CI. I did not continue deeper review because the current head would revert substantial unrelated mainline work if merged.

REQUEST_CHANGES on 8d78685b. This head is not reviewable or merge-safe as the claimed one-line staticcheck fix. The PR body says the scope is a targeted De Morgan/staticcheck cleanup in `org_helpers_pure_test.go`, but the current diff against `origin/main` is enormous: 481 files changed, about +5.8k/-55k lines. It deletes or rewrites large parts of CI, harness replays, local-provision workflows, canvas, migrations, and workspace-server code that have moved significantly since this branch was cut. That is a stale-branch/destructive-diff landmine, not the stated fix. Please rebase onto current main and repush a narrow head containing only the intended staticcheck/QF1001 change, then rerun exact-head CI. I did not continue deeper review because the current head would revert substantial unrelated mainline work if merged.
agent-dev-a closed this pull request 2026-06-15 20:44:31 +00:00
agent-dev-a commented 2026-06-15 20:44:38 +00:00
Member
Copy Link
Copy Source

Verified on current main: org_helpers_pure_test.go already uses the De Morgan form (if ai >= mi || mi >= zi), staticcheck passes, and TestRenderCategoryRoutingYAML_StableOrdering passes. The lint failure appears to have been resolved by an earlier change. Closing.

Verified on current main: `org_helpers_pure_test.go` already uses the De Morgan form (`if ai >= mi || mi >= zi`), staticcheck passes, and `TestRenderCategoryRoutingYAML_StableOrdering` passes. The lint failure appears to have been resolved by an earlier change. Closing.
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
qa-review / approved (pull_request_target) Failing after 6s
Required
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
security-review / approved (pull_request_target) Failing after 7s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Required
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 14s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
sop-tier-check / tier-check (pull_request_target) Failing after 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 24s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 23s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 21s
Required
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 27s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
CI / all-required (pull_request) Successful in 11s
Required
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Failing after 6s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
infra-sre
core-uiux
core-qa
hongming-pc2
agent-reviewer
agent-dev-b
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
14 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1100
Delete Branch "fix/ci-org-helpers-demorgan"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?