Compare commits

...

2 Commits

Author SHA1 Message Date
core-uiux e335b7af56 fix(canvas): add focus-visible to secrets-tab add/clear-search buttons
audit-force-merge / audit (pull_request) Has been skipped
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
cascade-list-drift-gate / check (pull_request) Failing after 3s
Check migration collisions / Migration version collision check (pull_request) Successful in 7s
CI / Detect changes (pull_request) Successful in 8s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 27s
MCP Stdio Transport Regression / MCP stdio with regular-file stdout (pull_request) Successful in 1m24s
CI / Platform (Go) (pull_request) Successful in 5m39s
E2E API Smoke Test / detect-changes (pull_request) Successful in 12s
E2E Chat / detect-changes (pull_request) Successful in 13s
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
CI / Canvas (Next.js) (pull_request) Successful in 6m41s
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 35s
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
CI / Python Lint & Test (pull_request) Successful in 6m54s
Harness Replays / detect-changes (pull_request) Successful in 6s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 5s
CI / all-required (pull_request) Successful in 6m55s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m13s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 1m18s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m31s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 1m11s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
review-check-tests / review-check.sh regression tests (pull_request) Successful in 6s
publish-runtime-autobump / pr-validate (pull_request) Successful in 41s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 12s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m44s
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 27s
gate-check-v3 / gate-check (pull_request) Successful in 3s
qa-review / approved (pull_request) Successful in 4s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m18s
security-review / approved (pull_request) Successful in 6s
sop-checklist / review-refire (pull_request) Has been skipped
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request) Successful in 4s
sop-tier-check / tier-check (pull_request) Successful in 5s
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m32s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m5s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m44s
E2E Chat / E2E Chat (pull_request) Failing after 5m28s
Harness Replays / Harness Replays (pull_request) Successful in 4s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m29s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6m19s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m35s
Both .secrets-tab__add-btn and .secrets-tab__clear-search were missing
:focus-visible rules, violating WCAG 2.4.7 (Focus Visible). Keyboard
users tabbing to these buttons would see no visible focus indicator.

Fix: add :focus-visible { outline: var(--focus-ring); outline-offset:
var(--focus-ring-offset); } to both selectors, consistent with the
existing focus-visible pattern used throughout the settings panel.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 13:12:12 +00:00
core-uiux a6fe28df21 ci: retry Canvas CI (11th attempt) 2026-05-17 13:12:12 +00:00
+12
View File
@@ -411,6 +411,12 @@
color: #f4f4f5;
}
/* WCAG 2.4.7 — keyboard focus indicator */
.secrets-tab__add-btn:focus-visible {
outline: var(--focus-ring);
outline-offset: var(--focus-ring-offset);
}
/* ── Shared UI ─────────────────────────────────────── */
.key-value-field {
@@ -601,6 +607,12 @@
font-size: 14px;
}
/* WCAG 2.4.7 — keyboard focus indicator */
.secrets-tab__clear-search:focus-visible {
outline: var(--focus-ring);
outline-offset: var(--focus-ring-offset);
}
/* ── Delete confirmation dialog ────────────────────── */
.delete-dialog__overlay {