Compare commits

...

2 Commits

Author SHA1 Message Date
Molecule AI Dev Engineer A (Kimi) 719a0e5679 ci: remove unused canvasUserMessage type to fix lint on staging
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
CI / Detect changes (pull_request) Successful in 16s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 25s
E2E API Smoke Test / detect-changes (pull_request) Successful in 16s
E2E Chat / detect-changes (pull_request) Successful in 20s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 8s
Harness Replays / detect-changes (pull_request) Successful in 8s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m16s
CI / Platform (Go) (pull_request) Successful in 6m20s
CI / Python Lint & Test (pull_request) Successful in 7m2s
CI / Canvas (Next.js) (pull_request) Successful in 7m53s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 9s
CI / all-required (pull_request) Successful in 5m58s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
qa-review / approved (pull_request_target) Successful in 10s
security-review / approved (pull_request_target) Successful in 7s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 13s
sop-tier-check / tier-check (pull_request_target) Successful in 14s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m35s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Harness Replays / Harness Replays (pull_request) Successful in 3s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m58s
E2E Chat / E2E Chat (pull_request) Failing after 6m48s
audit-force-merge / audit (pull_request_target) Has been skipped
internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that
causes golangci-lint `unused` failure on every PR targeting staging.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-01 12:39:46 +00:00
Molecule AI Dev Engineer A (Kimi) 49c88239ae fix(restart_context): add rows.Err() checks after Next() loops
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
CI / Detect changes (pull_request) Successful in 12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 11s
CI / Platform (Go) (pull_request) Failing after 4m45s
CI / all-required (pull_request) Failing after 2s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
CI / Canvas (Next.js) (pull_request) Successful in 6m17s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
gate-check-v3 / gate-check (pull_request) Successful in 6s
qa-review / approved (pull_request) Successful in 6s
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request) Successful in 6s
security-review / approved (pull_request) Successful in 7s
sop-tier-check / tier-check (pull_request) Successful in 6s
CI / Python Lint & Test (pull_request) Successful in 7m21s
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Harness Replays / Harness Replays (pull_request) Successful in 5s
Harness Replays / detect-changes (pull_request) Successful in 6s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 25s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m17s
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m46s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
E2E Chat / E2E Chat (pull_request) Failing after 7m45s
E2E Chat / detect-changes (pull_request) Successful in 7s
Prevents silent ingestion of partial DB result sets if an error occurs
mid-iteration while scanning global_secrets and workspace_secrets.

Issue: a9999b7d
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-06-01 03:57:43 +00:00
2 changed files with 6 additions and 9 deletions
@@ -407,15 +407,6 @@ func validateCallerToken(ctx context.Context, c *gin.Context, callerID string) e
// matching (the wsauth errors are typed for the invalid case).
var errInvalidCallerToken = errors.New("missing caller auth token")
// canvasUserMessage holds the extracted user message extracted from an
// A2A canvas request body for broadcasting to other sessions.
type canvasUserMessage struct {
Message string `json:"message,omitempty"`
Parts []map[string]interface{} `json:"parts,omitempty"`
MessageID string `json:"messageId,omitempty"`
Attachments []map[string]interface{} `json:"attachments,omitempty"`
}
// extractCanvasUserMessage parses an A2A JSON-RPC request body and extracts
// the user-authored text and attachments from a canvas-initiated message/send.
// Returns nil when the body is not a canvas user message (empty, malformed,
@@ -139,6 +139,9 @@ func loadRestartContextData(ctx context.Context, workspaceID string) restartCont
keySet[k] = struct{}{}
}
}
if err := rows.Err(); err != nil {
log.Printf("restart-context: global_secrets rows error: %v", err)
}
rows.Close()
}
if rows, err := db.DB.QueryContext(ctx,
@@ -150,6 +153,9 @@ func loadRestartContextData(ctx context.Context, workspaceID string) restartCont
keySet[k] = struct{}{}
}
}
if err := rows.Err(); err != nil {
log.Printf("restart-context: workspace_secrets rows error: %v", err)
}
rows.Close()
}
for k := range keySet {