test(canvas/chat): add AttachmentLightbox coverage (13 cases)
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
Harness Replays / detect-changes (pull_request) Successful in 15s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
CI / Detect changes (pull_request) Successful in 59s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m2s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 49s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 54s
gate-check-v3 / gate-check (pull_request) Failing after 30s
qa-review / approved (pull_request) Failing after 20s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 45s
security-review / approved (pull_request) Failing after 22s
sop-tier-check / tier-check (pull_request) Successful in 25s
Harness Replays / Harness Replays (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 10s
CI / Python Lint & Test (pull_request) Successful in 12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 13s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m16s
CI / Canvas (Next.js) (pull_request) Successful in 13m28s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5s
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
Harness Replays / detect-changes (pull_request) Successful in 15s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
CI / Detect changes (pull_request) Successful in 59s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m2s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 49s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 54s
gate-check-v3 / gate-check (pull_request) Failing after 30s
qa-review / approved (pull_request) Failing after 20s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 45s
security-review / approved (pull_request) Failing after 22s
sop-tier-check / tier-check (pull_request) Successful in 25s
Harness Replays / Harness Replays (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 10s
CI / Python Lint & Test (pull_request) Successful in 12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 13s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 9s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m16s
CI / Canvas (Next.js) (pull_request) Successful in 13m28s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5s
+ AttachmentLightbox.test.tsx: 13 cases across render states, interaction, and focus management for the shared fullscreen modal. Per RFC #2991 Phase 2, AttachmentLightbox owns: backdrop + centered viewport, Esc to close, click-outside to close, focus trap (focus enters close button on open, restores on close), reduced-motion respect. Coverage: - open=false → renders nothing - role=dialog + aria-modal + aria-label - Close button aria-label="Close preview" - Click backdrop → onClose (e.target === e.currentTarget) - Click content → onClose NOT called (stopPropagation) - Escape key → onClose - Focus moves to close button on open - Focus restores to previous element on close - motion-reduce class on backdrop Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
parent
bcc2f0f870
commit
57a0bfd6a2
@ -0,0 +1,214 @@
|
||||
// @vitest-environment jsdom
|
||||
/**
|
||||
* AttachmentLightbox — shared fullscreen modal for image/PDF/preview.
|
||||
*
|
||||
* Per RFC #2991 Phase 2, AttachmentLightbox owns:
|
||||
* - Backdrop + centered viewport
|
||||
* - Esc to close
|
||||
* - Click-outside to close (stopPropagation on content)
|
||||
* - Focus trap: focus enters close button on open, restores on close
|
||||
* - prefers-reduced-motion respect
|
||||
*
|
||||
* NOTE: No @testing-library/jest-dom import — use textContent / className /
|
||||
* getAttribute / checked / value checks to avoid jest-dom dependency errors.
|
||||
*
|
||||
* Covers:
|
||||
* - Does not render when open=false
|
||||
* - Renders dialog with role=dialog and aria-modal
|
||||
* - Renders with provided aria-label
|
||||
* - Close button has aria-label="Close preview"
|
||||
* - Clicking backdrop (outside content) calls onClose
|
||||
* - Clicking content does NOT call onClose (stopPropagation)
|
||||
* - Escape key calls onClose
|
||||
* - Focus moves to close button when opened
|
||||
* - Focus restores to previous element when closed
|
||||
* - Reduced motion: motion-reduce class on backdrop
|
||||
* - Renders children inside the modal
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||
import React from "react";
|
||||
|
||||
import { AttachmentLightbox } from "../AttachmentLightbox";
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.restoreAllMocks();
|
||||
vi.resetModules();
|
||||
});
|
||||
|
||||
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
||||
|
||||
/** Renders the lightbox open with children and returns close fn */
|
||||
function renderOpen(props?: Partial<React.ComponentProps<typeof AttachmentLightbox>>) {
|
||||
const onClose = vi.fn();
|
||||
const result = render(
|
||||
<AttachmentLightbox
|
||||
open={true}
|
||||
onClose={onClose}
|
||||
ariaLabel="Image preview"
|
||||
{...props}
|
||||
>
|
||||
<img alt="test" src="data:image/png;base64,iVBORw0KGgo=" />
|
||||
</AttachmentLightbox>,
|
||||
);
|
||||
return { ...result, onClose };
|
||||
}
|
||||
|
||||
// ─── Render States ────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentLightbox — render", () => {
|
||||
it("does not render when open=false", () => {
|
||||
const { container } = render(
|
||||
<AttachmentLightbox
|
||||
open={false}
|
||||
onClose={vi.fn()}
|
||||
ariaLabel="Preview"
|
||||
>
|
||||
<div>content</div>
|
||||
</AttachmentLightbox>,
|
||||
);
|
||||
expect(container.firstChild).toBeNull();
|
||||
});
|
||||
|
||||
it("renders dialog with role=dialog and aria-modal", () => {
|
||||
renderOpen();
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog).toBeTruthy();
|
||||
expect(dialog?.getAttribute("aria-modal")).toBe("true");
|
||||
});
|
||||
|
||||
it("renders with provided aria-label", () => {
|
||||
renderOpen({ ariaLabel: "PDF: report-2026.pdf" });
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog?.getAttribute("aria-label")).toBe("PDF: report-2026.pdf");
|
||||
});
|
||||
|
||||
it("close button has aria-label='Close preview'", () => {
|
||||
renderOpen();
|
||||
const btn = document.querySelector('[aria-label="Close preview"]');
|
||||
expect(btn).toBeTruthy();
|
||||
expect(btn?.tagName).toBe("BUTTON");
|
||||
});
|
||||
|
||||
it("renders children inside the modal", () => {
|
||||
renderOpen({ ariaLabel: "Preview" });
|
||||
// Children are inside the dialog
|
||||
const dialog = document.querySelector('[role="dialog"]');
|
||||
expect(dialog?.querySelector("img")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("applies reduced-motion class on backdrop", () => {
|
||||
renderOpen();
|
||||
// The div[role="dialog"] IS the fixed backdrop — contains motion-reduce:transition-none
|
||||
const dialog = document.querySelector('[role="dialog"]') as HTMLElement;
|
||||
expect(dialog?.className).toContain("motion-reduce");
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Interaction ─────────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentLightbox — interaction", () => {
|
||||
it("calls onClose when close button is clicked", () => {
|
||||
const onClose = vi.fn();
|
||||
renderOpen({ onClose });
|
||||
const btn = document.querySelector('[aria-label="Close preview"]') as HTMLButtonElement;
|
||||
btn.click();
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("calls onClose when backdrop (outside content) is clicked", () => {
|
||||
const onClose = vi.fn();
|
||||
renderOpen({ onClose });
|
||||
// The div[role="dialog"] IS the backdrop (fixed inset-0).
|
||||
// Click on it — e.target === e.currentTarget triggers onBackdropClick.
|
||||
const backdrop = document.querySelector('[role="dialog"]') as HTMLElement;
|
||||
fireEvent.click(backdrop, { target: backdrop });
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("does NOT call onClose when content (inside modal) is clicked", () => {
|
||||
const onClose = vi.fn();
|
||||
renderOpen({ onClose });
|
||||
// Click on the img inside the modal
|
||||
const img = document.querySelector("img") as HTMLElement;
|
||||
fireEvent.click(img);
|
||||
expect(onClose).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("calls onClose on Escape key", () => {
|
||||
const onClose = vi.fn();
|
||||
renderOpen({ onClose });
|
||||
fireEvent.keyDown(document, { key: "Escape" });
|
||||
expect(onClose).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("does not call onClose for other keys", () => {
|
||||
const onClose = vi.fn();
|
||||
renderOpen({ onClose });
|
||||
fireEvent.keyDown(document, { key: "Enter" });
|
||||
fireEvent.keyDown(document, { key: "Tab" });
|
||||
expect(onClose).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
// ─── Focus Management ────────────────────────────────────────────────────────
|
||||
|
||||
describe("AttachmentLightbox — focus management", () => {
|
||||
it("moves focus to close button when opened", () => {
|
||||
renderOpen();
|
||||
const btn = document.querySelector('[aria-label="Close preview"]') as HTMLButtonElement;
|
||||
expect(document.activeElement).toBe(btn);
|
||||
});
|
||||
|
||||
it("restores focus to previous element when closed", () => {
|
||||
// Create a button to hold focus before opening the modal
|
||||
const outerBtn = document.createElement("button");
|
||||
outerBtn.textContent = "Open modal";
|
||||
document.body.appendChild(outerBtn);
|
||||
outerBtn.focus();
|
||||
expect(document.activeElement).toBe(outerBtn);
|
||||
|
||||
const onClose = vi.fn();
|
||||
const { rerender } = render(
|
||||
<AttachmentLightbox
|
||||
open={false}
|
||||
onClose={onClose}
|
||||
ariaLabel="Preview"
|
||||
>
|
||||
<div>content</div>
|
||||
</AttachmentLightbox>,
|
||||
);
|
||||
|
||||
// Open the modal
|
||||
rerender(
|
||||
<AttachmentLightbox
|
||||
open={true}
|
||||
onClose={onClose}
|
||||
ariaLabel="Preview"
|
||||
>
|
||||
<div>content</div>
|
||||
</AttachmentLightbox>,
|
||||
);
|
||||
|
||||
// Focus should now be on close button
|
||||
const btn = document.querySelector('[aria-label="Close preview"]') as HTMLButtonElement;
|
||||
expect(document.activeElement).toBe(btn);
|
||||
|
||||
// Close the modal
|
||||
rerender(
|
||||
<AttachmentLightbox
|
||||
open={false}
|
||||
onClose={onClose}
|
||||
ariaLabel="Preview"
|
||||
>
|
||||
<div>content</div>
|
||||
</AttachmentLightbox>,
|
||||
);
|
||||
|
||||
// Focus should be restored to outerBtn
|
||||
expect(document.activeElement).toBe(outerBtn);
|
||||
|
||||
document.body.removeChild(outerBtn);
|
||||
});
|
||||
});
|
||||
Loading…
Reference in New Issue
Block a user