fix(provision): resolve template-asset fetch by TEMPLATE not runtime (fixes seo-agent skills, #32) #2991

Merged

core-devops merged 1 commits from fix/template-asset-fetch-by-template-not-runtime into main 2026-06-16 15:27:44 +00:00

Conversation 0 Commits 1 Files Changed 2

+56 -1

core-devops commented 2026-06-16 15:23:50 +00:00

Member

Copy Link

Copy Source

ROOT CAUSE of SEO agents having no skills. The RFC#2843 fetch identity used payload.Runtime, but templateRepoByName is keyed by TEMPLATE NAME. A variant (seo-agent runs runtime=claude-code, template=seo-agent) resolved templateRepoByName[claude-code] = claude-code-default (no agent-skills/seo-all) → seo-agent skills NEVER fetched; config+prompts came via legacy SM path, masking it. Fix: resolve from payload.Template first, fall back to runtime. Verified: fetch yields 504KB incl 77 agent-skills files (under 16MiB cap). Adds TestTemplateIdentityForTemplateOrRuntime regression gate. Found via code-reading after box-log access was blocked.

ROOT CAUSE of SEO agents having no skills. The RFC#2843 fetch identity used payload.Runtime, but templateRepoByName is keyed by TEMPLATE NAME. A variant (seo-agent runs runtime=claude-code, template=seo-agent) resolved templateRepoByName[claude-code] = claude-code-default (no agent-skills/seo-all) → seo-agent skills NEVER fetched; config+prompts came via legacy SM path, masking it. Fix: resolve from payload.Template first, fall back to runtime. Verified: fetch yields 504KB incl 77 agent-skills files (under 16MiB cap). Adds TestTemplateIdentityForTemplateOrRuntime regression gate. Found via code-reading after box-log access was blocked.

core-devops added 1 commit 2026-06-16 15:23:50 +00:00

fix(provision): resolve template-asset fetch by TEMPLATE, not runtime (fixes seo-agent skills never delivered, #32) ... 6175814cfa

THE root cause of SEO agents having no agent-skills. The RFC #2843 fetch identity
was derived from payload.Runtime:
    TemplateIdentity: templateIdentityForRuntimeOrEmpty(payload.Runtime)
but templateRepoByName is keyed by TEMPLATE NAME (claude-code, seo-agent,
platform-agent, …; initTemplateRepoByName strips the -default suffix). A template
VARIANT like seo-agent runs runtime=claude-code with template=seo-agent — so the
fetch resolved templateRepoByName["claude-code"] (the claude-code-default
template), which has NO agent-skills/seo-all. The seo-agent template's skills
were therefore NEVER fetched; config.yaml + prompts arrived via the legacy SM
path, masking the gap. Verified live: a fresh seo-agent gets config+prompts but
agent-skills/seo-all is empty, on EVERY provision path.

Fix: resolve the fetch identity from payload.Template first, falling back to
runtime (templateIdentityForTemplateOrRuntime). For seo-agent this now resolves
the seo-agent repo → the fetch (verified: 504KB incl 77 agent-skills files, under
the 16MiB cap) delivers agent-skills/seo-all. Runtime fallback preserves the
common runtime==template-name case (hermes/codex/openclaw/google-adk); external
runtimes still resolve empty (fetcher skipped).

Adds TestTemplateIdentityForTemplateOrRuntime gating the regression (asserts the
seo-agent variant resolves to its OWN repo, not claude-code's).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

core-devops merged commit f57a32871e into main 2026-06-16 15:27:44 +00:00

core-devops referenced this pull request 2026-06-17 04:37:40 +00:00

fix(workspace): record declared plugins from fetched config on SaaS create (#32 keystone) #3008

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2991