molecule-ai/molecule-ai-workspace-template-codex
51
0
Fork 0
Code Issues 12 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

fix(codex): ignore legacy model-valued MODEL_PROVIDER #47

Merged
hongming merged 1 commits from fix/ignore-legacy-model-provider into main 2026-05-24 02:06:39 +00:00
Conversation 2 Commits 1 Files Changed 2
+43 -6
hongming commented 2026-05-24 02:02:44 +00:00
Owner
Copy Link
Copy Source

What

  • Treat MODEL_PROVIDER as an explicit Codex provider only when it matches the provider registry.
  • Ignore legacy model-id values like gpt-5.5 so subscription auth auto-detection still works.
  • Add regression coverage for the live staging failure shape.

Why

Live tenant smoke showed Codex workspaces booting with MODEL=gpt-5.5 and legacy MODEL_PROVIDER=gpt-5.5. The adapter interpreted that model id as a provider override and returned not_configured, causing A2A 503s.

Brief-falsification log

  • Hypothesis: L4 attachment byte delivery was still broken in Codex.
  • Evidence: live workspace console showed attachment image was never reached; adapter setup failed first with provider='gpt-5.5' not in registry.
  • Updated theory: runtime must tolerate stale controlplane/tenant MODEL_PROVIDER env during provider resolution.

Verification

  • PYTHONPATH=. pytest -q tests/test_modernization_pr1.py tests/test_provider_abstraction.py tests/test_executor.py
  • PYTHONPATH=. python3 -m py_compile adapter.py executor.py provider_config.py

Tier

L4 runtime adapter fix

## What - Treat MODEL_PROVIDER as an explicit Codex provider only when it matches the provider registry. - Ignore legacy model-id values like gpt-5.5 so subscription auth auto-detection still works. - Add regression coverage for the live staging failure shape. ## Why Live tenant smoke showed Codex workspaces booting with MODEL=gpt-5.5 and legacy MODEL_PROVIDER=gpt-5.5. The adapter interpreted that model id as a provider override and returned not_configured, causing A2A 503s. ## Brief-falsification log - Hypothesis: L4 attachment byte delivery was still broken in Codex. - Evidence: live workspace console showed attachment image was never reached; adapter setup failed first with provider='gpt-5.5' not in registry. - Updated theory: runtime must tolerate stale controlplane/tenant MODEL_PROVIDER env during provider resolution. ## Verification - PYTHONPATH=. pytest -q tests/test_modernization_pr1.py tests/test_provider_abstraction.py tests/test_executor.py - PYTHONPATH=. python3 -m py_compile adapter.py executor.py provider_config.py ## Tier L4 runtime adapter fix
hongming added 1 commit 2026-05-24 02:02:45 +00:00
fix(codex): ignore legacy model-valued MODEL_PROVIDER
CI / Template validation (static) (pull_request) Waiting to run
Details
CI / Adapter unit tests (pull_request) Waiting to run
Details
CI / Adapter unit tests (push) Successful in 13s
Details
CI / Template validation (static) (push) Successful in 30s
Details
CI / Template validation (runtime) (push) Successful in 4m44s
Details
CI / T4 tier-4 conformance (live) (push) Successful in 4m45s
Details
CI / validate (push) Successful in 3s
Details
CI / Template validation (runtime) (pull_request) Has been cancelled
Details
CI / T4 tier-4 conformance (live) (pull_request) Has been cancelled
Details
CI / validate (pull_request) Has been cancelled
Details
9244d9541a
infra-runtime-be approved these changes 2026-05-24 02:05:19 +00:00
infra-runtime-be left a comment
Member
Copy Link
Copy Source

Approved focused hotfix. Local parent verification: 60 passed across Codex modernization/provider/executor tests; subagent focused review found no blockers.

Approved focused hotfix. Local parent verification: 60 passed across Codex modernization/provider/executor tests; subagent focused review found no blockers.
core-devops approved these changes 2026-05-24 02:05:20 +00:00
core-devops left a comment
Member
Copy Link
Copy Source

Approved focused hotfix. Local parent verification: 60 passed across Codex modernization/provider/executor tests; subagent focused review found no blockers.

Approved focused hotfix. Local parent verification: 60 passed across Codex modernization/provider/executor tests; subagent focused review found no blockers.
hongming merged commit b07e128acc into main 2026-05-24 02:06:39 +00:00
hongming deleted branch fix/ignore-legacy-model-provider 2026-05-24 02:06:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
infra-runtime-be
core-devops
Labels
Clear labels
tier:low
per dev-SOP tier system
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer molecule-runtime-release-bot (Molecule Runtime Release Bot) plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-template-codex#47
Delete Branch "fix/ignore-legacy-model-provider"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?