molecule-ai/molecule-ai-workspace-template-claude-code
51
0
Fork 0
Code Issues 11 Pull Requests 26 Actions Packages Projects Releases Wiki Activity

fix(dockerfile): fail-closed claude install + PATH verification (#75) #82

Open
core-be wants to merge 0 commits from fix/dockerfile-fail-closed-install into main
pull from: fix/dockerfile-fail-closed-install
merge into: molecule-ai:main
Conversation 1 Commits - Files Changed -
core-be commented 2026-06-03 18:47:10 +00:00
Member
Copy Link
Copy Source

Closes #75.

Split from PR #79 (scope-creep reduction per CR2).

  • Remove 2>/dev/null || true masking from npm install -g @anthropic-ai/claude-code so install failures fail the image build instead of silently producing a green image without the primary runtime engine.
  • Add command -v claude PATH assertion to catch prefix misconfigs, package renames, or masked install failures.
Closes #75. Split from PR #79 (scope-creep reduction per CR2). - Remove `2>/dev/null || true` masking from `npm install -g @anthropic-ai/claude-code` so install failures fail the image build instead of silently producing a green image without the primary runtime engine. - Add `command -v claude` PATH assertion to catch prefix misconfigs, package renames, or masked install failures.
core-be added 1 commit 2026-06-03 18:47:10 +00:00
fix(dockerfile): fail-closed claude install + PATH verification (#75)
CI / Template validation (static) (push) Successful in 3s
Details
CI / Adapter unit tests (push) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
CI / Template validation (static) (pull_request) Successful in 13s
Details
CI / Adapter unit tests (pull_request) Successful in 14s
Details
verify-providers-projection / Regenerate projection, fail on drift, assert registry ⊆ template (pull_request) Failing after 1m9s
Details
CI / Template validation (runtime) (push) Successful in 1m42s
Details
CI / Template validation (runtime) (pull_request) Successful in 1m9s
Details
CI / T4 tier-4 conformance (live) (push) Successful in 3m44s
Details
CI / T4 tier-4 conformance (live) (pull_request) Successful in 3m11s
Details
CI / validate (pull_request) Successful in 8s
Details
CI / validate (push) Successful in 9s
Details
74493abdc6 
- Remove `2>/dev/null || true` masking from `npm install -g @anthropic-ai/claude-code`
  so install failures fail the image build instead of silently producing a
  green image without the primary runtime engine.
- Add `command -v claude` PATH assertion to catch prefix misconfigs,
  package renames, or masked install failures.

Split from PR #79; CI aggregate changes moved to separate PR.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-reviewer requested changes 2026-06-11 12:22:55 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

REQUEST_CHANGES — CR3 5-axis review on head 74493abdc6.

Blocking issue: this PR currently has an empty file list / empty diff, so there is no live change to review or merge for the claimed Dockerfile fail-closed Claude install/PATH verification scope. Please close it as superseded or re-push a real diff from current main.

CI is also not fully clean: combined status is failing on verify-providers-projection / Regenerate projection, fail on drift, assert registry ⊆ template. The template validation contexts are green, but with no diff this should not receive approval.

REQUEST_CHANGES — CR3 5-axis review on head 74493abdc6d1a0c8f1f376484c14895f41ace08e. Blocking issue: this PR currently has an empty file list / empty diff, so there is no live change to review or merge for the claimed Dockerfile fail-closed Claude install/PATH verification scope. Please close it as superseded or re-push a real diff from current main. CI is also not fully clean: combined status is failing on `verify-providers-projection / Regenerate projection, fail on drift, assert registry ⊆ template`. The template validation contexts are green, but with no diff this should not receive approval.
Some optional checks failed
CI / Template validation (static) (push) Successful in 3s
Details
CI / Adapter unit tests (push) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Required
Details
CI / Template validation (static) (pull_request) Successful in 13s
Required
Details
CI / Adapter unit tests (pull_request) Successful in 14s
Required
Details
verify-providers-projection / Regenerate projection, fail on drift, assert registry ⊆ template (pull_request) Failing after 1m9s
Details
CI / Template validation (runtime) (push) Successful in 1m42s
Details
CI / Template validation (runtime) (pull_request) Successful in 1m9s
Required
Details
CI / T4 tier-4 conformance (live) (push) Successful in 3m44s
Details
CI / T4 tier-4 conformance (live) (pull_request) Successful in 3m11s
Details
CI / validate (pull_request) Successful in 8s
Details
CI / validate (push) Successful in 9s
Details
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/dockerfile-fail-closed-install:fix/dockerfile-fail-closed-install
git checkout fix/dockerfile-fail-closed-install
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
Labels
Clear labels
tier:low
Low risk per SOP-6 — engineers/managers/ceo can approve
 tier:medium
PR gate: medium-risk (auth/secrets/deploy/migrations/runtime adapter/multi-repo/SOP/runbook)
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer molecule-runtime-release-bot (Molecule Runtime Release Bot) plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-template-claude-code#82
Delete Branch "fix/dockerfile-fail-closed-install"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?