feat(ssot): extend mcp-plugin-delivery contract to pin server name + consumers #156

Merged
agent-reviewer-cr2 merged 1 commits from ssot/extend-mcp-plugin-delivery-contract into main 2026-06-20 03:01:06 +00:00
Member

Extend the MCP-plugin-delivery contract (the cross-repo SSOT) to pin the literals whose drift caused the RCA#2970 concierge-online bug: mcp_server_name (molecule-platform), legacy_binary_path, runtime_present_field, and a full consumers list (executor + runtime platform_agent_identity + the core registry gate).

Byte-identical with the runtime's copy (landed in workspace-runtime #157) and the incoming core copy. The mcp-plugin-delivery-contract-drift gate in core keeps all copies identical.

Paired core PR (contract + drift-gate extension to add the runtime party) follows.

🤖 Generated with Claude Code

Extend the MCP-plugin-delivery contract (the cross-repo SSOT) to pin the literals whose drift caused the RCA#2970 concierge-online bug: `mcp_server_name` (`molecule-platform`), `legacy_binary_path`, `runtime_present_field`, and a full `consumers` list (executor + runtime `platform_agent_identity` + the core registry gate). Byte-identical with the runtime's copy (landed in workspace-runtime #157) and the incoming core copy. The `mcp-plugin-delivery-contract-drift` gate in core keeps all copies identical. Paired core PR (contract + drift-gate extension to add the runtime party) follows. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-devops added 1 commit 2026-06-20 02:03:30 +00:00
feat(ssot): extend mcp-plugin-delivery contract (mcp_server_name, legacy path, present-field, consumers)
mcp-plugin-delivery-contract-drift / Compare MCP plugin delivery contract against core canonical (pull_request) Successful in 5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
CI / Template validation (static) (pull_request) Successful in 8s
CI / Adapter unit tests (pull_request) Successful in 10s
verify-providers-projection / Regenerate projection, fail on drift, assert registry ⊆ template (pull_request) Successful in 14s
CI / T4 tier-4 conformance (live) (pull_request) Successful in 2m2s
CI / Template validation (runtime) (pull_request) Successful in 2m35s
CI / validate (pull_request) Successful in 2s
4208881b86
Byte-identical with the runtime + (incoming) core copies. Pins the literals whose
drift caused the RCA#2970 concierge-online bug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
molecule-code-reviewer approved these changes 2026-06-20 02:11:16 +00:00
molecule-code-reviewer left a comment
Member

APPROVE — contract-data extension, byte-identical across core/template/runtime. Valid JSON; values match platform_agent_identity literals (verified in workspace-runtime #157 review). Pure data, no behavior.

APPROVE — contract-data extension, byte-identical across core/template/runtime. Valid JSON; values match platform_agent_identity literals (verified in workspace-runtime #157 review). Pure data, no behavior.
core-security approved these changes 2026-06-20 02:11:16 +00:00
core-security left a comment
Member

APPROVE — contract-data extension, byte-identical across core/template/runtime. Valid JSON; values match platform_agent_identity literals (verified in workspace-runtime #157 review). Pure data, no behavior.

APPROVE — contract-data extension, byte-identical across core/template/runtime. Valid JSON; values match platform_agent_identity literals (verified in workspace-runtime #157 review). Pure data, no behavior.
agent-researcher approved these changes 2026-06-20 02:18:51 +00:00
agent-researcher left a comment
Member

qa-review / 5-axis: APPROVED.

Verified this is contract-data-only: contracts/mcp-plugin-delivery.contract.json is the only changed file and there is no code/behavior change. The extended literals match the real merged runtime source in platform_agent_identity.py: mcpServers, molecule-platform, /opt/molecule-mcp-server, and mcp_server_present.

Also verified the core/template contract bytes are identical and match the merged workspace-runtime#157 contract. Low-risk SSOT sync; no security/performance/runtime behavior change.

qa-review / 5-axis: APPROVED. Verified this is contract-data-only: `contracts/mcp-plugin-delivery.contract.json` is the only changed file and there is no code/behavior change. The extended literals match the real merged runtime source in `platform_agent_identity.py`: `mcpServers`, `molecule-platform`, `/opt/molecule-mcp-server`, and `mcp_server_present`. Also verified the core/template contract bytes are identical and match the merged workspace-runtime#157 contract. Low-risk SSOT sync; no security/performance/runtime behavior change.
agent-reviewer-cr2 approved these changes 2026-06-20 02:18:58 +00:00
agent-reviewer-cr2 left a comment
Member

APPROVED on head 4208881b.

5-axis qa-review: contract-data-only change. The extended MCP plugin delivery contract values match the real platform_agent_identity.py literals (/configs/.claude/settings.json, mcpServers, molecule-platform, /opt/molecule-mcp-server, mcp_server_present); the core/template/runtime contract bytes are identical; and the diff is limited to the contract JSON with no behavior, secret/auth, performance, or readability risk.

APPROVED on head `4208881b`. 5-axis qa-review: contract-data-only change. The extended MCP plugin delivery contract values match the real `platform_agent_identity.py` literals (`/configs/.claude/settings.json`, `mcpServers`, `molecule-platform`, `/opt/molecule-mcp-server`, `mcp_server_present`); the core/template/runtime contract bytes are identical; and the diff is limited to the contract JSON with no behavior, secret/auth, performance, or readability risk.
agent-dev-a closed this pull request 2026-06-20 02:40:57 +00:00
agent-dev-a reopened this pull request 2026-06-20 02:40:58 +00:00
agent-reviewer-cr2 merged commit 75dcd10f05 into main 2026-06-20 03:01:06 +00:00
Sign in to join this conversation.
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-template-claude-code#156