fix: prefer firefox for desktop browsing #69

Merged
hongming merged 1 commits from fix/xorg-firefox-display into main 2026-05-25 14:56:00 +00:00
Owner

What

  • Prefer Firefox for desktop_open_url when installed.
  • Keep Falkon and Chrome/Chromium as fallbacks.
  • Size Firefox/Falkon windows deterministically after launch.
  • Bump runtime to 0.3.5.

Why

Live display debugging showed Chrome, Falkon, and Epiphany could open windows under Xvfb, but browser page surfaces stayed gray. Firefox under Xorg dummy rendered Example Domain content correctly, so runtime should prefer the browser that works with the display backend.

Verification

  • PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q -> 8 passed
  • PYTHONPATH=$PWD pytest -q -> 369 passed
  • Live workspace proof on i-0b44c4a365494ba9d: Firefox on Xorg dummy rendered Example Domain content in screenshot /tmp/firefox-xorg-thumb.jpg.
## What - Prefer Firefox for `desktop_open_url` when installed. - Keep Falkon and Chrome/Chromium as fallbacks. - Size Firefox/Falkon windows deterministically after launch. - Bump runtime to 0.3.5. ## Why Live display debugging showed Chrome, Falkon, and Epiphany could open windows under Xvfb, but browser page surfaces stayed gray. Firefox under Xorg dummy rendered Example Domain content correctly, so runtime should prefer the browser that works with the display backend. ## Verification - `PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q` -> 8 passed - `PYTHONPATH=$PWD pytest -q` -> 369 passed - Live workspace proof on `i-0b44c4a365494ba9d`: Firefox on Xorg dummy rendered Example Domain content in screenshot `/tmp/firefox-xorg-thumb.jpg`.
hongming added 1 commit 2026-05-25 14:52:45 +00:00
fix: prefer firefox for desktop browsing
ci / smoke-install (pull_request) Waiting to run
ci / unit-tests (pull_request) Waiting to run
ci / lint (pull_request) Waiting to run
ci / build (pull_request) Waiting to run
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
8b3b9cc97e
infra-runtime-be approved these changes 2026-05-25 14:55:24 +00:00
infra-runtime-be left a comment
Member

Reviewed five-axis pass: correctness OK based on local full suite and live Xorg/Firefox rendering proof; readability/architecture OK (narrow browser preference/display backend changes); security OK (URL remains argv, no shell, display remains localhost-only); performance OK for display-enabled workspaces only. Gitea checks are Waiting with no action_task rows, so approval is based on direct verification.

Reviewed five-axis pass: correctness OK based on local full suite and live Xorg/Firefox rendering proof; readability/architecture OK (narrow browser preference/display backend changes); security OK (URL remains argv, no shell, display remains localhost-only); performance OK for display-enabled workspaces only. Gitea checks are Waiting with no action_task rows, so approval is based on direct verification.
dev-lead approved these changes 2026-05-25 14:55:25 +00:00
dev-lead left a comment
Member

Reviewed five-axis pass: correctness OK based on local full suite and live Xorg/Firefox rendering proof; readability/architecture OK (narrow browser preference/display backend changes); security OK (URL remains argv, no shell, display remains localhost-only); performance OK for display-enabled workspaces only. Gitea checks are Waiting with no action_task rows, so approval is based on direct verification.

Reviewed five-axis pass: correctness OK based on local full suite and live Xorg/Firefox rendering proof; readability/architecture OK (narrow browser preference/display backend changes); security OK (URL remains argv, no shell, display remains localhost-only); performance OK for display-enabled workspaces only. Gitea checks are Waiting with no action_task rows, so approval is based on direct verification.
hongming merged commit a28e493992 into main 2026-05-25 14:56:00 +00:00
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-runtime#69