fix: size falkon desktop browser windows #68

Merged
hongming merged 1 commits from fix/xvfb-falkon-window into main 2026-05-25 13:49:36 +00:00
Owner

Makes the Falkon desktop browser launch deterministic in Xvfb/noVNC.

Context:

  • Falkon renders correctly, but without explicit sizing it can restore a shallow window, leaving little usable page area.
  • Live test with --no-remote --new-window --profile molecule-desktop plus xdotool resize/activate rendered Example Domain in the display screenshot.

Changes:

  • launch Falkon with a stable profile/new-window mode and XDG runtime dir
  • resize/activate Falkon to 1280x900 after spawn using xdotool with no URL shell interpolation
  • bump runtime patch version to 0.3.4

Verification:

  • live workspace render test captured visible Example Domain after the deterministic launch sequence
  • PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q -> 7 passed
  • PYTHONPATH=$PWD pytest -q -> 368 passed
Makes the Falkon desktop browser launch deterministic in Xvfb/noVNC. Context: - Falkon renders correctly, but without explicit sizing it can restore a shallow window, leaving little usable page area. - Live test with `--no-remote --new-window --profile molecule-desktop` plus `xdotool` resize/activate rendered Example Domain in the display screenshot. Changes: - launch Falkon with a stable profile/new-window mode and XDG runtime dir - resize/activate Falkon to 1280x900 after spawn using xdotool with no URL shell interpolation - bump runtime patch version to 0.3.4 Verification: - live workspace render test captured visible Example Domain after the deterministic launch sequence - `PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q` -> 7 passed - `PYTHONPATH=$PWD pytest -q` -> 368 passed
hongming added 1 commit 2026-05-25 13:41:08 +00:00
fix: size falkon desktop browser windows
ci / lint (pull_request) Waiting to run
ci / unit-tests (pull_request) Waiting to run
ci / build (pull_request) Waiting to run
ci / smoke-install (pull_request) Waiting to run
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
6829ac3260
infra-runtime-be approved these changes 2026-05-25 13:47:40 +00:00
infra-runtime-be left a comment
Member

Reviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.

Reviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.
dev-lead approved these changes 2026-05-25 13:47:40 +00:00
dev-lead left a comment
Member

Reviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.

Reviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.
hongming merged commit 6b11e39676 into main 2026-05-25 13:49:36 +00:00
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-runtime#68