fix: size falkon desktop browser windows #68
Reference in New Issue
Block a user
Delete Branch "fix/xvfb-falkon-window"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Makes the Falkon desktop browser launch deterministic in Xvfb/noVNC.
Context:
--no-remote --new-window --profile molecule-desktopplusxdotoolresize/activate rendered Example Domain in the display screenshot.Changes:
Verification:
PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q-> 7 passedPYTHONPATH=$PWD pytest -q-> 368 passedReviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.
Reviewed five-axis pass for PR #68: correctness OK (Falkon launch uses argv/env, deterministic xdotool sizing matches live Xvfb proof); readability/architecture OK (narrow desktop tool change); security OK (URL remains argv, no shell); performance OK (one bounded xdotool call); tests OK (desktop tool coverage plus local full suite). Gitea CI is stuck Waiting with no task rows, so approving based on local verification: PYTHONPATH=$PWD pytest tests/test_desktop_tools.py -q and PYTHONPATH=$PWD pytest -q.