fix(runtime): normalize legacy attachment content URLs #66

2026-05-25T13:10:17Z

hongming commented

2026-05-25 13:10:17 +00:00

What

Normalize legacy /workspaces/<ws>/content/<file>/content attachment URIs to the current pending-upload fetch/ack endpoints.
Preserve cross-workspace token/platform URL lookup for those legacy URIs.
Let inbox rewrite cached legacy URIs to local file/workspace URIs before an external agent sees them.

Why

External/MCP workspaces can receive text normally but attachment messages fail when an in-flight or historical message contains the older platform content URL shape. The runtime must fetch/cache/ack those bytes the same way it handles platform-pending:.

Verification

PYTHONPATH=. pytest -q tests/test_executor_helpers.py tests/test_inbox_uploads_external.py
git diff --check

## What - Normalize legacy `/workspaces/<ws>/content/<file>/content` attachment URIs to the current pending-upload fetch/ack endpoints. - Preserve cross-workspace token/platform URL lookup for those legacy URIs. - Let inbox rewrite cached legacy URIs to local file/workspace URIs before an external agent sees them. ## Why External/MCP workspaces can receive text normally but attachment messages fail when an in-flight or historical message contains the older platform content URL shape. The runtime must fetch/cache/ack those bytes the same way it handles `platform-pending:`. ## Verification - `PYTHONPATH=. pytest -q tests/test_executor_helpers.py tests/test_inbox_uploads_external.py` - `git diff --check`

hongming added 1 commit 2026-05-25 13:10:17 +00:00

fix(runtime): normalize legacy attachment content URLs

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s

Details

ci / lint (pull_request) Successful in 44s

Details

ci / unit-tests (pull_request) Successful in 1m13s

Details

ci / smoke-install (pull_request) Successful in 56s

Details

ci / build (pull_request) Successful in 1m7s

Details

d90aad990c

sdk-lead approved these changes 2026-05-25 13:17:15 +00:00

sdk-lead left a comment

[sdk-lead-agent] APPROVED

Reviewed runtime URI normalization and regression coverage. Legacy platform content URLs now use the same authenticated pending-upload fetch/ack path and cached inbox rewrites. No findings.

[sdk-lead-agent] APPROVED Reviewed runtime URI normalization and regression coverage. Legacy platform content URLs now use the same authenticated pending-upload fetch/ack path and cached inbox rewrites. No findings.

integration-tester approved these changes 2026-05-25 13:20:08 +00:00

integration-tester left a comment

[integration-tester-agent] APPROVED

Reviewed focused tests for executor-helper fetch/ack and inbox rewrite compatibility. The regression path is covered. No findings.

[integration-tester-agent] APPROVED Reviewed focused tests for executor-helper fetch/ack and inbox rewrite compatibility. The regression path is covered. No findings.

release-manager approved these changes 2026-05-25 13:20:08 +00:00

release-manager left a comment

[release-manager-agent] APPROVED

Second review: checks are green, change is scoped to legacy attachment URI normalization with regression coverage. No release-blocking findings.

[release-manager-agent] APPROVED Second review: checks are green, change is scoped to legacy attachment URI normalization with regression coverage. No release-blocking findings.

hongming merged commit 7c2c0baa8f into main

2026-05-25 13:20:15 +00:00

hongming deleted branch fix/legacy-content-attachment-uri

2026-05-25 13:20:15 +00:00

hongming referenced this issue from a commit

2026-05-25 13:20:16 +00:00

Merge pull request 'fix(runtime): normalize legacy attachment content URLs' (#66) from fix/legacy-content-attachment-uri into main

hongming referenced this pull request

2026-05-25 13:26:56 +00:00

chore(release): bump runtime to 0.3.3 #67

Sign in to join this conversation.

No Reviewers