fix(plugins): default skill-shaped plugins to AgentskillsAdaptor (#32 activation) #148

2026-06-17T18:08:48Z

core-devops commented

2026-06-17 18:08:48 +00:00

Root cause of #32 activation: resolve() never selected AgentskillsAdaptor (checked name-registry + plugin-shipped adapter, then RawDrop), so skill-plugins like seo-all were dropped to /configs/plugins but never activated into /configs/skills where Claude Code reads. Fix: resolve() defaults skill-shaped plugins (skills/ or root SKILL.md) to AgentskillsAdaptor; install/uninstall handle the SKILL.md-at-root shape; SKIP_ROOT_MD+=skill.md. Tests added; existing green. Functionally verified locally. 🤖

core-devops added 1 commit 2026-06-17 18:08:49 +00:00

fix(plugins): default skill-shaped plugins to AgentskillsAdaptor (#32 activation)

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s

Details

ci / lint (pull_request) Successful in 20s

Details

ci / build (pull_request) Successful in 37s

Details

ci / smoke-install (pull_request) Successful in 58s

Details

ci / unit-tests (pull_request) Successful in 1m19s

Details

ci / responsiveness-e2e (pull_request) Successful in 1m47s

Details

84069f25ba

RFC#2843 #32 root cause: AgentskillsAdaptor is documented as "the default
adapter for the skills shape", but resolve() only ever checked the name-registry
and a plugin-shipped adapters/<runtime>.py, then fell straight to RawDropAdaptor.
So a skill plugin with no hand-written adapter (the common case — e.g. the
seo-all skill) hit RawDrop: files dropped to /configs/plugins/<name> but NEVER
activated into /configs/skills/ where Claude Code reads. AgentskillsAdaptor was
effectively dead code and skill-plugins were functionally uninstalled
("plugin X has no adaptor for runtime claude_code — files dropped … no
tools/sub-agents wired in", observed on a live prod box).

Fix (general, not per-plugin):
- resolve(): _resolve_agentskills_default — when a plugin is skill-shaped
  (has skills/ subdir OR a root SKILL.md), return AgentskillsAdaptor before the
  RawDrop fallback. Plain plugins still fall through.
- AgentskillsAdaptor.install()/uninstall(): handle the SKILL.md-at-root shape
  (no skills/<name>/ subdir) — copy the whole plugin dir to
  /configs/skills/<plugin_name>/ (excluding .git/__pycache__/adapters).
- SKIP_ROOT_MD += skill.md so the skill spec isn't double-appended to CLAUDE.md
  as a memory fragment.

Tests (plugins_registry/test_agentskills_default.py): root-skill resolves to
AGENTSKILLS not RAW_DROP; installs SKILL.md + companions into /configs/skills/;
plain plugin still RawDrop. Existing resolve tests green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

molecule-code-reviewer approved these changes 2026-06-17 18:09:32 +00:00

molecule-code-reviewer left a comment

Reviewed: resolve() defaults skill-shaped plugins to AgentskillsAdaptor (fixes the #32 dead-code activation gap); SKILL.md-at-root install handled; tests added + green locally. APPROVE.

core-security approved these changes 2026-06-17 18:09:33 +00:00

core-security left a comment

Reviewed: resolve() defaults skill-shaped plugins to AgentskillsAdaptor (fixes the #32 dead-code activation gap); SKILL.md-at-root install handled; tests added + green locally. APPROVE.

core-devops merged commit 3cca667fd2 into main

2026-06-17 18:11:00 +00:00

core-devops deleted branch fix/rfc2843-32-agentskills-resolve

2026-06-17 18:11:01 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-runtime#148