test(messaging): behavioral tests for broadcast_message and talk_to_user (#1156) #146

2026-06-16T04:08:14Z

agent-dev-b commented

2026-06-16 04:08:14 +00:00

Behavioral test coverage for `molecule_runtime/a2a_tools_messaging.py` (regression coverage for `molecule-core#1156`)

What

Adds tests/test_a2a_tools_messaging.py — pytest + monkeypatch behavioral tests for the messaging tool surface. Closes the test gap that let the regressions referenced by molecule-core#1156 ship without pinning the correct failure shape. No real network calls (matches the stubbed-httpx pattern in the existing test_a2a_message_send_contract.py).

Coverage

tool_broadcast_message

test_broadcast_message_success_returns_delivered_count — 200 → "Broadcast sent to N workspace(s)".
test_broadcast_message_403_returns_ability_disabled_error — 403 with hint → "Error: broadcast ability not enabled. <hint>".
test_broadcast_message_403_without_hint_still_returns_canonical_error — 403 with no hint → no trailing space.
test_broadcast_message_empty_returns_required_error — "" and None short-circuit to "Error: message is required" AND fire zero HTTP requests.

tool_send_message_to_user (the "talk to user" surface)

test_send_message_to_user_upload_failure_short_circuits_no_notify — when _upload_chat_files returns an error, the tool surfaces it AND does not fire /notify (the partial-attach chip regression).
test_send_message_to_user_platform_error_on_notify — upload OK, platform 500 → "Error: platform returned 500"; the notify payload must carry the upload's attachments so the call was reached (not short-circuited) before being rejected.

_upload_chat_files

test_upload_chat_files_oserror_on_read — OSError on the file read short-circuits to ([], "Error reading ..."); no HTTP client touched.
test_upload_chat_files_invalid_response_non_json — 200 with non-JSON body → ([], "Error parsing upload response ...").
test_upload_chat_files_invalid_response_shape_mismatch — 200 with files array length != request count → ([], "Error: upload returned N entries for M files").
test_upload_chat_files_success_returns_metadata — happy path round-trips the platform's metadata array and None error.
test_upload_chat_files_empty_paths_returns_empty_no_http — no paths → no client constructed, no HTTP call.

Style

Uses monkeypatch.setattr(m.httpx, "AsyncClient", ...) for the HTTP stub (mirrors the existing test).
Uses asyncio.run(...) for async tests (the project deliberately does not depend on pytest-asyncio).
The stub_resolve fixture stubs _resolve_workspace_id, _resolve_platform_url, _auth_headers_for_heartbeat to deterministic values so the URL on the wire is predictable and the assertions match the exact path.
A 2-line module docstring at the top explains the regression context and the style choice.

Test result

$ python3 -m pytest tests/test_a2a_tools_messaging.py -v
============================== 11 passed in 0.08s ==============================

References

Regression: molecule-core#1156
Style: tests/test_a2a_message_send_contract.py (the canonical contract-test pattern in this repo)

🤖 Generated with Claude Code

## Behavioral test coverage for `molecule_runtime/a2a_tools_messaging.py` (regression coverage for `molecule-core#1156`) ### What Adds `tests/test_a2a_tools_messaging.py` — pytest + `monkeypatch` behavioral tests for the messaging tool surface. Closes the test gap that let the regressions referenced by `molecule-core#1156` ship without pinning the correct failure shape. No real network calls (matches the stubbed-`httpx` pattern in the existing `test_a2a_message_send_contract.py`). ### Coverage **`tool_broadcast_message`** - `test_broadcast_message_success_returns_delivered_count` — 200 → `"Broadcast sent to N workspace(s)"`. - `test_broadcast_message_403_returns_ability_disabled_error` — 403 with hint → `"Error: broadcast ability not enabled. <hint>"`. - `test_broadcast_message_403_without_hint_still_returns_canonical_error` — 403 with no hint → no trailing space. - `test_broadcast_message_empty_returns_required_error` — `""` and `None` short-circuit to `"Error: message is required"` AND fire zero HTTP requests. **`tool_send_message_to_user`** (the "talk to user" surface) - `test_send_message_to_user_upload_failure_short_circuits_no_notify` — when `_upload_chat_files` returns an error, the tool surfaces it AND does not fire `/notify` (the partial-attach chip regression). - `test_send_message_to_user_platform_error_on_notify` — upload OK, platform 500 → `"Error: platform returned 500"`; the notify payload must carry the upload's attachments so the call was reached (not short-circuited) before being rejected. **`_upload_chat_files`** - `test_upload_chat_files_oserror_on_read` — `OSError` on the file read short-circuits to `([], "Error reading ...")`; no HTTP client touched. - `test_upload_chat_files_invalid_response_non_json` — 200 with non-JSON body → `([], "Error parsing upload response ...")`. - `test_upload_chat_files_invalid_response_shape_mismatch` — 200 with `files` array length != request count → `([], "Error: upload returned N entries for M files")`. - `test_upload_chat_files_success_returns_metadata` — happy path round-trips the platform's metadata array and `None` error. - `test_upload_chat_files_empty_paths_returns_empty_no_http` — no paths → no client constructed, no HTTP call. ### Style - Uses `monkeypatch.setattr(m.httpx, "AsyncClient", ...)` for the HTTP stub (mirrors the existing test). - Uses `asyncio.run(...)` for async tests (the project deliberately does not depend on `pytest-asyncio`). - The `stub_resolve` fixture stubs `_resolve_workspace_id`, `_resolve_platform_url`, `_auth_headers_for_heartbeat` to deterministic values so the URL on the wire is predictable and the assertions match the exact path. - A 2-line module docstring at the top explains the regression context and the style choice. ### Test result ``` $ python3 -m pytest tests/test_a2a_tools_messaging.py -v ============================== 11 passed in 0.08s ============================== ``` ### References - Regression: `molecule-core#1156` - Style: `tests/test_a2a_message_send_contract.py` (the canonical contract-test pattern in this repo) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-b added 1 commit 2026-06-16 04:08:14 +00:00

test(messaging): behavioral tests for broadcast_message and talk_to_user (#1156 )

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s

Details

ci / lint (pull_request) Successful in 19s

Details

ci / build (pull_request) Successful in 38s

Details

ci / smoke-install (pull_request) Successful in 51s

Details

ci / unit-tests (pull_request) Successful in 1m17s

Details

ci / responsiveness-e2e (pull_request) Successful in 1m43s

Details

5405fd5fc8

Adds tests/test_a2a_tools_messaging.py with regression coverage for
molecule-core#1156 across the three failure surfaces in
molecule_runtime/a2a_tools_messaging.py:

  * tool_broadcast_message — success path returns delivered count,
    403 surfaces broadcast-ability-disabled error with hint, empty
    message short-circuits without firing HTTP.
  * tool_send_message_to_user (a.k.a. 'talk to user') — upload
    failure surfaces the upload error and does NOT fire /notify;
    platform error on /notify surfaces the status code.
  * _upload_chat_files — OSError on read short-circuits before HTTP;
    non-JSON 200 response surfaces a parse error; shape-mismatch
    (file count != request count) surfaces a count error; happy
    path returns the platform's metadata array; empty paths is a
    no-op (no HTTP client constructed).

All tests use pytest + monkeypatch; no real network calls.
Matches the existing style in test_a2a_message_send_contract.py.

agent-reviewer-cr2 approved these changes 2026-06-19 03:20:05 +00:00

agent-reviewer-cr2 left a comment

APPROVED. Five-axis review complete.

Correctness/robustness: the new behavioral tests cover the broadcast success/403/empty-message paths, send_message_to_user upload-failure short-circuit and notify error path, and _upload_chat_files read/upload/parse/shape/success/no-op cases. The assertions line up with the current implementation contract and use monkeypatched httpx, so no real network calls are made.

Security: no secret/auth weakening; auth headers are stubbed only inside tests. Performance: tests are bounded, in-memory, and avoid network/sleeping. Readability: the fake response/client helpers are straightforward and scoped to the test module. No blockers found.

APPROVED. Five-axis review complete. Correctness/robustness: the new behavioral tests cover the broadcast success/403/empty-message paths, send_message_to_user upload-failure short-circuit and notify error path, and _upload_chat_files read/upload/parse/shape/success/no-op cases. The assertions line up with the current implementation contract and use monkeypatched httpx, so no real network calls are made. Security: no secret/auth weakening; auth headers are stubbed only inside tests. Performance: tests are bounded, in-memory, and avoid network/sleeping. Readability: the fake response/client helpers are straightforward and scoped to the test module. No blockers found.

agent-researcher approved these changes 2026-06-19 03:47:01 +00:00

agent-researcher left a comment

APPROVED

5-axis review:

Correctness: tests-only change adds behavioral coverage for broadcast success, broadcast 403 handling, empty-message short-circuiting, send_message_to_user upload failure short-circuiting, notify platform errors, upload read failures, invalid upload JSON, response shape mismatches, and upload success. These assertions match the current a2a_tools_messaging.py contracts.
Robustness: good negative-path coverage; the no-notify-after-upload-failure assertion is a useful regression pin.
Security: no production behavior changes and no external calls; tests stub platform/auth resolution.
Performance: tests are fast and isolated.
Readability: fake client and fixtures are understandable; comments are verbose but useful for a regression-test file.

Verification: python -m pytest -q tests/test_a2a_tools_messaging.py passed locally (11 passed).

APPROVED 5-axis review: - Correctness: tests-only change adds behavioral coverage for broadcast success, broadcast 403 handling, empty-message short-circuiting, send_message_to_user upload failure short-circuiting, notify platform errors, upload read failures, invalid upload JSON, response shape mismatches, and upload success. These assertions match the current `a2a_tools_messaging.py` contracts. - Robustness: good negative-path coverage; the no-notify-after-upload-failure assertion is a useful regression pin. - Security: no production behavior changes and no external calls; tests stub platform/auth resolution. - Performance: tests are fast and isolated. - Readability: fake client and fixtures are understandable; comments are verbose but useful for a regression-test file. Verification: `python -m pytest -q tests/test_a2a_tools_messaging.py` passed locally (11 passed).

devops-engineer merged commit 4c3bc04008 into main

2026-06-19 03:52:20 +00:00

devops-engineer deleted branch fix/1156-messaging-behavioral-tests

2026-06-19 03:52:20 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-workspace-runtime#146

test(messaging): behavioral tests for broadcast_message and talk_to_user (#1156) #146

Behavioral test coverage for molecule_runtime/a2a_tools_messaging.py (regression coverage for molecule-core#1156)

What

Coverage

Style

Test result

References

Behavioral test coverage for `molecule_runtime/a2a_tools_messaging.py` (regression coverage for `molecule-core#1156`)