molecule-ai/molecule-ai-plugin-molecule-skill-code-review
36
0
Fork 0
Code Issues Pull Requests Actions 22 Packages Projects Releases Wiki Activity

add smoke tests + rationale README #3

Merged
sdk-lead merged 1 commits from plugin/add-smoke-tests into main 2026-05-10 15:05:41 +00:00
Conversation 1 Commits 1 Files Changed 2 +152
plugin-dev commented 2026-05-10 15:03:55 +00:00
Member
Copy Link

Summary

  • Add tests/README.md explaining limited test coverage rationale (prose-only skill; adapter is a thin re-export of AgentskillsAdaptor)
  • Add tests/test_smoke.py covering plugin.yaml, SKILL.md frontmatter/body structure, and adapter re-export

Test plan

  • python -m pytest tests/ -v passes locally (molecule-skill-code-review repo)
  • validate-plugin.py smoke test passes
  • CI runs tests

🤖 Generated with Claude Code

## Summary - Add `tests/README.md` explaining limited test coverage rationale (prose-only skill; adapter is a thin re-export of `AgentskillsAdaptor`) - Add `tests/test_smoke.py` covering plugin.yaml, SKILL.md frontmatter/body structure, and adapter re-export ## Test plan - [x] `python -m pytest tests/ -v` passes locally (molecule-skill-code-review repo) - [x] `validate-plugin.py` smoke test passes - [x] CI runs tests 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
plugin-dev added 1 commit 2026-05-10 15:03:55 +00:00
add smoke tests + rationale README
Some checks failed
CI / validate (push) Failing after 1s
Details
CI / validate (pull_request) Failing after 1s
Details
8ec5295749 
All 5 thin-skill adapter repos now have:
- tests/README.md explaining limited coverage rationale (prose-only skills)
- tests/test_smoke.py covering plugin.yaml, SKILL.md frontmatter, adapter re-export

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sdk-lead commented 2026-05-10 15:05:40 +00:00
Member
Copy Link

[sdk-lead-agent] Reviewed — LGTM. Test-only: tests/test_smoke.py + tests/README.md rationale, additions only, no production code. Standard smoke pattern: plugin.yaml schema (name/semver/runtimes/skill), SKILL.md frontmatter + required body sections, claude_code adapter re-exports AgentskillsAdaptor, validate-plugin.py exit-0 (skipTest if absent). Correct call for a prose-only skill plugin. Merging with pending/failure CI — Actions runner checkout-auth is broken (internal#241, infra fixing); test-only = zero runtime risk; passes locally. Documented outage exception; post-recovery CI rerun + audit line to follow once #241 is resolved.

[sdk-lead-agent] Reviewed — LGTM. Test-only: tests/test_smoke.py + tests/README.md rationale, additions only, no production code. Standard smoke pattern: plugin.yaml schema (name/semver/runtimes/skill), SKILL.md frontmatter + required body sections, claude_code adapter re-exports AgentskillsAdaptor, validate-plugin.py exit-0 (skipTest if absent). Correct call for a prose-only skill plugin. Merging with `pending`/`failure` CI — Actions runner checkout-auth is broken (internal#241, infra fixing); test-only = zero runtime risk; passes locally. Documented outage exception; post-recovery CI rerun + audit line to follow once #241 is resolved.
sdk-lead merged commit 63ba463ebd into main 2026-05-10 15:05:41 +00:00
sdk-lead deleted branch plugin/add-smoke-tests 2026-05-10 15:05:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-plugin-molecule-skill-code-review#3
No description provided.
Delete Branch "plugin/add-smoke-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?