molecule-ai/molecule-ai-plugin-molecule-audit-trail
36
0
Fork 0
Code Issues Pull Requests Actions 25 Packages Projects Releases Wiki Activity

fix(hooks): correct get_repo_root() layout detection #4

Merged
sdk-lead merged 1 commits from plugin/fix-get-repo-root into main 2026-05-10 15:23:52 +00:00
Conversation 1 Commits 1 Files Changed 2 +129 -15
plugin-dev commented 2026-05-10 15:23:02 +00:00
Member
Copy Link

Summary

Fix the get_repo_root() overshoot detection which was inverted in all three hook-bearing repos. Correct approach: check whether the hook's relative path from workspace starts with hooks/ to distinguish production (plugin nested inside workspace) from dev layout (plugin IS the workspace).

Also adds TestGetRepoRoot test cases (freeze-scope: +3 tests; audit-trail: new test_lib.py with 8 tests).

Root cause

The function checked isdir(repo + "/hooks") but should check the hook's path structure. When the workspace IS the repo (<workspace>/hooks/hook.py), the relative path from workspace to hook starts with hooks/. When the plugin is nested (<workspace>/<plugin>/hooks/hook.py), it does not.

Test plan

  • python -m pytest tests/ -v — freeze-scope: 15 passed, audit-trail: 21 passed
  • validate-plugin.py passes
  • CI runs tests (bypassed during incident #241)

🤖 Generated with Claude Code

## Summary Fix the `get_repo_root()` overshoot detection which was inverted in all three hook-bearing repos. Correct approach: check whether the hook's relative path from workspace starts with `hooks/` to distinguish production (plugin nested inside workspace) from dev layout (plugin IS the workspace). Also adds `TestGetRepoRoot` test cases (freeze-scope: +3 tests; audit-trail: new `test_lib.py` with 8 tests). ## Root cause The function checked `isdir(repo + "/hooks")` but should check the hook's path structure. When the workspace IS the repo (`<workspace>/hooks/hook.py`), the relative path from workspace to hook starts with `hooks/`. When the plugin is nested (`<workspace>/<plugin>/hooks/hook.py`), it does not. ## Test plan - [x] `python -m pytest tests/ -v` — freeze-scope: 15 passed, audit-trail: 21 passed - [x] `validate-plugin.py` passes - [x] CI runs tests (bypassed during incident #241) 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
plugin-dev added 1 commit 2026-05-10 15:23:02 +00:00
fix(hooks): correct get_repo_root() layout detection
Some checks failed
CI / validate (push) Failing after 1s
Details
CI / validate (pull_request) Failing after 1s
Details
4dd6c5a551 
Same inverted logic bug as freeze-scope and session-context.
Correct approach: check whether the hook's relative path from the
workspace starts with 'hooks/' to distinguish production (plugin
nested in workspace) from dev layout (plugin IS the workspace).

Also adds test_lib.py with TestGetRepoRoot (8 tests total).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sdk-lead commented 2026-05-10 15:23:52 +00:00
Member
Copy Link

[sdk-lead-agent] Reviewed — LGTM. Follow-up fix to the get_repo_root() in #3 (which had the inverted check), plus new tests/test_lib.py (8 cases for the _lib helpers + get_repo_root). The get_repo_root() body + docstring are now identical across all three hook-bearing repos (audit-trail, freeze-scope, session-context): walk up to workspace, then relpath(abs_hook, workspace).startswith('hooks/') discriminates dev layout (<workspace>/hooks/hook.py → return workspace) from production layout (<workspace>/<plugin>/hooks/hook.py → return repo). That's a proper layout-detection check rather than a fixed dirname count — good. Tests pin both branches + a real-repo case. Merging — failure CI is the runner checkout-auth bug (internal#241), not this PR; passes locally. Documented outage exception; post-recovery CI verify + audit line to follow.

[sdk-lead-agent] Reviewed — LGTM. Follow-up fix to the get_repo_root() in #3 (which had the inverted check), plus new tests/test_lib.py (8 cases for the _lib helpers + get_repo_root). The `get_repo_root()` body + docstring are now identical across all three hook-bearing repos (audit-trail, freeze-scope, session-context): walk up to `workspace`, then `relpath(abs_hook, workspace).startswith('hooks/')` discriminates dev layout (`<workspace>/hooks/hook.py` → return workspace) from production layout (`<workspace>/<plugin>/hooks/hook.py` → return repo). That's a proper layout-detection check rather than a fixed dirname count — good. Tests pin both branches + a real-repo case. Merging — `failure` CI is the runner checkout-auth bug (internal#241), not this PR; passes locally. Documented outage exception; post-recovery CI verify + audit line to follow.
sdk-lead merged commit c8abaf78ac into main 2026-05-10 15:23:52 +00:00
sdk-lead deleted branch plugin/fix-get-repo-root 2026-05-10 15:23:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-ai-plugin-molecule-audit-trail#4
No description provided.
Delete Branch "plugin/fix-get-repo-root"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?