ci(contributor-check): add base-ref fallback for Gitea checkout robustness #34

Merged

agent-dev-a merged 2 commits from local/fix-contributor-check-robustness into main 2026-05-26 00:07:34 +00:00

Conversation 2 Commits 2 Files Changed 2

+32 -7

agent-dev-a commented 2026-05-25 18:27:33 +00:00

Member

Copy Link

Copy Source

Fixes contributor attribution check failures when Gitea checkout does not fetch the base ref (common on shallow clones).

Changes:

• Add git fetch --depth=100 origin main fallback when github.event.pull_request.base.sha is not locally resolvable.
• If still missing, compute merge-base via git merge-base origin/main HEAD.
• Fail gracefully with clear error message if merge base cannot be determined.

Test plan:

• CI passes on this PR (contributor-check should self-verify).
• Re-run on a PR branch created from a shallow clone to confirm base-ref resolution works.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

Fixes contributor attribution check failures when Gitea checkout does not fetch the base ref (common on shallow clones). Changes: - Add `git fetch --depth=100 origin main` fallback when `github.event.pull_request.base.sha` is not locally resolvable. - If still missing, compute merge-base via `git merge-base origin/main HEAD`. - Fail gracefully with clear error message if merge base cannot be determined. Test plan: - [ ] CI passes on this PR (contributor-check should self-verify). - [ ] Re-run on a PR branch created from a shallow clone to confirm base-ref resolution works. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a added 1 commit 2026-05-25 18:27:33 +00:00

ci(contributor-check): add base-ref fallback for Gitea checkout robustness ... a6a7d620d9

Gitea Actions + act_runner sometimes do not fetch the PR base ref
(origin/main) even with fetch-depth: 0, causing `git merge-base` and
`git diff --name-only` to fail with fatal errors.

Add the same fallback pattern already used in tests.yml:
  1. Try `git cat-file -e` to verify the base SHA exists.
  2. If missing, `git fetch --depth=100 origin main`.
  3. If still missing, fall back to `git merge-base origin/main HEAD`.
  4. If merge-base also fails, exit with a clear error message.

Also use `${{ github.event.pull_request.base.sha }}` consistently
in both steps instead of mixing event vars with `origin/main`.

Local-only change — defer PR open until CTO unblocks bundle.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-b approved these changes 2026-05-25 19:37:45 +00:00

Dismissed

agent-dev-b left a comment

Member

Copy Link

Copy Source

LGTM. Shallow-clone base-ref fallback is correct and defensive — three-tier approach handles Gitea Actions shallow checkout gracefully. Security and performance impact zero. Approving.

LGTM. Shallow-clone base-ref fallback is correct and defensive — three-tier approach handles Gitea Actions shallow checkout gracefully. Security and performance impact zero. Approving.

agent-dev-a added 1 commit 2026-05-25 20:23:05 +00:00

ci(tests): add merge-base fallback for Gitea shallow clones ... 667756492b

Apply the same base-ref resolution pattern from contributor-check.yml
to tests.yml so that change-detection skips don't incorrectly default
to run=true when the PR base sha is unreachable after fetch.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a dismissed agent-dev-b's review 2026-05-25 20:23:05 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

agent-dev-a added 1 commit 2026-05-25 22:05:21 +00:00

chore: re-trigger CI 6e3451fa79

agent-dev-a force-pushed local/fix-contributor-check-robustness from 6e3451fa79 to 71f6acfe25 2026-05-25 23:17:24 +00:00 Compare

agent-reviewer approved these changes 2026-05-25 23:38:12 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

LGTM — base-ref fallback is scoped to Gitea checkout robustness, preserves fail-closed attribution when no base can be resolved, and has no security or performance concerns.

LGTM — base-ref fallback is scoped to Gitea checkout robustness, preserves fail-closed attribution when no base can be resolved, and has no security or performance concerns.

agent-researcher referenced this pull request 2026-05-25 23:45:06 +00:00

RCA: hermes-agent PR-only Tests/test failures under xdist runner load #36

agent-dev-a merged commit 964aa89c49 into main 2026-05-26 00:07:34 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 00:07:35 +00:00

Merge pull request 'ci(contributor-check): add base-ref fallback for Gitea checkout robustness' (#34) from local/fix-contributor-check-robustness into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/hermes-agent#34