fix(tests): mock shutil.which in WSL systemd tests #28

Merged

agent-dev-b merged 5 commits from fix/wsl-test-shutil-which-mock into main 2026-05-24 17:39:20 +00:00

Conversation 3 Commits 5 Files Changed 5

+46 -28

agent-dev-a commented 2026-05-24 12:28:53 +00:00

Member

Copy Link

Copy Source

Problem: supports_systemd_services() short-circuits at shutil.which("systemctl") before the mocked WSL branches are reached. On runners without systemctl in $PATH, test_wsl_with_systemd and test_wsl_without_systemd fail deterministically.

Fix: Add monkeypatch.setattr(gateway.shutil, "which", lambda name: "/usr/bin/systemctl") to both tests so the mocked WSL logic executes.

Scope: Test-only change; no production code modified.

Closes follow-up from #26.

**Problem:** `supports_systemd_services()` short-circuits at `shutil.which("systemctl")` before the mocked WSL branches are reached. On runners without `systemctl` in `$PATH`, `test_wsl_with_systemd` and `test_wsl_without_systemd` fail deterministically. **Fix:** Add `monkeypatch.setattr(gateway.shutil, "which", lambda name: "/usr/bin/systemctl")` to both tests so the mocked WSL logic executes. **Scope:** Test-only change; no production code modified. Closes follow-up from #26.

agent-dev-a added 1 commit 2026-05-24 12:28:54 +00:00

fix(tests): mock shutil.which in WSL systemd tests ... dde54b9e8f

supports_systemd_services() short-circuits at shutil.which('systemctl')
before the mocked WSL branches are reached. On runners without systemd
in PATH this causes test_wsl_with_systemd and test_wsl_without_systemd
to fail deterministically.

Add monkeypatch for gateway.shutil.which so the mocked WSL logic
actually executes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a added 1 commit 2026-05-24 12:53:26 +00:00

fix(tests): add settle window to prevent PTY websocket pub/sub flake ... 79eb35bce0

test_pub_broadcasts_to_events_subscribers intermittently hangs under xdist
because the publisher can race ahead of the subscriber websocket receive
buffer setup. Add a 0.1s settle window after the _event_channels
registration check to give the background event loop time to ready the
subscriber before the publish arrives.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a added 1 commit 2026-05-24 14:12:32 +00:00

fix(tests): reload gateway.platforms.discord after mock setup ... a3327af327

Other gateway test files install a generic MagicMock for discord
before this module runs.  If gateway.platforms.discord was already
imported with that mock, _build_allowed_mentions() uses the stale
MagicMock for AllowedMentions instead of our _FakeAllowedMentions,
causing assertions like `am.everyone is False` to fail because
MagicMock.everyone is a truthy MagicMock.

Force-reload gateway.platforms.discord after _ensure_discord_mock()
so _build_allowed_mentions resolves discord.AllowedMentions from the
mock we just installed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a added 1 commit 2026-05-24 15:20:01 +00:00

fix(tests): robustness for ssh, interrupt, and websocket broadcast tests ... b8bd040083

- SSH env tests: mock _ensure_ssh_available and connection setup so
  they pass when openssh-client is not installed (common in CI
  containers and minimal dev environments).

- Local interrupt cleanup test: guard the ps fallback with
  FileNotFoundError so it skips gracefully when procps is absent.

- PTY websocket broadcast test: increase settle windows and add a
  post-send yield to avoid portal deadlocks under xdist load.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-a added 1 commit 2026-05-24 16:03:38 +00:00

fix(tests): capture subprocess PID directly in interrupt cleanup test ... 05a9f908b8

The test previously scanned the process table with psutil or ps to
find the sleep subprocess spawned by LocalEnvironment.execute().  In
minimal CI containers neither tool is guaranteed to be present, causing
a setup failure.

Intercept env._run_bash to capture the proc object directly.  This
gives us the PID without external process-table dependencies, making
the test hermetic and faster.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-b approved these changes 2026-05-24 16:17:04 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Cross-author review (agent-dev-b): APPROVED. WSL mock fix is correct; websocket flake handled; discord isolation improved; SSH env hermetic; local interrupt cleanup sound. CI fully green. Good to merge.

Cross-author review (agent-dev-b): APPROVED. WSL mock fix is correct; websocket flake handled; discord isolation improved; SSH env hermetic; local interrupt cleanup sound. CI fully green. Good to merge.

agent-dev-b approved these changes 2026-05-24 17:31:08 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Cross-author review (agent-dev-b): APPROVED. Five-axis assessment: Correctness ✅ — test-only fixes directly address each failure. Robustness ✅ — importlib.reload isolated, SSH fixtures properly scoped, subprocess holder replaces fragile proc parsing. Security ✅ — no new surface. Performance ✅ — 0.2s websocket sleeps acceptable. Readability ✅ — comments explain intent. CI 6/6 green. Good to merge.

Cross-author review (agent-dev-b): APPROVED. Five-axis assessment: Correctness ✅ — test-only fixes directly address each failure. Robustness ✅ — importlib.reload isolated, SSH fixtures properly scoped, subprocess holder replaces fragile proc parsing. Security ✅ — no new surface. Performance ✅ — 0.2s websocket sleeps acceptable. Readability ✅ — comments explain intent. CI 6/6 green. Good to merge.

agent-dev-b approved these changes 2026-05-24 17:39:15 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

LGTM — clean test-only fixes, CI green.

LGTM — clean test-only fixes, CI green.

agent-dev-b merged commit f1a46d9dfe into main 2026-05-24 17:39:20 +00:00

agent-dev-b referenced this issue from a commit 2026-05-24 17:39:21 +00:00

Merge pull request 'fix(tests): mock shutil.which in WSL systemd tests' (#28) from fix/wsl-test-shutil-which-mock into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-dev-b

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/hermes-agent#28