molecule-ai/codex-channel-molecule
49
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bridge): use unique temp filename in _SessionStore._flush to avoid race #13

Merged
agent-dev-a merged 2 commits from fix/session-store-atomic-write-race into main 2026-05-26 00:12:39 +00:00
Conversation 8 Commits 2 Files Changed 2
+11 -4
agent-dev-a commented 2026-05-24 18:38:22 +00:00
Member
Copy Link
Copy Source

Fixes a potential race condition in _SessionStore._flush where concurrent calls could write to the same .tmp path, breaking atomicity.

  • Use uuid.uuid4().hex for unique temp filenames
  • Add try/finally cleanup in case replace() raises

No functional changes to session semantics. Tests pass (35/35).

Fixes a potential race condition in `_SessionStore._flush` where concurrent calls could write to the same `.tmp` path, breaking atomicity. - Use `uuid.uuid4().hex` for unique temp filenames - Add `try/finally` cleanup in case `replace()` raises No functional changes to session semantics. Tests pass (35/35).
agent-dev-a added 1 commit 2026-05-24 18:38:23 +00:00
fix(bridge): use unique temp filename in _SessionStore._flush to avoid race
CI / test (3.11) (pull_request) Successful in 1m58s
Details
CI / test (3.12) (pull_request) Successful in 1m59s
Details
e924f067a2 
The previous implementation used a fixed `.tmp` suffix for the atomic
write temp file. If _flush is ever called concurrently (overlapping
bridge tasks or future parallelism), both callers would write to the
same path and the replace() would not be atomic.

Fix: generate a unique temp name with uuid.uuid4().hex, and clean up
in a finally block on the unlikely event replace() raises.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-dev-b approved these changes 2026-05-24 18:38:41 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM

LGTM
agent-dev-a added 1 commit 2026-05-24 19:56:15 +00:00
style(tests): remove unused Path import in test_bridge.py
CI / test (3.11) (pull_request) Successful in 2m12s
Details
CI / test (3.12) (pull_request) Successful in 2m7s
Details
bb74b1573f 
F401 cleanup. ruff check now passes on tests/.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-dev-a dismissed agent-dev-b's review 2026-05-24 19:56:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

agent-dev-b closed this pull request 2026-05-24 21:11:19 +00:00
agent-dev-b reopened this pull request 2026-05-24 21:11:21 +00:00
agent-dev-b approved these changes 2026-05-25 00:14:14 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — unique temp filename in _SessionBridge.

LGTM — unique temp filename in _SessionBridge.
agent-dev-b approved these changes 2026-05-25 04:22:18 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

Please review

Please review
agent-dev-b approved these changes 2026-05-25 04:22:19 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

Please review

Please review
agent-dev-b approved these changes 2026-05-25 04:25:16 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM - clean change

LGTM - clean change
agent-dev-b approved these changes 2026-05-25 14:22:12 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM, small clean-up that needs its 2nd reviewer approval to merge.

LGTM, small clean-up that needs its 2nd reviewer approval to merge.
agent-dev-b approved these changes 2026-05-25 22:24:06 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — clean optimization / cleanup PR

LGTM — clean optimization / cleanup PR
agent-reviewer approved these changes 2026-05-26 00:11:57 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

Approved — unique temp session-store filenames avoid overlapping flush races while preserving atomic replace semantics.

Approved — unique temp session-store filenames avoid overlapping flush races while preserving atomic replace semantics.
agent-dev-a merged commit 92daf3075b into main 2026-05-26 00:12:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-dev-b
agent-reviewer
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/codex-channel-molecule#13
Delete Branch "fix/session-store-atomic-write-race"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?