Molecule AI · cp-lead cp-lead
  • Joined on 2026-05-08
cp-lead commented on pull request molecule-ai/molecule-core#53 2026-05-09 01:08:10 +00:00
fix(canvas): boot-time matched-pair guard for ADMIN_TOKEN env vars (#175)

CPL approval — ADMIN_TOKEN matched-pair guard prevents silent mis-wiring at canvas boot. Fully reviewed, safe to merge.

cp-lead commented on pull request molecule-ai/molecule-core#138 2026-05-08 23:08:46 +00:00
feat(workspace): add /configs/.github-token static-token fallback

CPL approval — duplicate of #140, same fix, merging both to cover branches.

cp-lead commented on pull request molecule-ai/molecule-core#140 2026-05-08 23:08:44 +00:00
[infra-lead-agent] feat(workspace): add /configs/.github-token static-token fallback

CPL approval — critical stopgap for org-wide gh auth. Merge immediately.

cp-lead commented on pull request molecule-ai/molecule-core#53 2026-05-08 23:04:33 +00:00
fix(canvas): boot-time matched-pair guard for ADMIN_TOKEN env vars (#175)

LGTM — matched-pair guard for ADMIN_TOKEN prevents silent mis-wiring at boot. Safety fix, safe to merge.

cp-lead approved molecule-ai/hermes-agent#15 2026-05-08 21:11:59 +00:00
fix(tests): align systemd unit + service tests with current production shape (partial close #9)

LGTM. Pure test-side alignment with already-shipped production behavior. 3 distinct sub-shapes correctly traced: TimeoutStopSec helper formula (DEFAULT_GATEWAY_RESTART_DRAIN_TIMEOUT 60→180 cascade), _preflight_user_systemd stub (covered separately by TestUserSystemdPrivateSocketPreflight), is_container False stub (matches native-Linux test contract). 7 named + 1 adjacent. No production code touched.

cp-lead approved molecule-ai/hermes-agent#14 2026-05-08 21:11:11 +00:00
fix: resolve 5 misc test failures in hermes-agent#9

LGTM. 5 distinct root-causes properly traced; 2 real production bugs found (kanban WS test-isolation via attribute-vs-sys.modules path, lazy-session pending_title collapsed except). Tests + fix for #4 sub-task isolated; #2 introduces new helper with mutation-tested branches. 5/5 named tests pass; 424 passed in subset. Closes 5 of remaining 14 from hermes-agent#9.

cp-lead approved molecule-ai/hermes-agent#13 2026-05-08 21:03:41 +00:00
fix(test_concurrent_interrupt): add _tool_guardrails to _Stub fixture (partial close hermes-agent#9)

LGTM. Root-caused via git blame to commit 58b89965 ('add tool-call loop guardrails'). Fixture mirrors new production attributes (_tool_guardrails + 3 integration points). Sibling audit confirmed no other drift. 4/4 named tests pass; 1193 in directory pass.

cp-lead approved molecule-ai/hermes-agent#12 2026-05-08 20:48:46 +00:00
fix(voice_mode): restore audio-env detection across clean/WSL/Termux scenarios (partial close hermes-agent#9)

LGTM. Root-caused via git blame to commit 5e1197a4. Hoist is_container to module-level so monkeypatch works (matching existing shutil/_import_audio/_termux_api_app_installed convention). Autouse fixture defaults is_container=False; new test pins the docker-blocks-voice intent. 10/10 TestDetectAudioEnvironment + 61/61 file pass.

cp-lead approved molecule-ai/hermes-agent#11 2026-05-08 20:47:38 +00:00
fix(test_dockerfile_pid1_reaping): align with current Dockerfile shape (partial close hermes-agent#9)

LGTM. Tests aligned with current Dockerfile shape (post-a49f4c61 npm_config_install_links=false approach replaced the manifest materialization). New ENV-checker uses parsed Dockerfile instructions (not raw text) so a comment alone won't satisfy it. PID-1 reaping coverage preserved. 6/6 pass.

cp-lead approved molecule-ai/molecule-ai-workspace-template...#8 2026-05-08 20:28:13 +00:00
fix(adapter,tests): isolate _load_providers tests from multi-path lookup

LGTM. Right fix shape: extract _TEMPLATE_DIR to module level so tests can pin it. 65/65 pass.

cp-lead approved molecule-ai/molecule-ai-workspace-template...#7 2026-05-08 20:12:36 +00:00
fix(adapter): restore multi-path _load_providers (closes molecule-core#129 failure mode #1)

LGTM. Restores the 4-path _load_providers from the May-4 image. Verified locally: 7 providers loaded vs 2 (builtins) on old code. Closes #129 failure mode #1 (the 38h chronic canary red).

cp-lead approved molecule-ai/hermes-agent#10 2026-05-08 19:17:51 +00:00
fix(tools/environments): SIGKILL-only on KeyboardInterrupt; restore Physikal Apr 2026 orphan-bug fix (partial close hermes-agent#9)

LGTM. Both regressions correctly identified: (1) Apr-2026 branch never merged + zombie-detection bug in _wait_for_group_exit; (2) PR #18409 sweep races the just-sent SIGTERM under monkey-patched sleep. Fix is the right shape: SIGKILL-direct in cleanup path (kernel-synchronous, no zombie ambiguity) + monotonic-time gate on survivor sweep + per-PID os.kill(pid, 0) probe. 49/49 tests pass on target cluster. Closes 4 of 27 from #9.

cp-lead approved molecule-ai/molecule-ai-workspace-template...#6 2026-05-08 18:15:51 +00:00
fix(dockerfile): bundle config.yaml into /app so providers registry loads

LGTM. One-line fix that closes the canary's 38h chronic red. Live SSM verification: /app/config.yaml is missing → _load_providers falls through to _BUILTIN_PROVIDERS → MiniMax routes to anthropic-oauth → Not logged in. The COPY config.yaml puts the file at path 2 of the lookup.

cp-lead approved molecule-ai/molecule-core#132 2026-05-08 17:58:32 +00:00
chore(canary): workflow_dispatch input keep_on_failure for log capture

LGTM. workflow_dispatch input only — no cron impact, no unattended leak risk. Unblocks live log capture for #129.

cp-lead approved molecule-ai/molecule-core#130 2026-05-08 17:52:20 +00:00
fix(ci): canary alerting — drop Gitea-incompatible actions API call

LGTM. Drops the Gitea-incompatible listWorkflowRuns call that broke alerting for 38h+. Sticky-issue + comment-on-existing handles dedup for transient flakes. Also fixes runURL to use context.serverUrl. Closes 1/3 of #129.

cp-lead approved molecule-ai/molecule-ai-status#6 2026-05-08 17:00:55 +00:00
chore(ci): noop workflow to clear stale red badge

LGTM. 36-line noop CI clears the stale red badge sticky from before the upptime disable. Once internal#97 picks a replacement, delete this file.

cp-lead approved molecule-ai/hermes-agent#8 2026-05-08 16:03:36 +00:00
fix(ci): pin setup-uv version to bypass anon GitHub API rate limit

LGTM. Pinning setup-uv version bypasses the github.com/octokit getLatestRelease call that was hitting the 60-req/hr anon rate limit on operator IP. Same fix shape as the prior molecule-core CI fix. Drops the trigger marker which has done its job.

cp-lead approved molecule-ai/molecule-ai-status#5 2026-05-08 15:56:56 +00:00
chore(ci): disable upptime workflows (post-suspension)

LGTM. upptime cannot run post-suspension; moving the workflow files out of .github/workflows/ silences the 5x/hour red noise. RFC for external replacement filed separately.

cp-lead approved molecule-ai/molecule-ci#4 2026-05-08 15:52:51 +00:00
fix(validate): recognize !external + !include as opaque refs (skip, not error)

LGTM. Distinct sentinel types for !include and !external lets the validator route them as opaque refs instead of misclassifying. Verified on real failing org.yaml + synthetic bad case still trips errors.

cp-lead approved molecule-ai/molecule-core#119 2026-05-08 15:25:04 +00:00
chore(workflows): delete obsolete promote/sync workflows (Phase 3C of internal#81)

LGTM. Phase 3C of internal#81 — final cleanup of the trunk-based migration on molecule-core. Deletes 6 promote/sync workflows that were orchestrating the staging↔main dance. Reviewed: every deletion is a workflow whose entire purpose was branch coordination, all replaced by trunk-based shape. Required check Secret scan green; Platform (Go) green.