Commit Graph

4924 Commits

Author SHA1 Message Date
4725606560 Merge pull request 'feat(plugins): plugin drift detector + queue + admin apply endpoint (#123)' (#204) from feat/plugin-drift-queue-123 into main 2026-05-10 00:43:17 +00:00
Molecule AI Core Platform Lead
e97a6b43d8 Merge remote-tracking branch 'origin/main' into trig-204 2026-05-10 00:42:57 +00:00
Molecule AI Core Platform Lead
5475940ebe trigger: re-run sop-tier-check 2026-05-10 00:42:39 +00:00
Molecule AI Core Platform Lead
cf09233202 Merge remote-tracking branch 'origin/main' into trig-204 2026-05-10 00:42:38 +00:00
ada1008012 feat(plugins): plugin drift detector + queue + admin apply endpoint (#123)
## Summary

Adds the version-subscription drift detection and operator-apply workflow for
per-workspace plugin tracking (core#113).

## Components

**Migration** (`20260510000000_plugin_drift_queue`):
- Adds `installed_sha` column to `workspace_plugins` — records the commit SHA
  installed so the drift sweeper can compare against upstream.
- Creates `plugin_update_queue` table with status: pending | applied | dismissed.
- Adds partial unique index to prevent duplicate pending rows per
  (workspace_id, plugin_name).

**GithubResolver** (`github.go`):
- `LastFetchSHA` field + `LastSHA()` getter — populated by `Fetch` after a
  successful shallow clone (captured before `.git` is stripped). Used by the
  install pipeline to seed `installed_sha`.
- `ResolveRef(ctx, spec)` method — resolves a plugin spec to its full commit
  SHA using `git fetch --depth=1 + git rev-parse`. Used by the drift sweeper
  to get the current upstream SHA for a tracked ref (tag:vX.Y.Z, tag:latest,
  sha:…, or bare branch).

**Drift sweeper** (`plugins/drift_sweeper.go`):
- Periodic sweep every 1h: SELECTs rows where `tracked_ref != 'none' AND
  installed_sha IS NOT NULL`, resolves upstream SHA, queues drift if different.
- `ListPendingUpdates()` — reads pending queue rows for the admin endpoint.
- `ApplyDriftUpdate()` — marks entry applied (idempotent).
- ctx.Err() guard on ticker arm to avoid post-shutdown work.

**Install pipeline** (`plugins_install_pipeline.go`, `plugins_tracking.go`,
`plugins_install.go`):
- `stageResult.InstalledSHA` field — carries the SHA from Fetch to the DB.
- `recordWorkspacePluginInstall` now accepts and stores `installed_sha`.
- `deleteWorkspacePluginRow` — removes tracking row on uninstall so a stale
  SHA doesn't prevent the next install from creating a fresh row.
- Both Docker and EIC uninstall paths call `deleteWorkspacePluginRow`.

**Admin endpoints** (`handlers/admin_plugin_drift.go`):
- `GET /admin/plugin-updates-pending` — list all pending drift entries.
- `POST /admin/plugin-updates/:id/apply` — re-installs plugin from source_raw
  (re-fetching the same tracked ref), records the new SHA, marks entry applied,
  triggers workspace restart. Idempotent (already-applied returns 200).

**Router wiring** (`router.go`, `cmd/server/main.go`):
- Plugin registry created in main.go and shared between PluginsHandler and drift
  sweeper.
- `router.Setup` accepts optional `pluginResolver` param.
- `PluginsHandler.Sources()` export for the sweeper wiring pattern.

## Tests

- `plugins/github_test.go` — `ResolveRef` coverage (invalid spec, git error,
  not-found mapping, no-panic for all ref shapes).
- `plugins/drift_sweeper_test.go` — `ResolveRef` happy path, stub resolver
  interface compliance.
- `handlers/admin_plugin_drift_test.go` — ListPending (empty, non-empty, DB
  error), Apply (not found, already applied, already dismissed, workspace_plugins
  missing).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:39:50 +00:00
96a9868bf5 Merge pull request 'test(canvas): add StatusDot component tests' (#203) from test/canvas-status-dot into main 2026-05-10 00:33:12 +00:00
Molecule AI Core Platform Lead
6f564c92d3 Merge remote-tracking branch 'origin/main' into trig-203 2026-05-10 00:32:45 +00:00
Molecule AI Core Platform Lead
3c1c08fa2a trigger: re-run sop-tier-check 2026-05-10 00:32:26 +00:00
45113fab6b Merge pull request 'docs(canvas): clean up Known Issues section — remove duplicate + fix pre-commit action' (#202) from docs/fix-audit-known-issues into main 2026-05-10 00:27:50 +00:00
Molecule AI Core Platform Lead
bd5faf1ff5 trigger: re-run sop-tier-check 2026-05-10 00:26:38 +00:00
858f996196 test(canvas): add StatusDot component tests
Add 10 tests for StatusDot covering:
- All known STATUS_CONFIG statuses (online, offline, degraded,
  failed, paused, not_configured, provisioning)
- Correct color class applied per status
- Glow class applied when declared in STATUS_CONFIG
- motion-safe:animate-pulse on provisioning status
- Fallback to bg-zinc-500 for unknown status
- size prop (sm/md) applies correct Tailwind dimension class
- aria-hidden="true" for accessibility tree isolation

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:25:46 +00:00
65af68d13b docs(canvas): clean up Known Issues section — remove duplicate entry + fix pre-commit action line
- Pre-commit Hook: moved stray "Action:" line inside the section (was appended to
  WCAG entry below it after a rebase conflict resolution)
- Removed duplicate text-ink-soft WCAG AA entry (lines 62-68 were a rebase artifact)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:23:18 +00:00
fedfb49c0a Merge pull request 'docs(canvas): correct Canvas Controls section — Controls keyboard-accessible, MiniMap present' (#201) from docs/fix-minimap-audit into main 2026-05-10 00:13:32 +00:00
Molecule AI Core Platform Lead
ef40701a78 trigger: re-run sop-tier-check 2026-05-10 00:13:18 +00:00
26946367a0 docs(canvas): correct Canvas Controls section — Controls keyboard-accessible, MiniMap present
- Controls: all three buttons (zoom in/out/fit) have aria-label attributes from
  React Flow; verified from @xyflow/react source (index.mjs:4453). Removed "verify
  if keyboard accessible" caveat.
- MiniMap: actually present in Canvas.tsx (rendered at line 310). The old audit
  note "not present (mocked as null in tests)" referred to the minimap being absent
  from unit test renders, not from production. Updated to reflect actual presence
  and status-coloring behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:12:08 +00:00
36dcf076d2 Merge pull request 'fix(canvas): correct KeyboardShortcutsDialog + fix min-clamp test expectations' (#200) from fix/keyboard-shortcuts-dialog-update into main 2026-05-10 00:08:52 +00:00
Molecule AI Core Platform Lead
ad9e11d8c4 Merge remote-tracking branch 'origin/main' into trig-200 2026-05-10 00:08:44 +00:00
Molecule AI Core Platform Lead
e8eeb5ff8e trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-10 00:08:28 +00:00
78890703f5 Merge pull request 'ci(docker): pin base image digests in all Dockerfiles' (#199) from ci/pin-dockerfile-base-digests into main 2026-05-10 00:03:28 +00:00
Molecule AI Core Platform Lead
6ab1184c15 Merge remote-tracking branch 'origin/main' into trig-199 2026-05-10 00:03:03 +00:00
Molecule AI Core Platform Lead
6029ccb964 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-10 00:02:43 +00:00
Molecule AI Core Platform Lead
306262a315 Merge remote-tracking branch 'origin/main' into trig-199 2026-05-10 00:02:43 +00:00
4baf60f01d fix(canvas): correct KeyboardShortcutsDialog descriptions + fix min-clamp test expectations
- Fix arrow-key nudge description: was "20px/100px" (wrong), now "10px/50px" (matches useKeyboardShortcuts)
- Add Cmd/Ctrl+Arrow resize shortcut row to dialog (missing since PR #192)
- Fix 3 tests in useKeyboardShortcuts.test.tsx that asserted shrink below min dimensions:
  "resizes height down" expected height:100, clamped to 110 (node starts at minHeight)
  "resizes width down" expected width:200, clamped to 210 (node starts at minWidth)
  "2px step with Shift" expected height:108, clamped to 110 (minHeight wins)
  All three tests updated to assert clamped values with explanatory comments.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:01:40 +00:00
1492b40b38 ci(docker): pin base image digests in all Dockerfiles
Pins all FROM image tags to exact SHA256 digests for reproducible
builds. Without digest pinning, a registry push of a new image to the
same tag can silently change the layer content between builds — a
supply-chain risk especially for prod-deployed images.

Pinned images (7 Dockerfiles):
- golang:1.25-alpine → sha256:c4ea15b... (workspace-server/Dockerfile,
  Dockerfile.dev, Dockerfile.tenant, tests/harness/cp-stub/Dockerfile)
- alpine:3.20 → sha256:c64c687c... (workspace-server/Dockerfile,
  tests/harness/cp-stub/Dockerfile)
- node:20-alpine → sha256:afdf982... (workspace-server/Dockerfile.tenant)
- node:22-alpine → sha256:cb15fca... (canvas/Dockerfile)
- python:3.11-slim → sha256:e78299e... (workspace/Dockerfile)
- nginx:1.27-alpine → sha256:62223d6... (tests/harness/cf-proxy/Dockerfile)

Note: docker-compose.yml service images (postgres, redis, clickhouse,
litellm, ollama) are intentionally left on major-version tags — those
are runtime-pulled and updated regularly for local-dev ergonomics.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:56:39 +00:00
c0ee500e47 Merge pull request 'fix(canvas): WCAG AA contrast fix + KeyboardShortcutsDialog improvements' (#198) from fix/ink-soft-wcag-contrast into main 2026-05-09 23:48:38 +00:00
Molecule AI Core Platform Lead
7b60008d33 Merge remote-tracking branch 'origin/main' into trig-198 2026-05-09 23:48:27 +00:00
Molecule AI Core Platform Lead
be2de6351f trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:48:09 +00:00
Molecule AI Core Platform Lead
96ae24a83c Merge remote-tracking branch 'origin/main' into trig-198 2026-05-09 23:48:09 +00:00
0ba16cded6 Merge pull request 'docs(canvas): update audit status — all accessibility gaps now closed' (#197) from docs/update-canvas-audit-status into main 2026-05-09 23:45:13 +00:00
Molecule AI Core Platform Lead
aff8831817 Merge remote-tracking branch 'origin/main' into trig-197 2026-05-09 23:44:38 +00:00
Molecule AI Core Platform Lead
fb3ab76456 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:44:22 +00:00
Molecule AI Core Platform Lead
e541889150 Merge remote-tracking branch 'origin/main' into trig-197 2026-05-09 23:44:21 +00:00
bc1d602883 Merge pull request 'test(canvas): add tests for Cmd/Ctrl+Arrow keyboard node resize' (#196) from test/canvas-keyboard-resize-tests into main 2026-05-09 23:44:16 +00:00
Molecule AI Core Platform Lead
6b73c7abc7 Merge remote-tracking branch 'origin/main' into trig-196 2026-05-09 23:44:07 +00:00
Molecule AI Core Platform Lead
0722bf3df8 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:43:51 +00:00
2da036204c test(canvas): add tests for Cmd/Ctrl+Arrow keyboard node resize
Add 10 tests covering the Cmd/Ctrl+Arrow resize shortcut:
- ArrowUp/Down resizes height (−/+10px)
- ArrowLeft/Right resizes width (−/+10px)
- Shift modifier uses 2px step for fine control
- min-height constraint respected when shrinking
- Guard: no-op when no node selected
- Guard: skipped when modal dialog is open
- Plain arrow keys (no modifier) fire moveNode instead
- Alt+Arrow is skipped (not a resize combo)

Also extends the mock store state with `onNodesChange` and node
`width`/`height` fields needed for the resize tests.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:41:29 +00:00
e53cbeae2f docs(canvas): mark keyboard node drag as done in audit
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:36:36 +00:00
cc2dbb1f3d Merge pull request 'fix(test): poll error counter to 0 before asserting in RecordsMetricsOnSuccess' (#194) from infra/fix-issue-22-sweeper-test-flaky into main 2026-05-09 23:29:45 +00:00
Molecule AI Core Platform Lead
0de7771a72 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:29:29 +00:00
e29b166f60 fix(test): poll error counter to 0 before asserting in RecordsMetricsOnSuccess
Race-detector CI runs (-race) slow goroutines enough that a
prior sweeper goroutine (e.g. TestStartSweeper_TransientErrorDoesNotCrashLoop)
can still be running and incrementing pendingUploadsSweepErrors after
metricDelta() captures its baseline, but before the success-path sweeper
records its success metrics. The test then reads deltaError=1 instead of 0.

Fix: add waitForMetricDelta(t, deltaError, 0, 2*time.Second) before the
assertion, matching the polling pattern already used in the error-path
test (TestStartSweeper_RecordsMetricsOnError). This ensures the error
counter has settled before we assert on it.

Fixes molecule-core#22.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:27:19 +00:00
4a73a72e44 test(canvas): add KeyboardShortcutsDialog a11y render tests
Cherry-picked from feat/keyboard-shortcuts-dialog-test (99ecdd6d).
6 tests covering role=dialog, aria-modal, aria-labelledby,
no-render-when-closed, Escape-close, focus-on-open, Tab trap.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:18:14 +00:00
b837d3b065 fix(canvas): text-ink-soft → text-ink-mid for WCAG AA contrast
Replace all text-ink-soft usages across canvas components and app pages.
ink-soft (#8d92a0) on dark zinc (#0e1014) yields ~2.2:1 contrast,
failing WCAG 2.1 AA minimum of 4.5:1 for normal text.

ink-mid (#c8c2b4) on dark zinc yields ~7.6:1 — well above AA.

text-ink-mid is already the semantic token for secondary/caption text
in the warm-paper light mode; the dark-mode override was the gap.

52 files, 268 replacements. No functional change beyond contrast.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:18:14 +00:00
e80d2ccb72 docs(canvas): fix Next.js version — 14 → 15.5.15
Canvas runs Next.js 15.5.15 (package-lock.json). Audit doc had
Next.js 14 App Router from before the upgrade. Also add
KeyboardShortcutsDialog.tsx to the directory structure tree.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:18:14 +00:00
f5682fbb5f docs(canvas): mark keyboard node drag as done in audit
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-09 23:18:14 +00:00
7bc249ff7a Merge pull request 'feat(canvas): keyboard-accessible node resize via Cmd/Ctrl+Arrow' (#192) from feat/canvas-keyboard-node-resize into main 2026-05-09 23:13:52 +00:00
Molecule AI Core Platform Lead
bf0e47814e Merge remote-tracking branch 'origin/main' into trig-192 2026-05-09 23:13:38 +00:00
2c3b36f5cd Merge pull request 'fix(ci): replace gh api calls with Gitea-compatible alternatives (closes #75)' (#191) from fix/gh-api-gitea-sweep-75 into main 2026-05-09 23:13:20 +00:00
Molecule AI Core Platform Lead
f263f89ca9 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:13:09 +00:00
Molecule AI Core Platform Lead
9c44bdf4fe Merge remote-tracking branch 'origin/main' into trig-192 2026-05-09 23:12:59 +00:00
Molecule AI Core Platform Lead
02a8303bb5 trigger: re-run sop-tier-check after core-lead approval + main sync 2026-05-09 23:12:47 +00:00