Peer-ack of SOP checklist (engineers): /sop-ack comprehensive-testing verified test coverage across all guard classes /sop-ack local-postgres-e2e handlers package green incl provision paths /sop-ac…
2nd non-author review (core-fe) of the registration mechanism. The shape is correct: google-adk added to manifest.json, the Go provisioner knownRuntimes (registry.go + registry_test.go), and the canvas runtime list (runtime-names.ts + CreateWorkspaceDialog.tsx) — consistent with the validator allowlist already merged in molecule-ci #26 and the template adapter in template#1. Registration is the right surface.
HOLD — not merging (ordering gate + red CI)
This registration PR (manifest.json + provisioner knownRuntimes + canvas runtime list) is held for two independent reasons:
**1. Cross-repo…
Approved. Focused Canvas/noVNC input fix: display-targeted keys bypass Canvas/global shortcuts, paste is forwarded via RFB.clipboardPasteFrom, remote clipboard is surfaced with browser-permission fallback controls. Verified focused tests (46 passed), npm run build, and Gitea action runs 88387-88402 resolved Success via mol_action_status.
52304d99a2
fix(canvas): polite tasks/cancel before /workspaces/:id/restart for Stop All (task #377 companion)
cb65886289
fix(canvas): external/MCP workspace progress UX — surface poll-mode queued state (task #227)
ff35cf28c7
fix(canvas/chat): point A2A error hints at Activity tab, not phantom "workspace/container logs" (closeout internal#212)
scope-probe (do not approve)
5-axis review on today's-PR-coverage E2E: correctness OK (real HTTP/DB/activity path, no mocks for unit under fix); readability OK (sections per-PR with rationale); arch OK (uses existing _lib.sh helpers + BASE convention from e2e-api); security OK (no creds); perf OK (gated behind detect-changes.outputs.api == true). Each section asserts the FIX-SPECIFIC behavior. APPROVED.
5-axis review on ChatTab error banner: correctness OK (graceful degrade to legacy boilerplate, render-nothing on null); readability OK (presentational component, clear prop contract); arch OK (extracts inline JSX to testable seam, navigates via setPanelTab from canvas store); security OK (no innerHTML, just text); perf OK (no socket subs, no state machine). Tests cover all four banner states including 'View activity log' click. APPROVED.