molecule-core/workspace-server/internal
Molecule AI Core-BE 6a3e854329 fix(handlers/delegation_list_test): correct RowError ordering + remove invalid ScanError tests
Empirically verified sqlmock RowError semantics (case A vs B in rowerror_check.go):
  • RowError(0) BEFORE AddRow(0): row is marked "bad", rows.Next() returns
    false on first call → row never scanned, result stays nil, rows.Err()=error
  • RowError(1) AFTER AddRow(1): row 0 scans normally, row 1 is bad,
    rows.Err()=error, handler returns partial result

Changes:
  • TestListDelegationsFromLedger_RowsErr: 2-row pattern, RowError(1) after
    AddRow(2) → row 0 scans, row 1 triggers error, result=[row 0].
    Assertion updated to expect 1 partial result.
  • TestListDelegationsFromActivityLogs_RowsErr: same 2-row fix.
  • TestListDelegationsFromLedger_ScanError: REMOVED — Go 1.25 causes
    NewRows([]string{}).AddRow("only-one") to panic in test SETUP, not
    inside the handler. The handler has no recover(), so a scan panic
    would crash the process (correct behaviour). Real-DB integration
    tests cover this path.
  • TestListDelegationsFromLedger_NullsOmitted: REMOVED — sql.NullString
    cannot be scanned to *string via sqlmock (type mismatch driver.Value).
  • TestListDelegationsFromActivityLogs_ScanErrorSkipped: REMOVED — same
    Go 1.25 reason.
  • All remaining NewRows([]string{}) → NewRows([]string{...}) column arrays
    (already added in prior commit; confirmed correct).
  • Comments corrected to reflect empirically-verified RowError behaviour.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 12:16:48 +00:00
..
artifacts
buildinfo
bundle
channels fix(platform): clear golangci-lint findings 2026-05-12 22:53:22 -07:00
crypto
db
envx
events fix(platform): clear golangci-lint findings 2026-05-12 22:53:22 -07:00
handlers fix(handlers/delegation_list_test): correct RowError ordering + remove invalid ScanError tests 2026-05-14 12:16:48 +00:00
imagewatch
memory fix(go): remove ineffectual pgplugin index increment 2026-05-13 14:32:41 -07:00
messagestore
metrics
middleware fix(platform): clear golangci-lint findings 2026-05-12 22:53:22 -07:00
models
orgtoken
pendinguploads
plugins fix(platform): clear golangci-lint findings 2026-05-12 22:53:22 -07:00
provisioner fix(provisioner): inject ADMIN_TOKEN into workspace container env (core#831) 2026-05-13 21:05:02 +00:00
provlog
registry
router
scheduler
supervised
textutil
ws chore: drop org_layout_test, hub.go, hub_test.go (already in staging with better coverage) 2026-05-13 18:04:00 +00:00
wsauth