Molecule AI Fullstack Engineer e908772bcc fix(handlers): fix 3 test regressions + bring PR#956 security tests to staging ... This PR closes #965 and brings PR#956's org_helpers_security_test.go onto the staging branch, with all conflicts resolved. Fix 1 — TestResolveInsideRoot_DotDotWithIntermediate panic (GH#965): a/b/../../c from /safe/root normalizes to /safe/root/c (valid descendant), so resolveInsideRoot returns nil. The test expected an error and called err.Error() on nil → panic. Fixed by rewriting the test to expect success and verify the resolved path stays within root. Fix 2 — Nil-panic propagation across resolveInsideRoot tests: All resolveInsideRoot tests that checked "err == nil" then called err.Error() on the falling-through path. Changed to t.Fatalf to stop immediately so the nil dereference never fires. Fix 3 — expandWithEnv literal-dollar regression: Re-applied the fix from fix/duplicate-test-declarations: expandWithEnv now skips $VAR keys not starting with [a-zA-Z_], so "cost $100" stays as-is even in environments where $1 could be resolved. Fix 4 — SSH probe tests degrade gracefully: TestHandleDiagnose_RoutesToRemote and TestDiagnoseRemote_StopsAtSSHProbe now t.Skip when ssh-keygen/nc are absent from PATH. Fix 5 — org_helpers_security_test.go duplicate declarations resolved: Removed isSafeRoleName tests (already in org_helpers_pure_test.go). Renamed TestMergeCategoryRouting_* → TestSecureRouting_* to avoid redeclaration with org_helpers_pure_test.go. Added the file from PR#956 (merged to main at 6582c096). Fix 6 — Removed stale duplicate test declarations in org_test.go and plugins_atomic_test.go (walkOrgWorkspaceNames variants, hasUnresolvedVarRef variants, resolveProvisionConcurrency_Default, TestTarWalk_NestedDirs). Closes #965 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>		2026-05-14 05:26:13 +00:00
..
cmd	fix(main): heal ADMIN_TOKEN placeholder in global_secrets on startup (#831)	2026-05-13 22:42:32 +00:00
internal	fix(handlers): fix 3 test regressions + bring PR#956 security tests to staging	2026-05-14 05:26:13 +00:00
migrations
pkg/provisionhook
.air.toml
.ci-force
.gitignore
.golangci.yaml
Dockerfile	fix(platform): install docker-cli-buildx in workspace-server image (mc#765 follow-up)	2026-05-12 22:14:46 -07:00
Dockerfile.dev
Dockerfile.tenant
entrypoint-tenant.sh
go.mod	fix(handlers): remove duplicate test declarations; skip SSH tests gracefully	2026-05-14 04:56:19 +00:00
go.sum