Files
molecule-core/tests/e2e/test_model_slug.sh
core-devops 64fdfa6e77
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
CI / Python Lint & Test (pull_request) Successful in 4s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 2s
CI / Detect changes (pull_request) Successful in 9s
E2E Chat / detect-changes (pull_request) Successful in 8s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 8s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
sop-checklist / review-refire (pull_request_target) Has been skipped
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 2s
qa-review / approved (pull_request_target) Failing after 6s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
CI / Canvas (Next.js) (pull_request) Successful in 2s
sop-checklist / na-declarations (pull_request) N/A: (none)
E2E Chat / E2E Chat (pull_request) Successful in 2s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
security-review / approved (pull_request_target) Failing after 13s
sop-checklist / all-items-acked (pull_request_target) Successful in 13s
sop-tier-check / tier-check (pull_request_target) Failing after 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
CI / Canvas Deploy Status (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 2s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 53s
qa-review / approved (pull_request_review) Has been skipped
security-review / approved (pull_request_review) Has been skipped
sop-tier-check / tier-check (pull_request_review) Failing after 4s
audit-force-merge / audit (pull_request_target) Successful in 5s
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Waiting to run
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Waiting to run
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Waiting to run
E2E Staging Reconciler (heals terminated EC2) / pr-validate (pull_request) Waiting to run
E2E Staging Reconciler (heals terminated EC2) / E2E Staging Reconciler (pull_request) Waiting to run
fix(e2e): claude-code MiniMax slug must be bare MiniMax-M2.7 not colon (internal#718 UNREGISTERED)
The staging full-SaaS e2e provisioned a claude-code parent workspace with
the colon-namespaced model id `minimax:MiniMax-M2.7` (from
tests/e2e/lib/model_slug.sh), which is INTENTIONALLY unregistered for the
claude-code runtime: the claude-code adapter cannot strip the `minimax:`
prefix, so create-validation (provider-registry SSOT, internal#718) rejects
it 422 UNREGISTERED_MODEL_FOR_RUNTIME.

Evidence: real staging run job 295075 (main 797351bb) failed at
"5/11 Provisioning parent workspace" with:
  {"code":"UNREGISTERED_MODEL_FOR_RUNTIME","error":"model
  \"minimax:MiniMax-M2.7\" is not a registered model for runtime
  \"claude-code\"; pick one of the runtime's registered models
  (provider-registry SSOT, internal#718)"}

This 422 is correct, intentional product behavior, pinned by
workspace-server/internal/providers/derive_provider_matrix_test.go
(the #2263/#2274 colon-vs-slash-vs-bare MiniMax triple):
  bare  "MiniMax-M2.7"        -> provider=minimax  (BYOK)
  slash "minimax/MiniMax-M2.7" -> provider=platform
  colon "minimax:MiniMax-M2.7" -> UNREGISTERED (adapter can't strip minimax:)
The bare form is registered in claude-code's `minimax` arm
(registry_gen.go:88 Models=[MiniMax-M2,MiniMax-M2.7,MiniMax-M2.7-highspeed,
MiniMax-M3]) and derives provider=minimax BYOK via MINIMAX_API_KEY.

Test-only fix (zero production code):
- tests/e2e/lib/model_slug.sh: claude-code|seo-agent MiniMax-BYOK path now
  emits the bare registered `MiniMax-M2.7`; rewrote the now-wrong comments
  that claimed the colon form gives BYOK on claude-code (it doesn't — colon
  is only the correct BYOK id on openclaw/hermes, which DO strip the prefix).
- tests/e2e/test_model_slug.sh: updated the three pins from the colon form to
  the bare form (claude-code + minimax, both-keys priority, seo-agent).
- tests/e2e/test_priority_runtimes_e2e.sh: the live MiniMax arm directly
  provisioned claude-code with the same colon id (same UNREGISTERED 422 class)
  — switched to bare `MiniMax-M2.7` and corrected the "registry-skew" framing.
- tests/e2e/test_staging_full_saas.sh: corrected a stale diagnostic string.

Audit of other arms (no other UNREGISTERED mismatch found): hermes/codex
slash `openai/gpt-4o` and google-adk bare `gemini-2.5-pro` and the
test_peer_visibility `minimax/MiniMax-M2.7` slash form are all registered
for their runtimes per the matrix test; left unchanged. openclaw/hermes
colon-minimax is correct (those adapters strip the prefix) and is not
emitted by this helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-05 10:14:14 -07:00

148 lines
7.5 KiB
Bash
Executable File

#!/usr/bin/env bash
# Regression test for tests/e2e/lib/model_slug.sh.
#
# PR #2571 fixed a synth-E2E masking bug where MODEL_SLUG was hardcoded
# to "openai/gpt-4o" (slash-form). Without this regression test, dropping
# any branch of the case (or flipping a slug format) would silently revert
# behavior — the E2E only fails as "Could not resolve authentication method"
# at the very first message, after a successful tenant + workspace provision.
#
# Each branch must FAIL the test if the dispatch behavior changes, not
# just produce some non-empty string.
set -uo pipefail
# Resolve to the lib relative to this test file so the test runs from
# any cwd (CI, local invocation, repo root).
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
# shellcheck source=tests/e2e/lib/model_slug.sh
source "$SCRIPT_DIR/lib/model_slug.sh"
PASS=0
FAIL=0
assert_eq() {
local label="$1" got="$2" want="$3"
if [ "$got" = "$want" ]; then
echo "$label"
PASS=$((PASS+1))
else
echo "$label: got=$(printf %q "$got") want=$(printf %q "$want")" >&2
FAIL=$((FAIL+1))
fi
}
run_test() {
local label="$1" runtime="$2" want="$3"
# Pin per-test isolation: explicitly unset the override so a leaked
# E2E_MODEL_SLUG from caller env can't poison the dispatch branches.
local got
got=$(unset E2E_MODEL_SLUG; pick_model_slug "$runtime")
assert_eq "$label" "$got" "$want"
}
echo "Test: pick_model_slug — per-runtime dispatch"
echo
# ── Per-runtime branches (the load-bearing ones for synth-E2E) ──
run_test "hermes → slash-form (derive-provider.sh contract)" hermes "openai/gpt-4o"
run_test "codex → slash-form fallback" codex "openai/gpt-4o"
run_test "claude-code → OAuth/default alias" claude-code "sonnet"
# BARE registered BYOK id (registry_gen.go:88), NOT colon `minimax:…`. On
# claude-code the colon form is intentionally UNREGISTERED (the adapter can't
# strip `minimax:`) and 422s create-validation (internal#718, job 295075);
# bare resolves to provider=minimax BYOK. Pinned by the matrix test's
# colon-vs-slash-vs-bare triple in derive_provider_matrix_test.go.
got=$(unset E2E_MODEL_SLUG E2E_ANTHROPIC_API_KEY; E2E_MINIMAX_API_KEY="mx-test" pick_model_slug claude-code)
assert_eq "claude-code + MiniMax key → bare registered MiniMax model" "$got" "MiniMax-M2.7"
got=$(unset E2E_MODEL_SLUG E2E_MINIMAX_API_KEY; E2E_ANTHROPIC_API_KEY="sk-ant-test" pick_model_slug claude-code)
assert_eq "claude-code + Anthropic API key → Anthropic API model" "$got" "claude-sonnet-4-6"
got=$(unset E2E_MODEL_SLUG; E2E_MINIMAX_API_KEY="mx-priority" E2E_ANTHROPIC_API_KEY="sk-ant-loser" pick_model_slug claude-code)
assert_eq "claude-code + both keys → MiniMax priority (bare)" "$got" "MiniMax-M2.7"
# ── seo-agent (claude-code-adapter template variant) ──
# seo-agent shares the claude-code dispatch branch (it reuses the claude-code
# adapter + the same copied providers block). Pin that it resolves IDENTICALLY
# to claude-code for every key path so a future refactor can't accidentally
# fork seo-agent's model selection from claude-code's.
run_test "seo-agent → claude-code default alias" seo-agent "sonnet"
got=$(unset E2E_MODEL_SLUG E2E_ANTHROPIC_API_KEY; E2E_MINIMAX_API_KEY="mx-test" pick_model_slug seo-agent)
assert_eq "seo-agent + MiniMax key → bare MiniMax model (==claude-code)" "$got" "MiniMax-M2.7"
got=$(unset E2E_MODEL_SLUG E2E_MINIMAX_API_KEY; E2E_ANTHROPIC_API_KEY="sk-ant-test" pick_model_slug seo-agent)
assert_eq "seo-agent + Anthropic key → Anthropic model (==claude-code)" "$got" "claude-sonnet-4-6"
# ── google-adk (Gemini) ──
# AI-Studio BYOK arm → bare gemini-2.5-pro (providers.yaml runtimes.google-adk
# `google` arm). The platform/Vertex arm is selected via E2E_LLM_PATH=platform
# (a platform: id), not this dispatch. Pin the bare form so a drift to the
# platform id (which would change billing/route) is caught.
run_test "google-adk → AI-Studio bare gemini id" google-adk "gemini-2.5-pro"
got=$(E2E_MODEL_SLUG="google_genai:gemini-2.5-pro" pick_model_slug google-adk)
assert_eq "google-adk + E2E_MODEL_SLUG override (adapter spelling)" "$got" "google_genai:gemini-2.5-pro"
# ── Fallback for unknown runtime ──
# Picks slash-form (hermes-shaped) since hermes is the historical
# default and most third-party runtimes behave hermes-like. Pinning
# this so a future "smarter" fallback (e.g., empty string, error) is
# a deliberate choice, not silent drift.
run_test "unknown runtime → slash-form fallback" gemini "openai/gpt-4o"
run_test "empty runtime → slash-form fallback" "" "openai/gpt-4o"
# ── Platform-managed path (E2E_LLM_PATH=platform) ──
# The moonshot/kimi NOT_CONFIGURED regression path (RFC#340 Fix A #2187).
# Selects the slash-namespaced platform model (default moonshot/kimi-k2.6),
# takes precedence over the per-key BYOK branches, and is itself overridden by
# E2E_MODEL_SLUG. These pins guard the harness's ability to drive the platform
# arm — the one the prod bug shipped on.
echo
echo "Test: pick_model_slug — platform-managed path (E2E_LLM_PATH=platform)"
echo
got=$(unset E2E_MODEL_SLUG E2E_DEFAULT_PLATFORM_MODEL; E2E_LLM_PATH=platform pick_model_slug claude-code)
assert_eq "claude-code + platform path → headline kimi model" "$got" "moonshot/kimi-k2.6"
got=$(unset E2E_MODEL_SLUG E2E_DEFAULT_PLATFORM_MODEL; E2E_LLM_PATH=platform E2E_MINIMAX_API_KEY="mx-stray" pick_model_slug claude-code)
assert_eq "platform path beats a stray BYOK key (no mask)" "$got" "moonshot/kimi-k2.6"
got=$(unset E2E_MODEL_SLUG; E2E_LLM_PATH=platform E2E_DEFAULT_PLATFORM_MODEL="minimax/MiniMax-M3" pick_model_slug claude-code)
assert_eq "platform path honours E2E_DEFAULT_PLATFORM_MODEL" "$got" "minimax/MiniMax-M3"
got=$(unset E2E_DEFAULT_PLATFORM_MODEL; E2E_MODEL_SLUG="anthropic/claude-opus-4-7" E2E_LLM_PATH=platform pick_model_slug claude-code)
assert_eq "E2E_MODEL_SLUG still wins over platform path" "$got" "anthropic/claude-opus-4-7"
# ── Override via E2E_MODEL_SLUG ──
# When the operator sets E2E_MODEL_SLUG, the per-runtime dispatch is
# bypassed. Used during workflow_dispatch to A/B specific slugs.
echo
echo "Test: pick_model_slug — E2E_MODEL_SLUG override"
echo
got=$(E2E_MODEL_SLUG="anthropic:claude-opus-4-7" pick_model_slug codex)
assert_eq "override beats codex default" "$got" "anthropic:claude-opus-4-7"
got=$(E2E_MODEL_SLUG="custom/whatever" pick_model_slug hermes)
assert_eq "override beats hermes default" "$got" "custom/whatever"
got=$(E2E_MODEL_SLUG="some-bare-id" pick_model_slug claude-code)
assert_eq "override beats claude-code default" "$got" "some-bare-id"
# Empty-string override does NOT activate (falls through to dispatch).
# This is the historical bash idiom: -n "" → false → no override. Pin
# it because changing this behavior (e.g. via -v test) would silently
# break the dispatch when an operator passes "" to clear an inherited
# env var.
got=$(E2E_MODEL_SLUG="" pick_model_slug codex)
assert_eq "empty-string override falls through to dispatch" "$got" "openai/gpt-4o"
echo
echo "─────────────────────────────────────────────────"
echo "PASSED: $PASS"
echo "FAILED: $FAIL"
echo "─────────────────────────────────────────────────"
[ "$FAIL" -eq 0 ]