core-devops
197409f10d
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
CI / Python Lint & Test (pull_request) Successful in 5s
CI / Detect changes (pull_request) Successful in 15s
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 3s
E2E Chat / detect-changes (pull_request) Successful in 20s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 20s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 15s
Harness Replays / detect-changes (pull_request) Successful in 6s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
E2E API Smoke Test / detect-changes (pull_request) Successful in 38s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s
gate-check-v3 / gate-check (pull_request_target) Successful in 9s
CI / Canvas (Next.js) (pull_request) Successful in 2s
Check migration collisions / Migration version collision check (pull_request) Successful in 49s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
sop-checklist / review-refire (pull_request_target) Has been skipped
security-review / approved (pull_request_target) Failing after 4s
sop-tier-check / tier-check (pull_request_target) Successful in 5s
E2E Chat / E2E Chat (pull_request) Successful in 2s
qa-review / approved (pull_request_target) Failing after 13s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 15s
CI / Canvas Deploy Status (pull_request) Has been skipped
Harness Replays / Harness Replays (pull_request) Successful in 9s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 59s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m17s
qa-review / approved (pull_request_review) Has been skipped
security-review / approved (pull_request_review) Has been skipped
sop-tier-check / tier-check (pull_request_review) Successful in 3s
CI / Platform (Go) (pull_request) Successful in 4m2s
CI / all-required (pull_request) Successful in 1s
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m32s
audit-force-merge / audit (pull_request_target) Successful in 11s
Addresses the two valid sub-points in CR2's review of #2258, while the core claim (existing rows left NULL) is empirically disproven. EMPIRICAL GROUND TRUTH (PostgreSQL 16.13 prod, re-confirmed on 16.14): adding `seq BIGINT GENERATED BY DEFAULT AS IDENTITY` to a populated activity_logs REWRITES the table and assigns seq to EXISTING rows during the ALTER in physical table-scan order (x=1..5 -> seq=1..5, all NON-NULL); the identity sequence then advances ABOVE max(seq) so the next INSERT gets seq=6 with no collision. The migration is correct; rows do NOT stay NULL. 1) Comment precision: the up.sql overclaimed seq as a "gap-free monotonically increasing value in INSERT (commit) order". Replaced with an accurate statement — seq is a UNIQUE, monotonic-once-assigned tiebreaker that is NOT gap-free (rollbacks burn values) and NOT a strict commit-order guarantee under concurrency; neither property is needed, because any total, stable tiebreaker makes (created_at, seq) a deterministic order. Documents the table-rewrite backfill + sequence-advances-past-max behavior explicitly. 2) Backfill regression test (the coverage CR2 correctly said was missing): new activity_seq_backfill_integration_test.go against real Postgres pins the invariant the migration guarantees — - _SeqBackfill_NoNull: after migrations, NO activity_logs row has NULL seq (per-workspace and table-wide), and the IDENTITY default yields distinct, strictly-increasing, non-null seq for fresh inserts. - _SeqBackfill_SinceIDOnBackfilledRow: a row whose seq came purely from the IDENTITY default (the same mechanism that backfills pre-existing rows) is usable as a since_id cursor — its seq is non-null and a second row sharing its exact created_at microsecond is returned, not dropped. Proven to FAIL if seq were nullable/un-backfilled (ran against a mutant schema with a plain nullable seq column: both tests trip) and PASS as-is. go build ./... + go vet -tags=integration ./internal/handlers/ clean; integration suite green (SinceID|Seq|Backfill|Ordering) on PG16. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>