devops-engineer
81aa23574c
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 1s
CI / Python Lint & Test (pull_request) Successful in 5s
CI / Detect changes (pull_request) Successful in 14s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Harness Replays / detect-changes (pull_request) Successful in 6s
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
E2E Chat / detect-changes (pull_request) Successful in 16s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 44s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
qa-review / approved (pull_request_target) Failing after 9s
security-review / approved (pull_request_target) Failing after 7s
sop-checklist / review-refire (pull_request_target) Has been skipped
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 51s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m1s
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
sop-tier-check / tier-check (pull_request_target) Failing after 13s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m40s
sop-checklist / all-items-acked (pull_request_target) Successful in 32s
CI / Platform (Go) (pull_request) Successful in 2s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 7s
Harness Replays / Harness Replays (pull_request) Successful in 5s
E2E Chat / E2E Chat (pull_request) Successful in 8s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 18s
CI / Canvas (Next.js) (pull_request) Successful in 7m0s
CI / Canvas Deploy Status (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 1s
audit-force-merge / audit (pull_request_target) Successful in 1m19s
core#2216 added two behaviours on top of the happy-path take-control flow that
staging-display.spec.ts already covers (acquire -> noVNC WS upgrade -> first
framebuffer frame), but neither had e2e coverage:
(A) On an unclean WS drop the canvas re-acquires a FRESH control token before
reconnecting (DisplayTab connect(reacquire=true) -> reacquireSession), so
the ~300s cached token can't 401 the reconnect.
(B) A 120s renewal timer re-acquires as the same holder, which the server's
ON-CONFLICT upsert treats as a lease extension, keeping the 300s lease
alive past its original window so the user isn't kicked every ~5 min.
New staging-display-reconnect.spec.ts (sibling to staging-display.spec.ts,
same gating/auth/fail-closed model):
- reconnect test: acquire -> open real noVNC WS (frame) -> drop -> re-acquire
and assert the new session_url carries a DIFFERENT signed token bound to a
renewed expires_at -> reopen WS on the fresh token and assert the
framebuffer RESUMES (real frame, not a 1006/403 dead session).
- renewal test: drive the renewal CALL the 120s timer fires (the same
re-acquire POST) and assert it pushes expires_at strictly past the original
300s deadline, and that GET /display/control still reports a live holder on
the renewed lease. We assert the observable renewal cadence/effect rather
than sleeping 300s of wall-clock; a precise TODO notes the full real-time
>300s-idle-WS variant is gated on a funded standing desktop EC2.
Gated on STAGING_DISPLAY_WORKSPACE_ID (skips loud otherwise, never fail-open),
identical to its sibling. Promote-to-required is a CTO call (standing desktop
EC2 cost + >5min cadence).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>