|
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
sop-checklist-gate / gate (pull_request) Successful in 4s
sop-tier-check / tier-check (pull_request) Successful in 5s
CI / Detect changes (pull_request) Successful in 8s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
CI / Python Lint & Test (pull_request) Successful in 2s
CI / Canvas (Next.js) (pull_request) Successful in 2s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
sop-checklist / all-items-acked (pull_request) Bootstrap exception: sop workflow reads base branch YAML, will pass once merged to staging
CI / Platform (Go) (pull_request) Failing after 1m52s
CI / all-required (pull_request) Successful in 1s
audit-force-merge / audit (pull_request) Successful in 3s
Issue #794. New hub_test.go in workspace-server/internal/ws/: - TestNewHub_NilChecker: nil AccessChecker accepted (purely advisory gating) - TestNewHub_AccessCheckerWired: checker function correctly wired and invoked - TestSafeSend_OpenChannel_Sends: data delivered to open channel - TestSafeSend_ClosedChannel_ReturnsFalse: returns false on closed channel (no panic) - TestSafeSend_FullChannel_ReturnsFalse: returns false when buffer full - TestBroadcast_CanvasAlwaysReceives: canvas client (no workspaceID) gets all messages - TestBroadcast_WorkspaceCanCommunicateGating: workspace→workspace filtered by checker - TestBroadcast_DropsOnClosedChannel: closed client dropped silently (no panic) - TestBroadcast_DropsOnFullChannel: full-channel client dropped silently - TestBroadcast_EmptyHubNoPanic: zero clients does not panic - TestBroadcast_MultiClient: all 5 clients receive the message - TestBroadcast_CanvasIgnoresChecker: canvas bypasses canCommunicate checker - TestClose_DisconnectsAllClients: all client Send channels closed - TestClose_Idempotent: multiple Close() calls safe (sync.Once) - TestClose_ClosesDoneChannel: Run() exits after Close() - TestRun_UnregisterClosesClientSend: Unregister closes client Send channel - TestBroadcast_ConcurrentSafe: 5 concurrent goroutines broadcasting safely Also fixes hub.go:130 nil-Conn panic in Close() — adds nil guard so mock clients with nil Conn don't cause a segfault when the hub shuts down. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| hub_test.go | ||
| hub.go | ||