devops-engineer 59e5b20724 feat(requests): P1 — unified requests/inbox data model + endpoints (RFC) ...

Implements Phase 1 of the unified-requests-inbox RFC: a single `requests`
subsystem that generalizes `user_tasks` (agent→user worklist asks) and
`approval_requests` (the destructive-action gate) into one inbox keyed by
`kind ∈ {task, approval}`, where requester and recipient may each be a user
OR an agent. Responding is asynchronous — the requester never blocks; a
REQUEST_RESPONDED event signals it to pick the answer up on its next tick.

Schema (migrations/20260610120000_requests.{up,down}.sql, idempotent):
- `requests`: kind, requester_{type,id}, org_id, recipient_{type,id}, title,
  detail, status (pending|info_requested|done|rejected|approved|cancelled),
  responder_{type,id}, priority, created/updated/responded_at. recipient_id /
  requester_id are plain TEXT with NO FK (a party may be a user, not a
  workspaces row). Indexes for inbox, org-pending, and outgoing reads.
- `request_messages`: the More-Info / "chat about this" thread (FK → requests,
  ON DELETE CASCADE), indexed by (request_id, created_at).
- Idempotent backfill (ON CONFLICT (id) DO NOTHING) copies historical
  user_tasks (kind=task; dismissed→rejected) and approval_requests
  (kind=approval; denied→rejected, escalated→pending) into the unified inbox
  so the tabs show pre-cutover items.

Store (internal/handlers/request_store.go): RequestStore mirrors UserTaskStore
— per-request over global db.DB, events.EventEmitter for testability, sentinel
errors. Create / Get / Messages / ListInbox / ListOutgoing / ListPendingForOrg
(LEFT JOIN workspaces for the agent name) / Respond (validates action↔kind:
approval→approved|rejected, task→done|rejected) / RequestInfo / AddMessage
(flips info_requested when the recipient asks back) / Cancel. Mutations
broadcast REQUEST_CREATED / REQUEST_RESPONDED / REQUEST_MESSAGE anchored on the
agent party so the canvas/inbox is signalled.

Handler (internal/handlers/requests.go) + routes
(internal/router/router.go), mirroring the approvals/user-tasks auth split:
- wsAuth (workspace token): POST /workspaces/:id/requests, GET .../requests
  (outgoing), GET .../requests/inbox, plus agent-side
  .../requests/:requestId/{get,respond,messages,cancel}.
- AdminAuth (canvas user): GET /requests/pending?kind=task|approval (the tabs),
  and /requests/:requestId/{get,respond,messages,cancel}. The org_id anchor is
  resolved via orgRootID (org_scope.go) — the workspaces table has no org_id
  column.

Events (internal/events/types.go): adds REQUEST_CREATED, REQUEST_RESPONDED,
REQUEST_MESSAGE to the taxonomy + AllEventTypes; drift snapshot
(types_test.go) updated. Canvas TS mirror is a later phase (not touched here).

Tests (internal/handlers/requests_test.go): 20 cases via the existing sqlmock
harness — create (task + approval, agent recipient), inbox vs outgoing,
get+thread, respond (valid + invalid action-for-kind + not-found), More-Info
message → info_requested (recipient flips, requester doesn't), cancel, org
pending list + kind filter, recipient routing.

This is P1 of the unified-requests RFC. Follow-ons: P2 MCP tools + approval
shims, P3 canvas Tasks/Approvals tabs UI, P4 idle-nudge worker. Not included
here.

RFC: docs/design/rfc-unified-requests-inbox.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-10 10:23:24 +00:00

..

broadcaster.go

chore(go-module): #1760 rename Go module to git.moleculesai.app/molecule-ai/molecule-core/workspace-server (#1816)

2026-05-24 23:37:18 +00:00

types_test.go

feat(requests): P1 — unified requests/inbox data model + endpoints (RFC)

2026-06-10 10:23:24 +00:00

types.go

feat(requests): P1 — unified requests/inbox data model + endpoints (RFC)

2026-06-10 10:23:24 +00:00