From 8caff364a7bd28cb8d0178936d83af1dd781d689 Mon Sep 17 00:00:00 2001 From: "Molecule AI Dev Engineer A (Kimi)" Date: Sat, 6 Jun 2026 11:56:41 +0000 Subject: [PATCH] fix(ci): remove continue-on-error mask from review-check-tests jq install (mc#1982) The jq install step in review-check-tests.yml had a pre-existing continue-on-error: true mask (mc#1982). This masked install failures and deferred the failure to the test step, making diagnostics harder. Changes: - Remove continue-on-error: true - Make the install script exit 1 when both apt-get and curl fallback fail, so the step fails loud and localizes the error. - Remove the mc#1982 tracker comment (this IS the root-fix for this step). The review-check.sh regression tests (40 assertions) require jq; if jq cannot be installed the workflow SHOULD fail closed rather than silently continuing to a guaranteed test failure. --- .gitea/workflows/review-check-tests.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.gitea/workflows/review-check-tests.yml b/.gitea/workflows/review-check-tests.yml index 8f37f0bab..86680601f 100644 --- a/.gitea/workflows/review-check-tests.yml +++ b/.gitea/workflows/review-check-tests.yml @@ -60,8 +60,6 @@ jobs: # runners with internet access to package mirrors). Falls back to GitHub # binary download. GitHub releases may be blocked on some runner networks # (infra#241 follow-up). - # mc#1982: pre-existing continue-on-error mask; root-fix and remove, do not renew silently. - continue-on-error: true run: | if apt-get update -qq && apt-get install -y -qq jq; then echo "::notice::jq installed via apt-get: $(jq --version)" @@ -70,9 +68,10 @@ jobs: -o /usr/local/bin/jq && chmod +x /usr/local/bin/jq; then echo "::notice::jq binary downloaded: $(/usr/local/bin/jq --version)" else - echo "::warning::jq install failed — apt-get and GitHub download both failed." + echo "::error::jq install failed — apt-get and GitHub download both failed. review-check.sh regression tests cannot run without jq." + exit 1 fi - jq --version 2>/dev/null || echo "::notice::jq not yet available — continuing" + jq --version - name: Run review-check.sh regression suite run: bash .gitea/scripts/tests/test_review_check.sh -- 2.52.0