From f62d37d6e59e815f6910f37389d0b34930f44b25 Mon Sep 17 00:00:00 2001 From: "Molecule AI Dev Engineer A (Kimi)" Date: Mon, 1 Jun 2026 05:15:05 +0000 Subject: [PATCH 1/2] fix(discovery): check rows.Err() after iteration in queryPeerMaps queryPeerMaps iterated rows.Next() without checking rows.Err() after the loop. A broken connection or cursor error during iteration would silently return a partial result set instead of surfacing the error. Add rows.Err() check after the for-loop and return the error so callers (ListPeers, CheckAccess) fail closed instead of receiving truncated peer data. Fixes #1171 --- workspace-server/internal/handlers/discovery.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/workspace-server/internal/handlers/discovery.go b/workspace-server/internal/handlers/discovery.go index 33ec12637..67089ebd8 100644 --- a/workspace-server/internal/handlers/discovery.go +++ b/workspace-server/internal/handlers/discovery.go @@ -348,6 +348,10 @@ func queryPeerMaps(query string, args ...interface{}) ([]map[string]interface{}, result = append(result, peer) } + if err := rows.Err(); err != nil { + log.Printf("queryPeerMaps rows iteration error: %v", err) + return nil, err + } return result, nil } -- 2.52.0 From b2da94931eb322c579c029343c074eebc2399b6a Mon Sep 17 00:00:00 2001 From: "Molecule AI Dev Engineer A (Kimi)" Date: Mon, 1 Jun 2026 12:36:44 +0000 Subject: [PATCH 2/2] ci: remove unused canvasUserMessage type to fix lint on staging internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that causes golangci-lint `unused` failure on every PR targeting staging. Co-Authored-By: Claude Opus 4.7 --- workspace-server/internal/handlers/a2a_proxy_helpers.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/workspace-server/internal/handlers/a2a_proxy_helpers.go b/workspace-server/internal/handlers/a2a_proxy_helpers.go index 98c51bb7d..11916e6b1 100644 --- a/workspace-server/internal/handlers/a2a_proxy_helpers.go +++ b/workspace-server/internal/handlers/a2a_proxy_helpers.go @@ -407,15 +407,6 @@ func validateCallerToken(ctx context.Context, c *gin.Context, callerID string) e // matching (the wsauth errors are typed for the invalid case). var errInvalidCallerToken = errors.New("missing caller auth token") -// canvasUserMessage holds the extracted user message extracted from an -// A2A canvas request body for broadcasting to other sessions. -type canvasUserMessage struct { - Message string `json:"message,omitempty"` - Parts []map[string]interface{} `json:"parts,omitempty"` - MessageID string `json:"messageId,omitempty"` - Attachments []map[string]interface{} `json:"attachments,omitempty"` -} - // extractCanvasUserMessage parses an A2A JSON-RPC request body and extracts // the user-authored text and attachments from a canvas-initiated message/send. // Returns nil when the body is not a canvas user message (empty, malformed, -- 2.52.0