fix(org-import): migrate runtime schedules from removed predecessor on recreate #2007

Merged

hongming merged 1 commits from fix/schedule-migration-on-recreate into main 2026-05-29 09:28:59 +00:00

Conversation 2 Commits 1 Files Changed 2

+143

hongming commented 2026-05-29 09:03:27 +00:00

Owner

Copy Link

Copy Source

internal#2006 — recreate orphaned runtime schedules. createWorkspaceTree mints a new id when the prior ws is removed; reconcile re-derives template state but runtime-created schedules orphan on the removed row. Fix migrates them from the most-recent removed predecessor (matched by stable role, fallback name+parent) onto the new ws before the template upsert. +3 tests. Part 1/3 of the schedule recreate-resilience work (monitor + cleaner follow).

internal#2006 — recreate orphaned runtime schedules. createWorkspaceTree mints a new id when the prior ws is removed; reconcile re-derives template state but runtime-created schedules orphan on the removed row. Fix migrates them from the most-recent removed predecessor (matched by stable role, fallback name+parent) onto the new ws before the template upsert. +3 tests. Part 1/3 of the schedule recreate-resilience work (monitor + cleaner follow).

hongming added 1 commit 2026-05-29 09:03:28 +00:00

fix(org-import): migrate runtime schedules from removed predecessor on recreate ... a44a110d60

internal#2006 — recreating an agent orphans its schedules.

Root cause: createWorkspaceTree's INSERT … ON CONFLICT (parent_id,name)
WHERE status != 'removed' only matches NON-removed rows, so when an agent
is recreated after its prior workspace was marked removed, a brand-new
workspace id is minted. Reconcile then re-derives template-sourced state
(MODEL, template schedules via the upsert loop), but schedules a user added
at runtime (source='runtime', via the canvas/API) bind to the ephemeral
workspace_id and are abandoned on the removed row — they silently stop
firing (the 2026-05-29 agents-team incident: all 5 *-autonomous-tick
schedules, source=runtime, orphaned on removed ids; canvas showed
"missing schedulers").

Fix: after a fresh insert, migrate runtime-created schedules from the
most-recent removed predecessor of the same agent onto the new workspace.
The predecessor is matched by the stable `role` (survives the name
auto-suffixing that yields "Agent (2)"), falling back to name+parent.
Template-sourced schedules are NOT migrated (reconcile re-derives those);
runs before the template upsert loop so a same-named template schedule
still wins; skips names already present on the new workspace; best-effort
(logs, never errors the import).

Tests: predecessor-found re-points; no-predecessor (first create) does NOT
run the UPDATE; name-fallback branch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

core-lead approved these changes 2026-05-29 09:04:09 +00:00

core-lead left a comment

Member

Copy Link

Copy Source

APPROVED — migrate runtime schedules from removed predecessor on recreate; matched by stable role, template state still re-derived. +3 tests, build green.

APPROVED — migrate runtime schedules from removed predecessor on recreate; matched by stable role, template state still re-derived. +3 tests, build green.

core-be approved these changes 2026-05-29 09:04:10 +00:00

core-be left a comment

Member

Copy Link

Copy Source

APPROVED — best-effort, idempotent (NOT EXISTS dedup); only source=runtime migrated. Closes the recreate-orphan gap.

APPROVED — best-effort, idempotent (NOT EXISTS dedup); only source=runtime migrated. Closes the recreate-orphan gap.

hongming referenced this pull request 2026-05-29 09:08:41 +00:00

feat(admin-schedules): orphan monitor + cleaner endpoints (internal#2006 backstops) #2008

hongming merged commit feb2b8cfb8 into main 2026-05-29 09:28:59 +00:00

hongming referenced this issue from a commit 2026-05-29 09:29:01 +00:00

Merge pull request 'fix(org-import): migrate runtime schedules from removed predecessor on recreate' (#2007) from fix/schedule-migration-on-recreate into main

Sign in to join this conversation.

Reviewers

No Reviewers

core-lead

core-be

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2007