From f36acdf823f522104446e1cab1e3eb3a768ef73c Mon Sep 17 00:00:00 2001 From: "Molecule AI Dev Engineer A (Kimi)" Date: Sun, 24 May 2026 23:38:42 +0000 Subject: [PATCH] style(scripts): fix ruff F401, F541, F841, E741 in 8 files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - ci-required-drift.py: remove extraneous f-string prefixes (F541 x4) - lint-curl-status-capture.py: remove unused `sys` import (F401) - lint_bp_context_emit_match.py: rename ambiguous `l` → `lbl` (E741) - lint_continue_on_error_tracking.py: remove unused `timedelta` import (F401) - sop-checklist.py: prefix unused `rejected_unknown` → `_rejected_unknown` (F841), rename ambiguous `l` → `lbl` (E741 x2) - tests/_review_check_fixture.py: prefix unused vars → `_owner`, `_name`, `_team_id` (F841 x3) - tests/test_lint_pre_flip_continue_on_error.py: remove unused `os` import (F401) - tests/test_sop_checklist.py: remove unused `tempfile` import (F401) All checks pass (`ruff check .` clean). Co-Authored-By: Claude Opus 4.7 --- .gitea/scripts/ci-required-drift.py | 8 ++++---- .gitea/scripts/lint-curl-status-capture.py | 1 - .gitea/scripts/lint_bp_context_emit_match.py | 2 +- .gitea/scripts/lint_continue_on_error_tracking.py | 2 +- .gitea/scripts/sop-checklist.py | 6 +++--- .gitea/scripts/tests/_review_check_fixture.py | 4 ++-- .../scripts/tests/test_lint_pre_flip_continue_on_error.py | 1 - .gitea/scripts/tests/test_sop_checklist.py | 1 - 8 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.gitea/scripts/ci-required-drift.py b/.gitea/scripts/ci-required-drift.py index 8de6de46c..8d280aeab 100755 --- a/.gitea/scripts/ci-required-drift.py +++ b/.gitea/scripts/ci-required-drift.py @@ -547,12 +547,12 @@ def file_or_update( if dry_run: print(f"::notice::[dry-run] would file/update drift issue for {branch}") - print(f"::group::[dry-run] title") + print("::group::[dry-run] title") print(title) - print(f"::endgroup::") - print(f"::group::[dry-run] body") + print("::endgroup::") + print("::group::[dry-run] body") print(body) - print(f"::endgroup::") + print("::endgroup::") return existing = find_open_issue(title) diff --git a/.gitea/scripts/lint-curl-status-capture.py b/.gitea/scripts/lint-curl-status-capture.py index 73cbbab51..706be053a 100644 --- a/.gitea/scripts/lint-curl-status-capture.py +++ b/.gitea/scripts/lint-curl-status-capture.py @@ -13,7 +13,6 @@ from __future__ import annotations import argparse import glob import re -import sys from pathlib import Path from typing import NamedTuple diff --git a/.gitea/scripts/lint_bp_context_emit_match.py b/.gitea/scripts/lint_bp_context_emit_match.py index 59453f66e..d24bb2e31 100644 --- a/.gitea/scripts/lint_bp_context_emit_match.py +++ b/.gitea/scripts/lint_bp_context_emit_match.py @@ -283,7 +283,7 @@ def _ensure_labels(repo: str, names: list[str]) -> list[int]: if status != "ok" or not isinstance(labels, list): return [] out: list[int] = [] - by_name = {l["name"]: l["id"] for l in labels if isinstance(l, dict)} + by_name = {lbl["name"]: lbl["id"] for lbl in labels if isinstance(lbl, dict)} for n in names: if n in by_name: out.append(by_name[n]) diff --git a/.gitea/scripts/lint_continue_on_error_tracking.py b/.gitea/scripts/lint_continue_on_error_tracking.py index afb1fcaee..5c56be554 100644 --- a/.gitea/scripts/lint_continue_on_error_tracking.py +++ b/.gitea/scripts/lint_continue_on_error_tracking.py @@ -82,7 +82,7 @@ import sys import urllib.error import urllib.parse import urllib.request -from datetime import datetime, timedelta, timezone +from datetime import datetime, timezone from pathlib import Path from typing import Any diff --git a/.gitea/scripts/sop-checklist.py b/.gitea/scripts/sop-checklist.py index b476ff8f8..e454525e6 100644 --- a/.gitea/scripts/sop-checklist.py +++ b/.gitea/scripts/sop-checklist.py @@ -338,7 +338,7 @@ def compute_ack_state( # Filter out self-acks and unknown slugs. ackers_per_slug: dict[str, list[str]] = {s: [] for s in items_by_slug} rejected_self: dict[str, list[str]] = {s: [] for s in items_by_slug} - rejected_unknown: dict[str, list[str]] = {s: [] for s in items_by_slug} + _rejected_unknown: dict[str, list[str]] = {s: [] for s in items_by_slug} pending_team_check: dict[str, list[str]] = {s: [] for s in items_by_slug} for (user, slug), kind in latest_directive.items(): @@ -842,7 +842,7 @@ def render_status( def get_tier_mode(pr: dict[str, Any], cfg: dict[str, Any]) -> str: """Read tier label, return 'hard' or 'soft' per cfg.tier_failure_mode.""" labels = pr.get("labels") or [] - tier_labels = [l.get("name", "") for l in labels if (l.get("name", "") or "").startswith("tier:")] + tier_labels = [lbl.get("name", "") for lbl in labels if (lbl.get("name", "") or "").startswith("tier:")] mode_map = cfg.get("tier_failure_mode") or {} default_mode = cfg.get("default_mode", "hard") for tl in tier_labels: @@ -865,7 +865,7 @@ def is_high_risk(pr: dict[str, Any], cfg: dict[str, Any]) -> bool: Governance fix for internal#442 — closes the inconsistency between sop-tier-check (tier-aware) and sop-checklist (was tier-blind). """ - label_set = {(l.get("name") or "") for l in (pr.get("labels") or [])} + label_set = {(lbl.get("name") or "") for lbl in (pr.get("labels") or [])} if "tier:high" in label_set: return True high_risk_labels = set(cfg.get("high_risk_labels") or []) diff --git a/.gitea/scripts/tests/_review_check_fixture.py b/.gitea/scripts/tests/_review_check_fixture.py index 1a76bac8f..13e16178f 100644 --- a/.gitea/scripts/tests/_review_check_fixture.py +++ b/.gitea/scripts/tests/_review_check_fixture.py @@ -81,7 +81,7 @@ class Handler(http.server.BaseHTTPRequestHandler): # GET /repos/{owner}/{name}/pulls/{pr_number} m = re.match(r"^/api/v1/repos/([^/]+)/([^/]+)/pulls/(\d+)$", path) if m: - owner, name, pr_num = m.group(1), m.group(2), m.group(3) + _owner, _name, pr_num = m.group(1), m.group(2), m.group(3) if sc == "T2_pr_closed": return self._json(200, { "number": int(pr_num), @@ -151,7 +151,7 @@ class Handler(http.server.BaseHTTPRequestHandler): # GET /teams/{team_id}/members/{username} m = re.match(r"^/api/v1/teams/(\d+)/members/([^/]+)$", path) if m: - team_id, login = m.group(1), m.group(2) + _team_id, login = m.group(1), m.group(2) if sc == "T8_team_not_member": return self._empty(404) if sc == "T9_team_403": diff --git a/.gitea/scripts/tests/test_lint_pre_flip_continue_on_error.py b/.gitea/scripts/tests/test_lint_pre_flip_continue_on_error.py index df86a8c68..333fb814a 100644 --- a/.gitea/scripts/tests/test_lint_pre_flip_continue_on_error.py +++ b/.gitea/scripts/tests/test_lint_pre_flip_continue_on_error.py @@ -15,7 +15,6 @@ Mirrors the pattern in scripts/ops/test_check_migration_collisions.py from __future__ import annotations import importlib.util -import os import sys import unittest from pathlib import Path diff --git a/.gitea/scripts/tests/test_sop_checklist.py b/.gitea/scripts/tests/test_sop_checklist.py index 10925e2db..3ac2c1321 100644 --- a/.gitea/scripts/tests/test_sop_checklist.py +++ b/.gitea/scripts/tests/test_sop_checklist.py @@ -22,7 +22,6 @@ from __future__ import annotations import os import sys -import tempfile import unittest # Resolve sibling script regardless of where pytest is invoked from. -- 2.52.0