From 3195d150462b9b67797e161aecac9181e507d553 Mon Sep 17 00:00:00 2001 From: "Molecule AI Dev Engineer A (Kimi)" Date: Sun, 24 May 2026 18:48:54 +0000 Subject: [PATCH] style(scripts): resolve ruff I001, E501, F401, E741 in gitea scripts and tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Second batch of lint fixes across 9 files in .gitea/scripts/: - sort imports (I001) - wrap long lines to ≤88 chars (E501) - remove unused timedelta import (F401) - rename ambiguous variable `l` → `lbl` (E741) All 148 tests pass. Co-Authored-By: Claude Opus 4.7 --- .gitea/scripts/compare-api-diff-files.py | 2 +- .gitea/scripts/lint-required-no-paths.py | 13 ++++++++++--- .gitea/scripts/lint_bp_context_emit_match.py | 4 +++- .gitea/scripts/lint_continue_on_error_tracking.py | 2 +- .gitea/scripts/push-commits-diff-files.py | 2 +- .gitea/scripts/tests/_refire_fixture.py | 1 - .../scripts/tests/test_ci_workflow_bookkeeping.py | 1 - .gitea/scripts/tests/test_prod_auto_deploy.py | 5 +++-- .gitea/scripts/tests/test_status_reaper_api.py | 10 ++++++---- 9 files changed, 25 insertions(+), 15 deletions(-) diff --git a/.gitea/scripts/compare-api-diff-files.py b/.gitea/scripts/compare-api-diff-files.py index f46011f61..83a7f6803 100755 --- a/.gitea/scripts/compare-api-diff-files.py +++ b/.gitea/scripts/compare-api-diff-files.py @@ -13,8 +13,8 @@ Exits 1 on malformed input (caller should handle as "no files"). """ from __future__ import annotations -import sys import json +import sys def main() -> None: diff --git a/.gitea/scripts/lint-required-no-paths.py b/.gitea/scripts/lint-required-no-paths.py index 911e8884c..1b2385430 100755 --- a/.gitea/scripts/lint-required-no-paths.py +++ b/.gitea/scripts/lint-required-no-paths.py @@ -335,7 +335,10 @@ def run() -> int: ) return 0 - print(f"::notice::Linting {len(contexts)} required context(s) for paths-filter regressions:") + print( + f"::notice::Linting {len(contexts)} required context(s) " + f"for paths-filter regressions:" + ) for c in contexts: print(f" - {c}") @@ -370,7 +373,10 @@ def run() -> int: if offenders: print("") - print(f"::error::Found {len(offenders)} required workflow(s) with paths/paths-ignore filters:") + print( + f"::error::Found {len(offenders)} required workflow(s) " + f"with paths/paths-ignore filters:" + ) for workflow_name, wf_path, findings in offenders: for finding in findings: # ::error file=... lets Gitea Actions surface a per-file @@ -382,7 +388,8 @@ def run() -> int: f"silent indefinite pending: {finding}. " f"See feedback_path_filtered_workflow_cant_be_required. " f"Fix: remove the filter and instead gate per-step " - f"inside the job with `if: contains(steps.changed.outputs.files, ...)` " + f"inside the job with " + f"`if: contains(steps.changed.outputs.files, ...)` " f"or refactor to a single-job-with-per-step-if shape." ) return 1 diff --git a/.gitea/scripts/lint_bp_context_emit_match.py b/.gitea/scripts/lint_bp_context_emit_match.py index 59453f66e..42d235436 100644 --- a/.gitea/scripts/lint_bp_context_emit_match.py +++ b/.gitea/scripts/lint_bp_context_emit_match.py @@ -283,7 +283,9 @@ def _ensure_labels(repo: str, names: list[str]) -> list[int]: if status != "ok" or not isinstance(labels, list): return [] out: list[int] = [] - by_name = {l["name"]: l["id"] for l in labels if isinstance(l, dict)} + by_name = { + lbl["name"]: lbl["id"] for lbl in labels if isinstance(lbl, dict) + } for n in names: if n in by_name: out.append(by_name[n]) diff --git a/.gitea/scripts/lint_continue_on_error_tracking.py b/.gitea/scripts/lint_continue_on_error_tracking.py index afb1fcaee..5c56be554 100644 --- a/.gitea/scripts/lint_continue_on_error_tracking.py +++ b/.gitea/scripts/lint_continue_on_error_tracking.py @@ -82,7 +82,7 @@ import sys import urllib.error import urllib.parse import urllib.request -from datetime import datetime, timedelta, timezone +from datetime import datetime, timezone from pathlib import Path from typing import Any diff --git a/.gitea/scripts/push-commits-diff-files.py b/.gitea/scripts/push-commits-diff-files.py index 503d030e8..19d200f32 100644 --- a/.gitea/scripts/push-commits-diff-files.py +++ b/.gitea/scripts/push-commits-diff-files.py @@ -11,8 +11,8 @@ Exits 0 always (caller handles empty output as "no files"). """ from __future__ import annotations -import sys import json +import sys def main() -> None: diff --git a/.gitea/scripts/tests/_refire_fixture.py b/.gitea/scripts/tests/_refire_fixture.py index 3844ba5c1..cdf1a9501 100755 --- a/.gitea/scripts/tests/_refire_fixture.py +++ b/.gitea/scripts/tests/_refire_fixture.py @@ -25,7 +25,6 @@ import re import sys import urllib.parse - STATE_DIR = os.environ["FIXTURE_STATE_DIR"] diff --git a/.gitea/scripts/tests/test_ci_workflow_bookkeeping.py b/.gitea/scripts/tests/test_ci_workflow_bookkeeping.py index 418dea648..d8dd23f2c 100644 --- a/.gitea/scripts/tests/test_ci_workflow_bookkeeping.py +++ b/.gitea/scripts/tests/test_ci_workflow_bookkeeping.py @@ -2,7 +2,6 @@ from pathlib import Path import yaml - ROOT = Path(__file__).resolve().parents[2] diff --git a/.gitea/scripts/tests/test_prod_auto_deploy.py b/.gitea/scripts/tests/test_prod_auto_deploy.py index f1417c8a1..32199c733 100644 --- a/.gitea/scripts/tests/test_prod_auto_deploy.py +++ b/.gitea/scripts/tests/test_prod_auto_deploy.py @@ -2,7 +2,6 @@ import importlib.util import sys from pathlib import Path - SCRIPT = Path(__file__).resolve().parents[1] / "prod-auto-deploy.py" spec = importlib.util.spec_from_file_location("prod_auto_deploy", SCRIPT) prod = importlib.util.module_from_spec(spec) @@ -137,7 +136,9 @@ def test_ci_context_state_handles_missing_and_gitea_status_key(): def test_context_is_satisfied_accepts_only_success(): assert prod.context_is_satisfied("success") is True - for state in ("failure", "error", "cancelled", "canceled", "skipped", "pending", "missing"): + for state in ( + "failure", "error", "cancelled", "canceled", "skipped", "pending", "missing" + ): assert prod.context_is_satisfied(state) is False diff --git a/.gitea/scripts/tests/test_status_reaper_api.py b/.gitea/scripts/tests/test_status_reaper_api.py index 98c4d5d70..a8e52146b 100644 --- a/.gitea/scripts/tests/test_status_reaper_api.py +++ b/.gitea/scripts/tests/test_status_reaper_api.py @@ -3,7 +3,6 @@ import json import pathlib import urllib.error - ROOT = pathlib.Path(__file__).resolve().parents[1] SCRIPT = ROOT / "status-reaper.py" @@ -125,7 +124,10 @@ def test_reap_compensates_failed_pr_context_when_push_equivalent_passed(monkeypa ), ( "db3b7a93e31adc0cb072a6d177d92dd73275a191", - "Handlers Postgres Integration / Handlers Postgres Integration (pull_request)", + ( + "Handlers Postgres Integration / " + "Handlers Postgres Integration (pull_request)" + ), "https://git.example.test/handlers-pr", mod.PR_SHADOW_COMPENSATION_DESCRIPTION, False, @@ -139,8 +141,8 @@ def test_reap_preserves_failed_pr_context_without_push_success(monkeypatch): monkeypatch.setattr( mod, "post_compensating_status", - lambda sha, context, target_url, *, description="", dry_run=False: posted.append( - context + lambda sha, context, target_url, *, description="", dry_run=False: ( + posted.append(context) ), ) -- 2.52.0