molecule-ai/molecule-core
52
0
Fork 2
Code Issues 179 Pull Requests 58 Actions 8 Packages Projects Releases Wiki Activity

test: templates_test.go fixtures broken on main — missing runtime field collides with runtime-allowlist filter #1778

New Issue
Closed
opened 2026-05-24 05:25:51 +00:00 by hongming · 0 comments
hongming commented 2026-05-24 05:25:51 +00:00
Owner
Copy Link
Copy Source

Summary

TestTemplatesList_WithTemplates, TestTemplatesList_LegacyTopLevelModel, TestTemplatesList_NoProvidersField, and likely several sibling tests in workspace-server/internal/handlers/templates_test.go fail locally on origin/main HEAD (verified at 50720fb8, 2026-05-24). The runtime-allowlist filter landed in templates.go without corresponding fixture updates.

Reproduction

cd ~/molecule-core/workspace-server
go test -run '^TestTemplatesList_WithTemplates$' -count=1 ./internal/handlers/

Output:

2026/05/23 22:17:01 runtime registry: manifest.json not found, using fallback allowlist (8 entries)
2026/05/23 22:17:01 templates list: skip test-agent: unsupported runtime ""
--- FAIL: TestTemplatesList_WithTemplates (0.00s)
    templates_test.go:119: expected 1 template, got 0

Root cause

workspace-server/internal/handlers/templates.go has a runtime allowlist filter:

runtime := strings.TrimSuffix(strings.TrimSpace(raw.Runtime), "-default")
if _, ok := knownRuntimes[runtime]; !ok {
    log.Printf("templates list: skip %s: unsupported runtime %q", id, runtime)
    return
}

Test fixtures in templates_test.go (around lines 80-90, 553-565, 596-608) do NOT set runtime: in their config.yaml. Empty runtime "" is not in knownRuntimes, so all templates get skipped → tests fail.

Why CI on main "passes" despite tests being broken

CI's working tree apparently has the manifest.json file present (so the runtime registry loads the full allowlist, which evidently allows empty runtime); local dev trees don't have it. Test is environment-dependent. This is a deeper test-hygiene bug.

Acceptance

  • All TestTemplatesList_* tests pass on a fresh local checkout (no manifest.json present)
  • Test fixtures use runtime: <something-in-knownRuntimes> consistently
  • Document or remove the runtime-registry fallback-allowlist drift

Discovered during

Multi-PR CTO-bypass merge session 2026-05-24. #1759's Platform (Go) failed with this; cross-checked against origin/main and confirmed identical failure → unrelated to #1759's seedInitialMemories work.

## Summary `TestTemplatesList_WithTemplates`, `TestTemplatesList_LegacyTopLevelModel`, `TestTemplatesList_NoProvidersField`, and likely several sibling tests in `workspace-server/internal/handlers/templates_test.go` **fail locally on origin/main HEAD** (verified at 50720fb8, 2026-05-24). The runtime-allowlist filter landed in templates.go without corresponding fixture updates. ## Reproduction ``` cd ~/molecule-core/workspace-server go test -run '^TestTemplatesList_WithTemplates$' -count=1 ./internal/handlers/ ``` Output: ``` 2026/05/23 22:17:01 runtime registry: manifest.json not found, using fallback allowlist (8 entries) 2026/05/23 22:17:01 templates list: skip test-agent: unsupported runtime "" --- FAIL: TestTemplatesList_WithTemplates (0.00s) templates_test.go:119: expected 1 template, got 0 ``` ## Root cause `workspace-server/internal/handlers/templates.go` has a runtime allowlist filter: ```go runtime := strings.TrimSuffix(strings.TrimSpace(raw.Runtime), "-default") if _, ok := knownRuntimes[runtime]; !ok { log.Printf("templates list: skip %s: unsupported runtime %q", id, runtime) return } ``` Test fixtures in `templates_test.go` (around lines 80-90, 553-565, 596-608) do NOT set `runtime:` in their config.yaml. Empty runtime `""` is not in `knownRuntimes`, so all templates get skipped → tests fail. ## Why CI on main "passes" despite tests being broken CI's working tree apparently has the `manifest.json` file present (so the runtime registry loads the full allowlist, which evidently allows empty runtime); local dev trees don't have it. Test is environment-dependent. This is a deeper test-hygiene bug. ## Acceptance - [ ] All `TestTemplatesList_*` tests pass on a fresh local checkout (no manifest.json present) - [ ] Test fixtures use `runtime: <something-in-knownRuntimes>` consistently - [ ] Document or remove the runtime-registry fallback-allowlist drift ## Discovered during Multi-PR CTO-bypass merge session 2026-05-24. #1759's Platform (Go) failed with this; cross-checked against origin/main and confirmed identical failure → unrelated to #1759's seedInitialMemories work.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?