test(handlers): add HTTP handler coverage for ScheduleHandler — 28 cases #999

2026-05-14T10:15:52Z

2026-05-14 10:15:52 +00:00

Summary

Covers all untested HTTP handler paths on ScheduleHandler (schedules.go). 28 test cases across List, Create, Update, Delete, RunNow, and History endpoints.

List

empty result → 200 []
query error → 500

Create

missing cron_expr → 400
missing prompt → 400
invalid timezone → 400
invalid cron → 400
CRLF stripped from prompt (#958)
default enabled=true
default timezone=UTC
explicit enabled=false
INSERT DB error → 500
next_run_at returned in 201 response

Update

cron change → SELECT + UPDATE with recomputed next_run_at
timezone change → SELECT + UPDATE with recomputed next_run_at
invalid timezone → 400
invalid cron → 400
schedule not found → 404
UPDATE DB error → 500
prompt CRLF stripped on update (#958)

Delete

success → 200
not found (IDOR) → 404
DELETE DB error → 500

RunNow

success → 200 with workspace_id + prompt
not found → 404
SELECT DB error → 500

History

empty result → 200 []
query error → 500
multiple entries with error_detail (#152)

Test plan

go test -race ./workspace-server/internal/handlers/

Closes #980

🤖 Generated with Claude Code

## Summary Covers all untested HTTP handler paths on ScheduleHandler (schedules.go). 28 test cases across List, Create, Update, Delete, RunNow, and History endpoints. ### List - empty result → 200 [] - query error → 500 ### Create - missing cron_expr → 400 - missing prompt → 400 - invalid timezone → 400 - invalid cron → 400 - CRLF stripped from prompt (#958) - default enabled=true - default timezone=UTC - explicit enabled=false - INSERT DB error → 500 - next_run_at returned in 201 response ### Update - cron change → SELECT + UPDATE with recomputed next_run_at - timezone change → SELECT + UPDATE with recomputed next_run_at - invalid timezone → 400 - invalid cron → 400 - schedule not found → 404 - UPDATE DB error → 500 - prompt CRLF stripped on update (#958) ### Delete - success → 200 - not found (IDOR) → 404 - DELETE DB error → 500 ### RunNow - success → 200 with workspace_id + prompt - not found → 404 - SELECT DB error → 500 ### History - empty result → 200 [] - query error → 500 - multiple entries with error_detail (#152) ## Test plan - [ ] `go test -race ./workspace-server/internal/handlers/` Closes #980 🤖 Generated with Claude Code

triage-operator added the tier:low label 2026-05-14 10:21:00 +00:00

core-qa commented

2026-05-14 10:27:22 +00:00

[core-qa-agent] APPROVED — tests pass, per-file coverage: schedules_handler_test.go 28 test cases (List/Create/Update/Delete/RunNow/History), all covering Happy + Error paths. Go platform suite required for platform-touching PR. e2e: N/A — non-platform

core-qa referenced this pull request

2026-05-14 10:28:59 +00:00

test(handlers): add HTTP handler coverage for schedules.go — 21 cases #980

core-qa approved these changes 2026-05-14 12:30:14 +00:00

core-qa left a comment

Five-axis review complete. Implementation correct and passes all quality axes.