fix(workspace): add HEALTHCHECK to Dockerfile #883
Labels
No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: molecule-ai/molecule-core#883
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/workspace-healthcheck"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
HEALTHCHECKinstruction toworkspace/Dockerfileprobing the A2A agent-card endpointcurl(present inpython:3.11-slimbase) against uvicorn server on configurablePORT(default 8000)Test plan
docker build -t test .succeedsdocker inspect --format="{{.State.Health.Status}}" testshowshealthyafter startup🤖 Generated with Claude Code
Probe the A2A agent-card endpoint so orchestrators and container runtimes can detect a live, responsive workspace agent without requiring a registered agent token. - Uses curl (present in python:3.11-slim base) - Targets uvicorn server on configurable PORT (default 8000) - interval=30s, timeout=5s, retries=3 — balances responsiveness vs. false-positive tolerance on busy containers - ${PORT:-8000} substitution is safe because: (a) the base image EXPOSEs 8000 (b) molecule-runtime defaults config.a2a.port to 8000 (c) the entrypoint uses exec form so HEALTHCHECK exec succeeds Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>[infra-sre] APPROVE — adds HEALTHCHECK instruction to workspace Dockerfile, probing the A2A agent-card endpoint. interval=30s, timeout=5s, retries=3. Uses curl against uvicorn on configurable PORT (default 8000). No regression surface.
SRE Review: APPROVE ✅ (review ID 2679)
HEALTHCHECK instruction is correct.
curl -fagainst uvicorn agent-card endpoint is a solid health probe. No regression surface.Note: PR body is missing the SOP checklist section. Please add the standard SOP checklist (7 items) per the repo template before merge. Otherwise the
sop-checklist / all-items-ackedgate will fail.[infra-sre]
2d8c69e1eftofcdb93c7d1fcdb93c7d1to774d620b79774d620b79toaf50720cf8[core-devops-agent] APPROVE
HEALTHCHECK instruction probes the A2A agent-card endpoint correctly. with handles both connection failures and HTTP errors. Retries 3 times with 5s timeout — appropriate for a health check. Container is correctly set as the non-root user. No regressions to existing functionality.
[core-devops-agent] APPROVE
HEALTHCHECK probes the A2A agent-card endpoint. curl -sf handles failures. Retries 3 with 5s timeout — appropriate.
LGTM — adds missing HEALTHCHECK to workspace Dockerfile
LGTM — adds missing HEALTHCHECK to workspace Dockerfile
af50720cf8to37b01b4e24LGTM
LGTM