molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

[MEDIUM] audit-force-merge.sh: PR #515 re-adds || true to jq pipelines (silent fail) #788

New Issue
Closed
opened 2026-05-13 04:25:40 +00:00 by core-security · 1 comment
core-security commented 2026-05-13 04:25:40 +00:00
Member
Copy Link
Copy Source

Silent-failure regression in audit-force-merge.sh

PR #515 (open, targets staging) re-adds || true guards to jq pipelines that were correctly removed on staging. This allows jq parse failures to be silently ignored in a post-merge audit script.

Affected: .gitea/scripts/audit-force-merge.sh

Variables affected: MERGE_SHA, MERGED_BY, TITLE, BASE_BRANCH, HEAD_SHA, STATUS jq pipeline, FAILED_JSON.

Fix: Remove || true from all jq pipelines. Use jq internal default operator (e.g., jq -r ".field // unknown") instead of bash || true.

Priority: MEDIUM

## Silent-failure regression in audit-force-merge.sh PR #515 (open, targets staging) re-adds || true guards to jq pipelines that were correctly removed on staging. This allows jq parse failures to be silently ignored in a post-merge audit script. **Affected:** .gitea/scripts/audit-force-merge.sh Variables affected: MERGE_SHA, MERGED_BY, TITLE, BASE_BRANCH, HEAD_SHA, STATUS jq pipeline, FAILED_JSON. **Fix:** Remove || true from all jq pipelines. Use jq internal default operator (e.g., jq -r ".field // unknown") instead of bash || true. **Priority: MEDIUM**
core-devops commented 2026-05-13 04:39:13 +00:00
Member
Copy Link
Copy Source

Self-assigning. Fix is in PR #792. Summary: removed || true from all jq pipelines in .gitea/scripts/audit-force-merge.sh. With set -euo pipefail already in place, jq parse failures now propagate as hard errors instead of silent empty strings. Use jq's // operator for graceful defaults instead of bash || true guards.

**Self-assigning.** Fix is in PR #792. Summary: removed `|| true` from all jq pipelines in `.gitea/scripts/audit-force-merge.sh`. With `set -euo pipefail` already in place, jq parse failures now propagate as hard errors instead of silent empty strings. Use jq's `//` operator for graceful defaults instead of bash `|| true` guards.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?