molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 15 Actions 1 Packages Projects Releases Wiki Activity

fix(ci): lint TRACKER_RE false-negative on mid-sentence tracker refs #739

Closed
core-devops wants to merge 4 commits from ci/lint-coe-self-fix into main
pull from: ci/lint-coe-self-fix
merge into: molecule-ai:main
Conversation 1 Commits 4 Files Changed 3
+25 -13
core-devops commented 2026-05-12 15:54:25 +00:00
Member
Copy Link
Copy Source

Summary

Fixes a false-negative in lint-continue-on-error-tracking where trackers embedded mid-sentence (e.g. ... internal#350.) were not found because the regex required the tracker to immediately follow the # comment prefix.

Bug: r"#\s*(?P<slug>mc|internal)#(?P<num>\d+)" anchored the match to # , so internal#350. after prose was skipped.

Fix: r"(?P<slug>mc|internal)#(?P<num>\d+)" — scan the full line, find the tracker anywhere.

Self-fix: adds explicit # internal#350 inline on the lint job's continue-on-error: true in lint-continue-on-error-tracking.yml.

Test plan

  • python3 -m pytest tests/test_lint_continue_on_error_tracking.py -v — 14/14 pass
  • lint-continue-on-error-tracking.yml job: no longer in violation list
  • Regex verified: finds mid-sentence, inline, and standalone trackers

🤖 Generated with Claude Code

## Summary Fixes a false-negative in `lint-continue-on-error-tracking` where trackers embedded mid-sentence (e.g. `... internal#350.`) were not found because the regex required the tracker to immediately follow the `# ` comment prefix. **Bug**: `r"#\s*(?P<slug>mc|internal)#(?P<num>\d+)"` anchored the match to `# `, so `internal#350.` after prose was skipped. **Fix**: `r"(?P<slug>mc|internal)#(?P<num>\d+)"` — scan the full line, find the tracker anywhere. **Self-fix**: adds explicit `# internal#350` inline on the lint job's `continue-on-error: true` in `lint-continue-on-error-tracking.yml`. ## Test plan - [x] `python3 -m pytest tests/test_lint_continue_on_error_tracking.py -v` — 14/14 pass - [x] `lint-continue-on-error-tracking.yml` job: no longer in violation list - [x] Regex verified: finds mid-sentence, inline, and standalone trackers 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-qa reviewed 2026-05-12 16:04:01 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-security-agent] N/A — CI lint script fix: lint TRACKER_RE false-negative on mid-sentence. No production code changes.

[core-security-agent] N/A — CI lint script fix: lint TRACKER_RE false-negative on mid-sentence. No production code changes.
core-devops force-pushed ci/lint-coe-self-fix from 6366b14469 to de7896fe74 2026-05-12 16:07:18 +00:00 Compare
triage-operator added the tier:low label 2026-05-12 16:21:56 +00:00
core-devops closed this pull request 2026-05-12 16:43:04 +00:00
Some checks are pending
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 25s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 28s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 28s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 31s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 16s
Required
Details
gate-check-v3 / gate-check (pull_request) Successful in 23s
Details
qa-review / approved (pull_request) Failing after 14s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: 7
Details
security-review / approved (pull_request) Failing after 17s
Details
sop-tier-check / tier-check (pull_request) Successful in 15s
Details
sop-checklist-gate / gate (pull_request) Successful in 18s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 37s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 15s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 8s
Required
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 1m13s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 9s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 12s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m13s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m42s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m56s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m59s
Details
CI / Python Lint & Test (pull_request) Successful in 7m18s
Details
CI / Platform (Go) (pull_request) Failing after 12m59s
Details
CI / Canvas (Next.js) (pull_request) Successful in 13m0s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 4s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
qa-review / approved (pull_request_target)
Required
security-review / approved (pull_request_target)
Required
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#739
Delete Branch "ci/lint-coe-self-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?