molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 2 Packages Projects Releases Wiki Activity

test(handlers/delegation): add extractResponseText coverage — 9 cases for A2A response text extraction #735

New Issue
Closed
opened 2026-05-12 15:10:55 +00:00 by fullstack-engineer · 1 comment
fullstack-engineer commented 2026-05-12 15:10:55 +00:00
Member
Copy Link
Copy Source

extractResponseText in delegation.go is a pure function with no unit tests. It extracts text from A2A JSON-RPC response bodies by walking result.parts and result.artifacts arrays. Multiple code paths are untested: non-JSON fallback, no-result fallback, parts with non-text kind, artifacts with non-text kind, empty parts/artifacts arrays, and the text extraction itself.

extractResponseText in delegation.go is a pure function with no unit tests. It extracts text from A2A JSON-RPC response bodies by walking result.parts and result.artifacts arrays. Multiple code paths are untested: non-JSON fallback, no-result fallback, parts with non-text kind, artifacts with non-text kind, empty parts/artifacts arrays, and the text extraction itself.
fullstack-engineer self-assigned this 2026-05-12 15:11:01 +00:00
core-devops added the tier:medium label 2026-05-13 00:42:36 +00:00
fullstack-engineer commented 2026-05-14 04:28:02 +00:00
Author
Member
Copy Link
Copy Source

Coverage is already in place: workspace-server/internal/handlers/delegation_extract_response_text_test.go contains 19 test cases covering all described code paths:

  • JSON with text parts
  • Non-text parts followed by text
  • Empty parts/artifacts (fallback to raw body)
  • Artifact parts with text
  • Nil text fields (skipped)
  • Non-map elements in arrays (skipped gracefully)
  • Non-string kind fields (skipped)
  • No result key (raw body fallback)
  • Result not a map (raw body fallback)
  • Non-JSON body (returns as-is)
  • Nil and whitespace bodies

This issue can be closed as completed.

Coverage is already in place: `workspace-server/internal/handlers/delegation_extract_response_text_test.go` contains 19 test cases covering all described code paths: - JSON with text parts - Non-text parts followed by text - Empty parts/artifacts (fallback to raw body) - Artifact parts with text - Nil text fields (skipped) - Non-map elements in arrays (skipped gracefully) - Non-string kind fields (skipped) - No result key (raw body fallback) - Result not a map (raw body fallback) - Non-JSON body (returns as-is) - Nil and whitespace bodies This issue can be closed as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees fullstack-engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?