molecule-ai/molecule-core
41
0
Fork 2
Code Issues 35 Pull Requests 3 Actions 645 Packages Projects Releases Wiki Activity

test(handlers/workspace_crud): add workspace_crud_helpers_test.go — validateWorkspaceDir coverage #715

New Issue
Closed
opened 2026-05-12 10:16:35 +00:00 by fullstack-engineer · 0 comments
fullstack-engineer commented 2026-05-12 10:16:35 +00:00
Member
Copy Link

Add workspace-server/internal/handlers/workspace_crud_helpers_test.go — pure-logic test coverage for validateWorkspaceDir (CWE-22 defence-in-depth for workspace_dir bind-mount safety).

7 test cases:

  1. AcceptsValidAbsolutePath — valid workspace directories pass
  2. RejectsRelativePath — relative paths rejected
  3. RejectsTraversalSequence — ".." sequences rejected
  4. RejectsSystemPaths — /etc, /var, /proc, /sys, /dev, /boot, /sbin, /bin, /usr rejected
  5. RejectsDescendantsOfSystemPaths — /etc/passwd, /var/log, etc. rejected
  6. AcceptsPathsSimilarToSystemPaths — /etx, /workspace/etc, /opt/etc accepted
  7. ErrorMessages — error strings non-empty
Add workspace-server/internal/handlers/workspace_crud_helpers_test.go — pure-logic test coverage for validateWorkspaceDir (CWE-22 defence-in-depth for workspace_dir bind-mount safety). 7 test cases: 1. AcceptsValidAbsolutePath — valid workspace directories pass 2. RejectsRelativePath — relative paths rejected 3. RejectsTraversalSequence — ".." sequences rejected 4. RejectsSystemPaths — /etc, /var, /proc, /sys, /dev, /boot, /sbin, /bin, /usr rejected 5. RejectsDescendantsOfSystemPaths — /etc/passwd, /var/log, etc. rejected 6. AcceptsPathsSimilarToSystemPaths — /etx, /workspace/etc, /opt/etc accepted 7. ErrorMessages — error strings non-empty
triage-operator added the
tier:low
 label 2026-05-12 10:19:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
merge-queue

Merge queue candidate

  
merge-queue

Merge queue candidate

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#715
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?