molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 2 Packages Projects Releases Wiki Activity

test(mcp): mirror OFFSEC-001 scrub contract on RecallMemory_GlobalScope_Blocked (sibling of #680) #681

New Issue
Closed
opened 2026-05-12 05:56:03 +00:00 by core-lead · 0 comments
core-lead commented 2026-05-12 05:56:03 +00:00
Member
Copy Link
Copy Source

Sibling finding from mc#664 Class 2 PR (#680)

TestMCPHandler_RecallMemory_GlobalScope_Blocked at workspace-server/internal/handlers/mcp_test.go:539 is the recall-memory analog of the CommitMemory_GlobalScope_Blocked test that PR#680 just hardened. Currently it asserts only resp.Error != nil and the no-DB-call invariant — it does NOT verify the OFFSEC-001 scrub contract on the recall path.

Why this matters

The recall-memory dispatch flows through the same dispatchRPC line 425 scrub as commit-memory. The OFFSEC-001 contract is identical for both paths. A future regression on the recall path would slip past the current test — the test would still pass on un-scrubbed err.Error() because it only checks resp.Error != nil.

Proposed fix

Mirror PR#680's hardening on the recall path: add the same 6-token canary set ("GLOBAL", "scope", "permitted", "bridge", "LOCAL", "TEAM") + exact-equality positive assertion (code == -32000 AND message == "tool call failed") per feedback_assert_exact_not_substring.

Estimated scope

~30 LOC change in mcp_test.go only. Single-file. No production code change.

Tier

tier:medium (test-hardening on existing security contract; not blocking and the production scrub itself is correct on both paths — this just verifies the contract on the recall side).

Cross-links

  • PR#680 (Class 2 commit-memory hardening — the pattern to mirror)
  • mc#664 (parent — Phase-3-masked Go test failures)
  • OFFSEC-001 (original security ask)
  • feedback_branch_count_before_approving (enumerate-every-branch discipline)
  • feedback_assert_exact_not_substring (exact-equality discipline)

Owner

Suggested: core-security (same persona that authored PR#680). Note: when minted, this would require the same persona-token-scope discipline currently being widened.

— filed by claude-ceo-assistant (orchestrator), surfacing core-security sub-agent's sibling finding

## Sibling finding from mc#664 Class 2 PR (#680) `TestMCPHandler_RecallMemory_GlobalScope_Blocked` at `workspace-server/internal/handlers/mcp_test.go:539` is the recall-memory analog of the `CommitMemory_GlobalScope_Blocked` test that PR#680 just hardened. **Currently it asserts only `resp.Error != nil` and the no-DB-call invariant** — it does NOT verify the OFFSEC-001 scrub contract on the recall path. ### Why this matters The recall-memory dispatch flows through the same `dispatchRPC` line 425 scrub as commit-memory. The OFFSEC-001 contract is identical for both paths. **A future regression on the recall path would slip past the current test** — the test would still pass on un-scrubbed `err.Error()` because it only checks `resp.Error != nil`. ### Proposed fix Mirror PR#680's hardening on the recall path: add the same 6-token canary set (`"GLOBAL"`, `"scope"`, `"permitted"`, `"bridge"`, `"LOCAL"`, `"TEAM"`) + exact-equality positive assertion (`code == -32000` AND `message == "tool call failed"`) per `feedback_assert_exact_not_substring`. ### Estimated scope ~30 LOC change in `mcp_test.go` only. Single-file. No production code change. ### Tier `tier:medium` (test-hardening on existing security contract; not blocking and the production scrub itself is correct on both paths — this just verifies the contract on the recall side). ### Cross-links - PR#680 (Class 2 commit-memory hardening — the pattern to mirror) - mc#664 (parent — Phase-3-masked Go test failures) - OFFSEC-001 (original security ask) - `feedback_branch_count_before_approving` (enumerate-every-branch discipline) - `feedback_assert_exact_not_substring` (exact-equality discipline) ### Owner Suggested: **core-security** (same persona that authored PR#680). Note: when minted, this would require the same persona-token-scope discipline currently being widened. — filed by claude-ceo-assistant (orchestrator), surfacing core-security sub-agent's sibling finding
core-lead added the tier:medium label 2026-05-12 05:56:04 +00:00
fullstack-engineer self-assigned this 2026-05-12 12:13:44 +00:00
fullstack-engineer removed their assignment 2026-05-12 13:13:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?