molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 4 Packages Projects Releases Wiki Activity

Harden ssm_refresh_ecr_auth JSON parameter construction in scripts/promote-tenant-image.sh #676

New Issue
Closed
opened 2026-05-12 05:13:28 +00:00 by hongming · 0 comments
hongming commented 2026-05-12 05:13:28 +00:00
Owner
Copy Link
Copy Source

From

Five-Axis review of #672 (sub-agent dispatch, comment #14939) flagged this as a non-blocking medium-severity finding.

What

scripts/promote-tenant-image.sh:ssm_refresh_ecr_auth() builds the --parameters JSON via printf with shell-unquoted interpolation of $REGION and $ECR_ACCOUNT_ID:

printf '{"commands":["aws ecr get-login-password --region %s | docker login --username AWS --password-stdin %s.dkr.ecr.%s.amazonaws.com"]}' \
  "$REGION" "$acct" "$REGION" > "$params"

If either var contained a double-quote, backslash, or other JSON-special character, the resulting parameters file would be invalid JSON (or worse, a shell-command-injection seam if the embedded shell command splits on whitespace).

Exploit prerequisite: an attacker must already control the script's caller-supplied flags (--region, --repo) or the ECR_ACCOUNT_ID env var. That's an authenticated-operator threat model, not external — hence non-blocking. But the validation is cheap.

Fix

Validate at argparse time:

[[ "$REGION" =~ ^[a-z0-9-]+$ ]] || { printf 'invalid --region: %s\n' "$REGION" >&2; exit 64; }
[[ "${ECR_ACCOUNT_ID:-}" =~ ^[0-9]{12}$ ]] || { printf 'invalid ECR_ACCOUNT_ID: %s\n' "$ECR_ACCOUNT_ID" >&2; exit 64; }

Add a test case in scripts/test-promote-tenant-image.sh that asserts exit 64 when --region '"x";rm -rf /' is passed.

Tier

low — defense-in-depth on an authenticated-operator-only threat model. Easy fix.

Cross-link

  • Parent PR: #672 (merged with finding noted)
  • Five-Axis review comment: #14939
## From Five-Axis review of #672 (sub-agent dispatch, comment #14939) flagged this as a non-blocking medium-severity finding. ## What `scripts/promote-tenant-image.sh:ssm_refresh_ecr_auth()` builds the `--parameters` JSON via `printf` with shell-unquoted interpolation of `$REGION` and `$ECR_ACCOUNT_ID`: ```bash printf '{"commands":["aws ecr get-login-password --region %s | docker login --username AWS --password-stdin %s.dkr.ecr.%s.amazonaws.com"]}' \ "$REGION" "$acct" "$REGION" > "$params" ``` If either var contained a double-quote, backslash, or other JSON-special character, the resulting parameters file would be invalid JSON (or worse, a shell-command-injection seam if the embedded shell command splits on whitespace). Exploit prerequisite: an attacker must already control the script's caller-supplied flags (`--region`, `--repo`) or the `ECR_ACCOUNT_ID` env var. That's an authenticated-operator threat model, not external — hence non-blocking. But the validation is cheap. ## Fix Validate at argparse time: ```bash [[ "$REGION" =~ ^[a-z0-9-]+$ ]] || { printf 'invalid --region: %s\n' "$REGION" >&2; exit 64; } [[ "${ECR_ACCOUNT_ID:-}" =~ ^[0-9]{12}$ ]] || { printf 'invalid ECR_ACCOUNT_ID: %s\n' "$ECR_ACCOUNT_ID" >&2; exit 64; } ``` Add a test case in `scripts/test-promote-tenant-image.sh` that asserts exit 64 when `--region '"x";rm -rf /'` is passed. ## Tier low — defense-in-depth on an authenticated-operator-only threat model. Easy fix. ## Cross-link - Parent PR: #672 (merged with finding noted) - Five-Axis review comment: #14939
hongming added the tier:low label 2026-05-12 05:13:33 +00:00
core-security was assigned by hongming 2026-05-12 05:13:35 +00:00
core-security was unassigned by core-devops 2026-05-12 05:28:24 +00:00
core-devops self-assigned this 2026-05-12 05:28:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees core-devops
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#676
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?