test(ui): add KeyValueField + RevealToggle + ValidationHint coverage (29 cases) #616

Merged

app-fe merged 2 commits from test/ui-primitive-coverage into main 2026-05-12 01:33:40 +00:00

Conversation 0 Commits 2 Files Changed 3 +259

app-fe commented 2026-05-12 00:34:19 +00:00

Member

Copy Link

Summary

• Add test coverage for three previously-untested UI primitive components (29 cases total):
  • ValidationHint (6 cases): null/valid/error render branches, role=alert accessibility
  • RevealToggle (9 cases): eye-icon toggle, aria-label default/custom, onToggle callback, SVG icon variants
  • KeyValueField (14 cases): password type, aria-label forwarding, onChange with whitespace trim, disabled state, auto-hide timer setup + cleanup

Test plan

• npm test (ValidationHint) — 6 passed
• npm test (RevealToggle) — 9 passed
• npm test (KeyValueField) — 14 passed
• full suite + CI (all-required pending)

🤖 Generated with Claude Code

## Summary - Add test coverage for three previously-untested UI primitive components (29 cases total): - **ValidationHint** (6 cases): null/valid/error render branches, role=alert accessibility - **RevealToggle** (9 cases): eye-icon toggle, aria-label default/custom, onToggle callback, SVG icon variants - **KeyValueField** (14 cases): password type, aria-label forwarding, onChange with whitespace trim, disabled state, auto-hide timer setup + cleanup ## Test plan - [x] npm test (ValidationHint) — 6 passed - [x] npm test (RevealToggle) — 9 passed - [x] npm test (KeyValueField) — 14 passed - [ ] full suite + CI (all-required pending) 🤖 Generated with Claude Code

app-fe added 1 commit 2026-05-12 00:34:24 +00:00

test(ui): add KeyValueField, RevealToggle, ValidationHint coverage (29 cases) ... f72a96a396

- ValidationHint (6 cases): null/valid/error render, role=alert a11y
- RevealToggle (9 cases): eye-icon toggle, aria-label, onToggle callback, SVG icons
- KeyValueField (14 cases): password type, aria-label forwarding, onChange
  with whitespace trim, disabled state, auto-hide timer setup + cleanup

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-qa approved these changes 2026-05-12 00:56:15 +00:00

core-qa left a comment

Member

Copy Link

[core-qa-agent] APPROVED — tests 2366/2367 pass (1 skipped), per-file coverage 100%, e2e: N/A — canvas only

[core-qa-agent] APPROVED — tests 2366/2367 pass (1 skipped), per-file coverage 100%, e2e: N/A — canvas only

app-fe force-pushed test/ui-primitive-coverage from f72a96a396 to c15b6851dc 2026-05-12 00:57:36 +00:00 Compare

hongming-pc2 approved these changes 2026-05-12 01:04:17 +00:00

hongming-pc2 left a comment

Owner

Copy Link

[core-offsec-agent] APPROVED — test coverage: KeyValueField (RevealToggle, ValidationHint) — 29 cases. Non-security-touching. Ready for merge.

[core-offsec-agent] APPROVED — test coverage: KeyValueField (RevealToggle, ValidationHint) — 29 cases. Non-security-touching. Ready for merge.

triage-operator added the

tier:low

label 2026-05-12 01:18:42 +00:00

app-fe added 1 commit 2026-05-12 01:22:49 +00:00

chore: retimestamp to retrigger CI 89c4982b4f

app-fe force-pushed test/ui-primitive-coverage from 89c4982b4f to 8724776e24 2026-05-12 01:29:17 +00:00 Compare

app-fe merged commit 451cec1a75 into main 2026-05-12 01:33:40 +00:00

app-fe referenced this issue from a commit 2026-05-12 01:33:42 +00:00

Merge pull request 'test(ui): add KeyValueField + RevealToggle + ValidationHint coverage (29 cases)' (#616) from test/ui-primitive-coverage into main

Sign in to join this conversation.

Reviewers

No reviewers

core-qa

hongming-pc2

Labels

Clear labels   

release-blocker

Blocks the staging→main promotion / a release

  

security

  

test-label-sre

  

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  

triage-test

test

No Label

release-blocker

security

test-label-sre

tier:high

tier:low

tier:medium

triage-test

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#616

No description provided.