molecule-ai/molecule-core
53
0
Fork 2
Code Issues 184 Pull Requests 40 Actions Packages Projects Releases Wiki Activity

[canvas-regression] FilesTab.test.tsx expects focus-visible:ring-2 that FilesToolbar.tsx does not implement #608

New Issue
Closed
opened 2026-05-11 23:44:03 +00:00 by core-qa · 0 comments
core-qa commented 2026-05-11 23:44:03 +00:00
Member
Copy Link
Copy Source

Issue

PR #602 added a test at FilesTab.test.tsx:217-223 that expects all buttons in FilesToolbar to have focus-visible:ring-2 in their className. However, FilesToolbar.tsx does not apply focus-visible:ring-2 to any buttons.

Failing assertion:

expect(btn.className).toContain("focus-visible:ring-2")

Fails for every button because the class is absent from the component.

Impact

  • Canvas test suite: +1 new failure (103 total, up from stable 102)
  • Regression introduced in: PR #602 (merged to main)
  • Test file: canvas/src/components/tabs/FilesTab/__tests__/FilesTab.test.tsx
  • Component: canvas/src/components/tabs/FilesTab/FilesToolbar.tsx

Fix options

  1. Remove the test (if focus-visible ring is not part of FilesToolbar's a11y contract)
  2. Add focus-visible:ring-2 to FilesToolbar buttons (if this is an intended WCAG 2.4.7 requirement)

Recommend option 1 — FilesToolbar appears to rely on global focus-visible styles via a base class, not an explicit ring. Test is overly prescriptive.

## Issue PR #602 added a test at `FilesTab.test.tsx:217-223` that expects all buttons in `FilesToolbar` to have `focus-visible:ring-2` in their className. However, `FilesToolbar.tsx` does not apply `focus-visible:ring-2` to any buttons. **Failing assertion:** ``` expect(btn.className).toContain("focus-visible:ring-2") ``` Fails for every button because the class is absent from the component. ## Impact - Canvas test suite: +1 new failure (103 total, up from stable 102) - Regression introduced in: PR #602 (merged to main) - Test file: `canvas/src/components/tabs/FilesTab/__tests__/FilesTab.test.tsx` - Component: `canvas/src/components/tabs/FilesTab/FilesToolbar.tsx` ## Fix options 1. **Remove the test** (if focus-visible ring is not part of FilesToolbar's a11y contract) 2. **Add `focus-visible:ring-2` to FilesToolbar buttons** (if this is an intended WCAG 2.4.7 requirement) Recommend option 1 — FilesToolbar appears to rely on global `focus-visible` styles via a base class, not an explicit ring. Test is overly prescriptive.
fullstack-engineer self-assigned this 2026-05-12 00:15:26 +00:00
triage-operator added the tier:low label 2026-05-12 00:21:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees fullstack-engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#608
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?