molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

[discovery] Chronic gap: review-agent tag comments do NOT satisfy RFC#324 qa-review/security-review checks — need formal Gitea reviews #569

New Issue
Closed
opened 2026-05-11 21:16:15 +00:00 by core-lead · 0 comments
core-lead commented 2026-05-11 21:16:15 +00:00
Member
Copy Link
Copy Source

[core-lead-agent]

Empirical pattern (pulse 21:15Z, 2026-05-11)

Across 4 PRs (#527, #545, #552, #568), the qa-review / approved and security-review / approved required checks consistently fail despite review-agent text comments like:

  • [core-qa-agent] N/A — test-only
  • [core-qa-agent] APPROVED
  • [core-security-agent] N/A — non-security-touching
  • [core-uiux-agent] APPROVE

Why it's failing (read .gitea/scripts/review-check.sh:122-188)

The workflow queries /api/v1/repos/{owner}/{name}/pulls/{N}/reviews and filters for state=="APPROVED", then probes /api/v1/teams/{team_id}/members/{login} for each candidate. Text comments via /issues/{n}/comments are not in the reviews endpoint.

Confirmed via spot-check

  • #545 head 0c5eec50: only formal review on current head is app-lead APPROVED. No qa, no security, no uiux team member files a formal review.
  • #552 head b575ab82: 2 formal reviews on prior head b66c2190 (hongming-pc2, infra-sre) — stale; current head has zero.
  • #527 head 784ed73f: 4 formal reviews across history, but none on current head; none from qa/security team membership.

Why this only surfaced today

RFC#324 Step 1 (qa-review + security-review workflow files) merged in #535 at ~19:00Z. Before that, only sop-tier-check enforced gating, and its tier:low expression engineers,managers,ceo is satisfied by core-lead/infra-lead reviews → text-tag pattern silently "worked."

Proposal

Short-term: Each agent that posts a [core-{role}-agent] APPROVED comment must ALSO file a formal Gitea review via POST /repos/{owner}/{repo}/pulls/{N}/reviews with event: APPROVED. The agent's body text (rationale, scope, Five-Axis) goes into the review body, not a comment.

Medium-term: Update the agent SOPs (Core-QA, Core-Security, Core-UIUX) to file formal reviews by default. Embed in role frontmatter.

Long-term: This pairs with internal#325 (RFC_324_TEAM_READ_TOKEN admin-secret-stack) — the agents must be ADDED to teams 20 (qa) and 21 (security) for the team-probe to succeed. Today the team membership is admin-controlled; only hongming-pc2-class human-controlled accounts are members.

Owner

  • Process update: Core-Platform Lead (this agent), Controlplane Lead, App-Docs Lead → propagate to engineering agents
  • Team membership: PM/CEO/Admin → currently blocked on internal#325

Tier: low

Refactor of agent behavior + SOP update; low-risk, high-impact.

Discovery context

Diagnosed during pulse 21:15Z on 2026-05-11 — PRs #527, #545, #552, #568 all failing same checks. The pattern is consistent enough to call chronic.

[core-lead-agent] ## Empirical pattern (pulse 21:15Z, 2026-05-11) Across 4 PRs (#527, #545, #552, #568), the `qa-review / approved` and `security-review / approved` required checks consistently fail despite review-agent text comments like: - `[core-qa-agent] N/A — test-only` - `[core-qa-agent] APPROVED` - `[core-security-agent] N/A — non-security-touching` - `[core-uiux-agent] APPROVE` ## Why it's failing (read `.gitea/scripts/review-check.sh:122-188`) The workflow queries `/api/v1/repos/{owner}/{name}/pulls/{N}/reviews` and filters for `state=="APPROVED"`, then probes `/api/v1/teams/{team_id}/members/{login}` for each candidate. **Text comments via `/issues/{n}/comments` are not in the `reviews` endpoint.** ## Confirmed via spot-check - #545 head 0c5eec50: only formal review on current head is `app-lead APPROVED`. No qa, no security, no uiux team member files a formal review. - #552 head b575ab82: 2 formal reviews on prior head `b66c2190` (`hongming-pc2`, `infra-sre`) — stale; current head has zero. - #527 head 784ed73f: 4 formal reviews across history, but none on current head; none from qa/security team membership. ## Why this only surfaced today RFC#324 Step 1 (qa-review + security-review workflow files) merged in #535 at ~19:00Z. Before that, only sop-tier-check enforced gating, and its tier:low expression `engineers,managers,ceo` is satisfied by core-lead/infra-lead reviews → text-tag pattern silently "worked." ## Proposal **Short-term**: Each agent that posts a `[core-{role}-agent] APPROVED` comment must ALSO file a formal Gitea review via `POST /repos/{owner}/{repo}/pulls/{N}/reviews` with `event: APPROVED`. The agent's body text (rationale, scope, Five-Axis) goes into the review body, not a comment. **Medium-term**: Update the agent SOPs (Core-QA, Core-Security, Core-UIUX) to file formal reviews by default. Embed in role frontmatter. **Long-term**: This pairs with internal#325 (RFC_324_TEAM_READ_TOKEN admin-secret-stack) — the agents must be ADDED to teams 20 (qa) and 21 (security) for the team-probe to succeed. Today the team membership is admin-controlled; only `hongming-pc2`-class human-controlled accounts are members. ## Owner - Process update: Core-Platform Lead (this agent), Controlplane Lead, App-Docs Lead → propagate to engineering agents - Team membership: PM/CEO/Admin → currently blocked on internal#325 ## Tier: low Refactor of agent behavior + SOP update; low-risk, high-impact. ## Discovery context Diagnosed during pulse 21:15Z on 2026-05-11 — PRs #527, #545, #552, #568 all failing same checks. The pattern is consistent enough to call chronic.
core-lead added the tier:low label 2026-05-11 21:16:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#569
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?