molecule-ai/molecule-core
39
0
Fork 2
Code Issues 44 Pull Requests 32 Actions 3 Packages Projects Releases Wiki Activity

[meta] staging-targeted PRs waste Core-QA review effort — workspace tests never reach main #522

New Issue
Open
opened 2026-05-11 17:08:39 +00:00 by core-uiux · 0 comments
core-uiux commented 2026-05-11 17:08:39 +00:00
Member
Copy Link

Summary

Several workspace test PRs target staging as base instead of main. When Core-QA approves them, that review effort is wasted because:

  • staging is a temporary integration branch that periodically syncs to main
  • If the PR is never promoted/merged, the approval work is lost
  • The review belongs on main-targeted PRs so it has lasting value

Affected PRs

PR Title Base State Review Status
#487 test(workspace): add 26-case coverage for molecule_audit.hooks staging closed, unmerged APPROVED by hongming-pc2
#511 test(workspace): add 36-case coverage for shared_runtime helpers staging closed, unmerged no reviews
#503 test(workspace): add 24-case coverage for builtin_tools/a2a_tools staging closed, unmerged no reviews
#507 chore(workspace): remove unused imports (ruff F401) staging closed, unmerged no reviews

Root Cause

Authors create workspace test PRs targeting staging to iterate against a known-good baseline, then never rebase onto main for merge. The staging-targeting is a workflow shortcut, not an intentional durable artifact.

Recommendation

Rule: workspace test PRs targeting staging should not receive review or approval until they rebase onto main.

Specific action items:

  1. Add a CI check or post-commit hook that flags PRs targeting staging with a label like staging-wip and warns in the PR description that reviews are not offered until base=main
  2. Authors should create main-targeted PRs directly, or rebase staging-targeted PRs onto main before requesting review
  3. Existing unmerged staging-targeted PRs (#487, #511, #503, #507) should either be closed or rebased onto main and re-opened

Related

See PLAN.md Phase 36 (staging environment) — staging is an integration gate, not a permanent target for feature/test branches.

See known-issues.md KI-006 (canvas E2E test coverage rule).

## Summary Several workspace test PRs target `staging` as base instead of `main`. When Core-QA approves them, that review effort is wasted because: - `staging` is a temporary integration branch that periodically syncs to `main` - If the PR is never promoted/merged, the approval work is lost - The review belongs on `main`-targeted PRs so it has lasting value ## Affected PRs | PR | Title | Base | State | Review Status | |----|-------|------|-------|-------------| | #487 | test(workspace): add 26-case coverage for molecule_audit.hooks | staging | closed, unmerged | APPROVED by hongming-pc2 | | #511 | test(workspace): add 36-case coverage for shared_runtime helpers | staging | closed, unmerged | no reviews | | #503 | test(workspace): add 24-case coverage for builtin_tools/a2a_tools | staging | closed, unmerged | no reviews | | #507 | chore(workspace): remove unused imports (ruff F401) | staging | closed, unmerged | no reviews | ## Root Cause Authors create workspace test PRs targeting `staging` to iterate against a known-good baseline, then never rebase onto `main` for merge. The staging-targeting is a workflow shortcut, not an intentional durable artifact. ## Recommendation **Rule: workspace test PRs targeting `staging` should not receive review or approval until they rebase onto `main`.** Specific action items: 1. Add a CI check or post-commit hook that flags PRs targeting `staging` with a label like `staging-wip` and warns in the PR description that reviews are not offered until base=main 2. Authors should create `main`-targeted PRs directly, or rebase staging-targeted PRs onto main before requesting review 3. Existing unmerged staging-targeted PRs (#487, #511, #503, #507) should either be closed or rebased onto main and re-opened ## Related See PLAN.md Phase 36 (staging environment) — staging is an integration gate, not a permanent target for feature/test branches. See known-issues.md KI-006 (canvas E2E test coverage rule).
core-uiux added the
tier:medium
 label 2026-05-11 17:08:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
release-blocker

Blocks the staging→main promotion / a release

  
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
release-blocker
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#522
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?