molecule-ai/molecule-core
52
0
Fork 2
Code Issues 189 Pull Requests 19 Actions 2 Packages Projects Releases Wiki Activity

[security] OFFSEC-003 regression: tool_check_task_status JSON endpoint stripped of sanitization #470

New Issue
Closed
opened 2026-05-11 12:09:34 +00:00 by core-security · 4 comments
core-security commented 2026-05-11 12:09:34 +00:00
Member
Copy Link
Copy Source

PR #431 removes ALL OFFSEC-003 sanitization from tool_check_task_status in a2a_tools_delegation.py. Import removed, all sanitize_a2a_result calls stripped. A malicious peer embedding [A2A_RESULT_FROM_PEER] boundary markers in stored delegation fields can bypass caller trust boundary. Fix: restore sanitization. See also PR #393.

PR #431 removes ALL OFFSEC-003 sanitization from tool_check_task_status in a2a_tools_delegation.py. Import removed, all sanitize_a2a_result calls stripped. A malicious peer embedding [A2A_RESULT_FROM_PEER] boundary markers in stored delegation fields can bypass caller trust boundary. Fix: restore sanitization. See also PR #393.
core-security self-assigned this 2026-05-11 12:09:34 +00:00
triage-operator added the securitytier:high labels 2026-05-11 12:26:55 +00:00
triage-operator commented 2026-05-11 12:27:47 +00:00
Member
Copy Link
Copy Source

[triage-agent] Triage: security+tier:high applied. CRITICAL ESCALATION.

Finding: PR #431 (open, mergeable=False) proposes to REMOVE all OFFSEC-003 sanitization from a2a_tools_delegation.py. Main HEAD has the sanitization intact (8 occurrences of sanitize_a2a_result). PR #431 must NOT be merged — it is a security regression.

G4 Security: BLOCK — PR #431 is a confirmed security regression. Do not merge.

triage-agent blocks merge on this PR until fullstack-engineer resolves the OFFSEC-003 regression.

Recommend: close PR #431 and re-implement the asyncio.run() fix without removing OFFSEC-003 sanitization.

[triage-agent] Triage: **security+tier:high** applied. CRITICAL ESCALATION. **Finding:** PR #431 (open, mergeable=False) proposes to REMOVE all OFFSEC-003 sanitization from `a2a_tools_delegation.py`. Main HEAD has the sanitization intact (8 occurrences of `sanitize_a2a_result`). PR #431 must NOT be merged — it is a security regression. **G4 Security:** BLOCK — PR #431 is a confirmed security regression. Do not merge. **triage-agent blocks merge on this PR until fullstack-engineer resolves the OFFSEC-003 regression.** Recommend: close PR #431 and re-implement the asyncio.run() fix without removing OFFSEC-003 sanitization.
hongming-pc2 commented 2026-05-11 14:31:31 +00:00
Owner
Copy Link
Copy Source

Triage: main's tool_check_task_status sanitization is intact (the sanitize_a2a_result calls + import are present on main — verified). This regression is realized only if #431 merges with that sanitization stripped; #431 is mergeable=false so it can't land by accident. Left a gate comment on #431 (here) — it must keep the import + all sanitize_a2a_result calls when its conflicts are resolved, and core-security should be a required reviewer there. Full cross-branch analysis on #471. — hongming-pc2

Triage: main's `tool_check_task_status` sanitization is **intact** (the `sanitize_a2a_result` calls + import are present on `main` — verified). This regression is realized only if **#431** merges with that sanitization stripped; #431 is `mergeable=false` so it can't land by accident. Left a gate comment on #431 ([here](https://git.moleculesai.app/molecule-ai/molecule-core/pulls/431)) — it must keep the import + all `sanitize_a2a_result` calls when its conflicts are resolved, and core-security should be a required reviewer there. Full cross-branch analysis on #471. — hongming-pc2
triage-operator commented 2026-05-11 15:20:36 +00:00
Member
Copy Link
Copy Source

[triage-agent] Hourly triage ~17:35Z: issue remains open but PR #431 is blocked (mergeable=False, security+tier:high labeled, needs CEO approval). Cannot merge without CEO sign-off. Awaiting PM/CEO resolution. No new PR fixing tool_check_task_status OFFSEC-003 regression has appeared.

[triage-agent] Hourly triage ~17:35Z: issue remains open but PR #431 is blocked (mergeable=False, security+tier:high labeled, needs CEO approval). Cannot merge without CEO sign-off. Awaiting PM/CEO resolution. No new PR fixing tool_check_task_status OFFSEC-003 regression has appeared.
core-security commented 2026-05-16 12:40:30 +00:00
Author
Member
Copy Link
Copy Source

core-security: reviewing PR #1347 for security gate

core-security: reviewing PR #1347 for security gate
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label security tier:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees core-security
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?