molecule-ai/molecule-core
53
0
Fork 2
Code Issues 190 Pull Requests 45 Actions 2 Packages Projects Releases Wiki Activity

readStoredProviderSecret fails open on decrypt error -> BYOK concierge can be mis-pinned to platform #3162

New Issue
Open
opened 2026-06-22 19:02:26 +00:00 by hongming · 0 comments
hongming commented 2026-06-22 19:02:26 +00:00
Owner
Copy Link
Copy Source

readStoredProviderSecret (workspace-server/internal/handlers/platform_agent.go) returns "" on any decrypt/read error, treated as 'provider unset'. Combined with the empty-MODEL platform pin from #3160, a BYOK/self-host concierge that hits a transient decrypt failure while its MODEL is momentarily empty (rebuilt-from-DB payload) could be pinned LLM_PROVIDER=platform and mis-routed onto the platform proxy.

Not introduced by #3160 — #3160 only un-gated the empty-MODEL case; the fail-open read predates it. But the two compose into a real (narrow) mis-pin window.

Suggested fix: distinguish a decrypt/read error from a genuine 'not set' (e.g. return a sentinel/err) so the pin logic can fail closed (skip the pin, or retry) rather than treating a transient decrypt error as 'no provider stored'.

Found during the #3160/#161 review (CEO adversarial pass) — pre-existing, NOT introduced by those PRs. Tracking separately.

🤖 Generated with Claude Code

`readStoredProviderSecret` (workspace-server/internal/handlers/platform_agent.go) returns `""` on any decrypt/read error, treated as 'provider unset'. Combined with the empty-MODEL platform pin from #3160, a BYOK/self-host concierge that hits a *transient* decrypt failure while its MODEL is momentarily empty (rebuilt-from-DB payload) could be pinned `LLM_PROVIDER=platform` and mis-routed onto the platform proxy. **Not introduced by #3160** — #3160 only un-gated the empty-MODEL case; the fail-open read predates it. But the two compose into a real (narrow) mis-pin window. **Suggested fix:** distinguish a decrypt/read *error* from a genuine 'not set' (e.g. return a sentinel/err) so the pin logic can fail closed (skip the pin, or retry) rather than treating a transient decrypt error as 'no provider stored'. Found during the #3160/#161 review (CEO adversarial pass) — pre-existing, NOT introduced by those PRs. Tracking separately. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?