molecule-ai/molecule-core
53
0
Fork 2
Code Issues 185 Pull Requests 49 Actions Packages Projects Releases Wiki Activity

Contract test: pin MCP-plugin delivery path (adaptor write == executor read) across core + claude-code template #3080

New Issue
Closed
opened 2026-06-19 21:06:39 +00:00 by core-devops · 0 comments
core-devops commented 2026-06-19 21:06:39 +00:00
Member
Copy Link
Copy Source

Prevention for the core#3079 class (a plugin-delivered MCP server written to a file the consumer ignores).

The MCP-plugin delivery path was unpinned across two repos: core's MCPServerAdaptor writes mcpServers to /configs/.claude/settings.json; the claude-code template executor reads config.yaml + mcp_servers.yaml and (via --strict-mcp-config) ignored settings.json. Nothing failed when they diverged.

Ask: a producer↔consumer contract test (same pattern as the provision-request contract test, core#3058 / cp#871):

  • A committed mcp-plugin-delivery.contract.json (byte-identical in molecule-core and molecule-ai-workspace-template-claude-code) declaring the canonical delivery: settings_path=/configs/.claude/settings.json, key=mcpServers, shape name->{command,args,env}.
  • Core test: assert MCPServerAdaptor writes to the contract path/key.
  • Template test: assert the executor's read set INCLUDES the contract path (extend test_extra_mcp_servers.py).
  • A drift gate (reuse ci-required-drift machinery) that fails if the two contract files diverge.
    Catches the divergence at PR time instead of in prod.
**Prevention for the core#3079 class** (a plugin-delivered MCP server written to a file the consumer ignores). The MCP-plugin delivery path was unpinned across two repos: core's `MCPServerAdaptor` *writes* mcpServers to `/configs/.claude/settings.json`; the claude-code template executor *reads* config.yaml + `mcp_servers.yaml` and (via `--strict-mcp-config`) ignored settings.json. Nothing failed when they diverged. **Ask:** a producer↔consumer contract test (same pattern as the provision-request contract test, core#3058 / cp#871): - A committed `mcp-plugin-delivery.contract.json` (byte-identical in molecule-core **and** molecule-ai-workspace-template-claude-code) declaring the canonical delivery: `settings_path=/configs/.claude/settings.json`, `key=mcpServers`, shape `name->{command,args,env}`. - Core test: assert `MCPServerAdaptor` writes to the contract path/key. - Template test: assert the executor's read set INCLUDES the contract path (extend test_extra_mcp_servers.py). - A drift gate (reuse ci-required-drift machinery) that fails if the two contract files diverge. Catches the divergence at PR time instead of in prod.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?