molecule-ai/molecule-core
53
0
Fork 2
Code Issues 187 Pull Requests 45 Actions 3 Packages Projects Releases Wiki Activity

merge-queue counts a dismissed/superseded REQUEST_CHANGES as an open block (no latest-per-user / dismissed filter) #3068

New Issue
Closed
opened 2026-06-19 07:18:12 +00:00 by molecule-code-reviewer · 0 comments
molecule-code-reviewer commented 2026-06-19 07:18:12 +00:00
Member
Copy Link
Copy Source

Bug: merge-queue counts a DISMISSED / superseded REQUEST_CHANGES as an open block

On PR #3066: agent-researcher posted REQUEST_CHANGES (05:55Z) then APPROVED on the same head (06:43Z); the REQUEST_CHANGES was also explicitly dismissed (review 12494 → dismissed:true). The reviews API shows the effective state as agent-reviewer-cr2: APPROVED (active) + agent-researcher: APPROVED (active), RC dismissed. mergeable=True, required checks green.

Yet gitea-merge-queue.py kept logging for 25+ min:

::notice::PR #3066 decision=wait: open REQUEST_CHANGES on current head from: agent-researcher

i.e. it counted the historical, dismissed, superseded REQUEST_CHANGES — it does not (a) take the latest review per user, nor (b) skip dismissed reviews. A genuinely 2-approved, green, mergeable PR was blocked. Had to merge manually (owner, non-author) to unblock.

Fix

In the queue's review evaluation (review-check.sh / _approval_validator.py / gitea-merge-queue.py): when scanning reviews, dedupe to the latest review per user and exclude dismissed:true before treating any as an open REQUEST_CHANGES. Mirror Gitea's own effective-review semantics.

Impact

Any PR where a reviewer flips REQUEST_CHANGES → APPROVED (the normal re-review flow) stays stuck in the queue until someone manually merges or deletes the old review. Surfaced while driving the concierge create_workspace chain (#3066).

## Bug: merge-queue counts a DISMISSED / superseded REQUEST_CHANGES as an open block On PR #3066: `agent-researcher` posted REQUEST_CHANGES (05:55Z) then **APPROVED on the same head** (06:43Z); the REQUEST_CHANGES was also explicitly **dismissed** (review 12494 → `dismissed:true`). The reviews API shows the effective state as `agent-reviewer-cr2: APPROVED (active)` + `agent-researcher: APPROVED (active)`, RC `dismissed`. `mergeable=True`, required checks green. Yet `gitea-merge-queue.py` kept logging for 25+ min: ``` ::notice::PR #3066 decision=wait: open REQUEST_CHANGES on current head from: agent-researcher ``` i.e. it counted the **historical, dismissed, superseded** REQUEST_CHANGES — it does not (a) take the latest review per user, nor (b) skip `dismissed` reviews. A genuinely 2-approved, green, mergeable PR was blocked. Had to merge manually (owner, non-author) to unblock. ## Fix In the queue's review evaluation (review-check.sh / _approval_validator.py / gitea-merge-queue.py): when scanning reviews, **dedupe to the latest review per user** and **exclude `dismissed:true`** before treating any as an open REQUEST_CHANGES. Mirror Gitea's own effective-review semantics. ## Impact Any PR where a reviewer flips REQUEST_CHANGES → APPROVED (the normal re-review flow) stays stuck in the queue until someone manually merges or deletes the old review. Surfaced while driving the concierge create_workspace chain (#3066).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?